File.pathSeparatorChar should be used to split value of "java.class.path" property

Author: Godin

sonar-kotlin-api/src/test/java/org/sonarsource/kotlin/api/checks/ApiExtensionsKtTest.kt

@@ -60,6 +60,7 @@ import org.sonar.api.internal.SonarRuntimeImpl
 import org.sonar.api.utils.Version
 import org.sonarsource.kotlin.api.frontend.Environment
 import org.sonarsource.kotlin.testapi.kotlinTreeOf
+import java.io.File
 import java.nio.charset.StandardCharsets
 import java.nio.file.Path
 import java.util.TreeMap
@@ -703,7 +704,7 @@ class ApiExtensionsScopeFunctionResolutionTest {
 private fun parse(code: String) = kotlinTreeOf(
     code,
     Environment(
-        listOf("build/classes/kotlin/main") + System.getProperty("java.class.path").split(System.getProperty("path.separator")),
+        listOf("build/classes/kotlin/main") + System.getProperty("java.class.path").split(File.pathSeparatorChar),
         LanguageVersion.LATEST_STABLE
     ),
     TestInputFileBuilder("moduleKey", "src/org/foo/kotlin.kt")
@@ -714,7 +715,7 @@ private fun parse(code: String) = kotlinTreeOf(
 
 private fun parseWithoutParsingExceptions(code: String): KtFile {
     val environment = Environment(
-        listOf("build/classes/kotlin/main") + System.getProperty("java.class.path").split(System.getProperty("path.separator")),
+        listOf("build/classes/kotlin/main") + System.getProperty("java.class.path").split(File.pathSeparatorChar),
         LanguageVersion.LATEST_STABLE
     )
     val inputFile = TestInputFileBuilder("moduleKey", "src/org/foo/kotlin.kt")

sonar-kotlin-api/src/test/java/org/sonarsource/kotlin/api/frontend/KotlinSyntaxStructureTest.kt

@@ -31,6 +31,7 @@ import org.junit.jupiter.api.Test
 import org.junit.jupiter.api.assertThrows
 import org.sonar.api.batch.fs.internal.TestInputFileBuilder
 import org.sonarsource.kotlin.testapi.kotlinTreeOf
+import java.io.File
 import java.nio.charset.StandardCharsets
 import java.nio.file.Path
 import kotlin.io.path.readText
@@ -52,7 +53,7 @@ internal class KotlinSyntaxStructureTest {
         every { BindingContextUtils.getRecordedTypeInfo(any(), any()) } throws expectedException
 
         val content = path.readText()
-        val environment = Environment(System.getProperty("java.class.path").split(":"), LanguageVersion.LATEST_STABLE)
+        val environment = Environment(System.getProperty("java.class.path").split(File.pathSeparatorChar), LanguageVersion.LATEST_STABLE)
         val inputFile = TestInputFileBuilder("moduleKey", path.toString())
             .setCharset(StandardCharsets.UTF_8)
             .initMetadata(content).build()

sonar-kotlin-checks/src/test/java/org/sonarsource/kotlin/checks/UnnecessaryImportsCheckTest.kt

@@ -21,13 +21,14 @@ package org.sonarsource.kotlin.checks
 
 import org.junit.jupiter.api.Test
 import org.sonarsource.kotlin.testapi.KotlinVerifier
+import java.io.File
 
 class UnnecessaryImportsCheckTest : CheckTestWithNoSemantics(UnnecessaryImportsCheck(), shouldReport = true) {
     @Test
     fun `with partial semantics`() {
         KotlinVerifier(check) {
             this.fileName = "${checkName}SamplePartialSemantics.kt"
-            this.classpath = System.getProperty("java.class.path").split(":")
+            this.classpath = System.getProperty("java.class.path").split(File.pathSeparatorChar)
             this.deps = emptyList()
         }.verify()
     }

sonar-kotlin-checks/src/test/java/org/sonarsource/kotlin/checks/UnusedLocalVariableCheckTest.kt

@@ -22,14 +22,15 @@ package org.sonarsource.kotlin.checks
 import org.junit.jupiter.api.Test
 import org.sonarsource.kotlin.testapi.DEFAULT_KOTLIN_CLASSPATH
 import org.sonarsource.kotlin.testapi.KotlinVerifier
+import java.io.File
 
 class UnusedLocalVariableCheckTest : CheckTestWithNoSemantics(UnusedLocalVariableCheck()) {
 
     @Test
     fun `with partial semantics`() {
         KotlinVerifier(check) {
             this.fileName = "${checkName}SamplePartialSemantics.kt"
-            this.classpath = DEFAULT_KOTLIN_CLASSPATH + System.getProperty("java.class.path").split(":")
+            this.classpath = DEFAULT_KOTLIN_CLASSPATH + System.getProperty("java.class.path").split(File.pathSeparatorChar)
             this.deps = emptyList()
         }.verifyNoIssue()
     }

sonar-kotlin-checks/src/test/java/org/sonarsource/kotlin/checks/VarShouldBeValCheckTest.kt

@@ -22,14 +22,15 @@ package org.sonarsource.kotlin.checks
 import org.junit.jupiter.api.Test
 import org.sonarsource.kotlin.testapi.DEFAULT_KOTLIN_CLASSPATH
 import org.sonarsource.kotlin.testapi.KotlinVerifier
+import java.io.File
 
 class VarShouldBeValCheckTest : CheckTestWithNoSemantics(VarShouldBeValCheck(), shouldReport=true) {
 
     @Test
     fun `with partial semantics`() {
         KotlinVerifier(check) {
             this.fileName = "${checkName}Sample.kt"
-            this.classpath = DEFAULT_KOTLIN_CLASSPATH + System.getProperty("java.class.path").split(":")
+            this.classpath = DEFAULT_KOTLIN_CLASSPATH + System.getProperty("java.class.path").split(File.pathSeparatorChar)
             this.deps = emptyList()
         }.verify()
     }

sonar-kotlin-metrics/src/test/java/org/sonarsource/kotlin/metrics/IssueSuppressionVisitorTest.kt

@@ -39,6 +39,7 @@ import org.sonarsource.kotlin.testapi.DEFAULT_KOTLIN_CLASSPATH
 import org.sonarsource.kotlin.testapi.KOTLIN_BASE_DIR
 import org.sonarsource.kotlin.testapi.kotlinTreeOf
 import org.sonarsource.kotlin.testapi.TestContext
+import java.io.File
 import java.nio.charset.StandardCharsets
 import java.nio.file.Files
 import java.nio.file.Path
@@ -81,7 +82,7 @@ class IssueSuppressionVisitorTest {
         )
 
     private fun scanFile(path: Path, suppress: Boolean, check: AbstractCheck, vararg checks: AbstractCheck): SingleFileVerifier {
-        val env = Environment(System.getProperty("java.class.path").split(System.getProperty("path.separator")) + DEFAULT_KOTLIN_CLASSPATH, LanguageVersion.LATEST_STABLE)
+        val env = Environment(System.getProperty("java.class.path").split(File.pathSeparatorChar) + DEFAULT_KOTLIN_CLASSPATH, LanguageVersion.LATEST_STABLE)
         val verifier = SingleFileVerifier.create(path, StandardCharsets.UTF_8)
         val testFileContent = String(Files.readAllBytes(path), StandardCharsets.UTF_8)
         val inputFile = TestInputFileBuilder("moduleKey", "src/org/foo/kotlin.kt")

sonar-kotlin-test-api/src/main/java/org/sonarsource/kotlin/testapi/KotlinVerifier.kt

@@ -31,6 +31,7 @@ import org.sonarsource.kotlin.api.frontend.Environment
 import org.sonarsource.kotlin.api.frontend.KotlinTree
 import org.sonarsource.kotlin.api.visiting.Comment
 import org.sonarsource.kotlin.api.visiting.CommentAnnotationsAndTokenVisitor
+import java.io.File
 import java.io.IOException
 import java.nio.charset.StandardCharsets
 import java.nio.file.FileVisitResult
@@ -51,7 +52,7 @@ class KotlinVerifier(private val check: AbstractCheck) {
 
     var fileName: String = ""
     var baseDir: Path = KOTLIN_BASE_DIR
-    var classpath: List<String> = System.getProperty("java.class.path").split(System.getProperty("path.separator")) + DEFAULT_KOTLIN_CLASSPATH
+    var classpath: List<String> = System.getProperty("java.class.path").split(File.pathSeparatorChar) + DEFAULT_KOTLIN_CLASSPATH
     var deps: List<String> = getClassPath(DEFAULT_TEST_JARS_DIRECTORY)
     var isAndroid = false
     var customDiagnostics: List<Diagnostic>? = null