SONARKT-400 Migrate UselessIncrementCheck to kotlin-analysis-api

Author: Godin

sonar-kotlin-api/src/main/java/org/sonarsource/kotlin/api/checks/ApiExtensions.kt

@@ -30,6 +30,7 @@ import org.jetbrains.kotlin.analysis.api.resolution.successfulCallOrNull
 import org.jetbrains.kotlin.analysis.api.resolution.successfulFunctionCallOrNull
 import org.jetbrains.kotlin.analysis.api.resolution.symbol
 import org.jetbrains.kotlin.analysis.api.symbols.KaAnonymousFunctionSymbol
+import org.jetbrains.kotlin.analysis.api.symbols.KaLocalVariableSymbol
 import org.jetbrains.kotlin.analysis.api.symbols.KaSymbol
 import org.jetbrains.kotlin.analysis.api.symbols.KaValueParameterSymbol
 import org.jetbrains.kotlin.analysis.api.symbols.KaVariableSymbol
@@ -764,9 +765,15 @@ fun KtExpression.isInitializedPredictably(searchStartNode: KtExpression, binding
 /**
  * Checks if an expression is a function local variable
  */
+@Deprecated("use kotlin-analysis-api instead", replaceWith = ReplaceWith("isLocalVariable()"))
 fun KtExpression?.isLocalVariable(bindingContext: BindingContext) =
     (this is KtNameReferenceExpression) && (bindingContext[BindingContext.REFERENCE_TARGET, this] is LocalVariableDescriptor)
 
+fun KtExpression?.isLocalVariable(): Boolean = withKaSession {
+    if (this@isLocalVariable !is KtNameReferenceExpression) return false
+    return mainReference.resolveToSymbol() is KaLocalVariableSymbol
+}
+
 fun KtExpression?.setterMatches(bindingContext: BindingContext, propertyName: String, matcher: FunMatcherImpl): Boolean = when (this) {
     is KtNameReferenceExpression -> (getReferencedName() == propertyName) &&
         (matcher.matches((bindingContext[BindingContext.REFERENCE_TARGET, this] as? PropertyDescriptor)?.unwrappedSetMethod))

sonar-kotlin-checks/src/main/java/org/sonarsource/kotlin/checks/UselessIncrementCheck.kt

@@ -30,13 +30,12 @@ import org.sonarsource.kotlin.api.frontend.KotlinFileContext
 private val POSTFIX_INCREMENT_OPERATORS = listOf(KtTokens.PLUSPLUS, KtTokens.MINUSMINUS)
 private const val MESSAGE = "Remove this increment or correct the code not to waste it."
 
-@org.sonarsource.kotlin.api.frontend.K1only
 @Rule(key = "S2123")
 class UselessIncrementCheck : AbstractCheck() {
 
     override fun visitReturnExpression(returnExpression: KtReturnExpression, ctx: KotlinFileContext) {
         returnExpression.returnedExpression.asPostfixIncrement()?.let {
-            if (it.baseExpression.isLocalVariable(ctx.bindingContext)) {
+            if (it.baseExpression.isLocalVariable()) {
                 ctx.reportIssue(it, MESSAGE)
             }
         }