SONARKT-400 Migrate ArrayHashCodeAndToStringCheck to kotlin-analysis-api

Author: leveretka

sonar-kotlin-checks/src/main/java/org/sonarsource/kotlin/checks/ArrayHashCodeAndToStringCheck.kt

@@ -16,16 +16,18 @@
  */
 package org.sonarsource.kotlin.checks
 
-import org.jetbrains.kotlin.js.descriptorUtils.getKotlinTypeFqName
+import org.jetbrains.kotlin.analysis.api.resolution.KaFunctionCall
+import org.jetbrains.kotlin.analysis.api.resolution.symbol
+import org.jetbrains.kotlin.analysis.api.symbols.name
+import org.jetbrains.kotlin.analysis.api.types.symbol
 import org.jetbrains.kotlin.psi.KtCallExpression
-import org.jetbrains.kotlin.resolve.calls.model.ResolvedCall
 import org.sonar.check.Rule
 import org.sonarsource.kotlin.api.checks.CallAbstractCheck
 import org.sonarsource.kotlin.api.checks.FunMatcher
 import org.sonarsource.kotlin.api.checks.FunMatcherImpl
-import org.sonarsource.kotlin.api.checks.determineType
 import org.sonarsource.kotlin.api.checks.predictReceiverExpression
 import org.sonarsource.kotlin.api.frontend.KotlinFileContext
+import org.sonarsource.kotlin.api.visiting.withKaSession
 
 private val OBJECT_ARRAY_MATCHER = FunMatcher(qualifier = "kotlin.Array") {
     withNames("hashCode", "toString")
@@ -52,22 +54,21 @@ private val PRIMITIVE_ARRAY_REPLACEMENT = mapOf("hashCode" to "contentHashCode",
 private val OBJECT_ARRAY_REPLACEMENT = mapOf("hashCode" to "contentDeepHashCode", "toString" to "contentDeepToString")
 private val ARRAY_OF_ARRAY_REPLACEMENT = mapOf("contentHashCode" to "contentDeepHashCode", "contentToString" to "contentDeepToString")
 
-@org.sonarsource.kotlin.api.frontend.K1only
 @Rule(key = "S2116")
 class ArrayHashCodeAndToStringCheck : CallAbstractCheck() {
 
     override val functionsToVisit = listOf(OBJECT_ARRAY_MATCHER, ARRAY_CONTENT_MATCHER) + PRIMITIVE_ARRAY_MATCHERS
 
     override fun visitFunctionCall(
         callExpression: KtCallExpression,
-        resolvedCall: ResolvedCall<*>,
+        resolvedCall: KaFunctionCall<*>,
         matchedFun: FunMatcherImpl,
-        kotlinFileContext: KotlinFileContext,
+        kotlinFileContext: KotlinFileContext
     ) {
-        val methodName = resolvedCall.resultingDescriptor.name.asString()
+        val methodName = resolvedCall.partiallyAppliedSymbol.symbol.name?.asString()
         val replacement = when (matchedFun) {
             OBJECT_ARRAY_MATCHER -> OBJECT_ARRAY_REPLACEMENT[methodName]
-            ARRAY_CONTENT_MATCHER -> if (receiverIsArrayOfArray(callExpression, kotlinFileContext))
+            ARRAY_CONTENT_MATCHER -> if (receiverIsArrayOfArray(callExpression))
                 ARRAY_OF_ARRAY_REPLACEMENT[methodName] else null
 
             else -> PRIMITIVE_ARRAY_REPLACEMENT[methodName]
@@ -77,11 +78,9 @@ class ArrayHashCodeAndToStringCheck : CallAbstractCheck() {
         }
     }
 
-    private fun receiverIsArrayOfArray(callExpression: KtCallExpression, kotlinFileContext: KotlinFileContext): Boolean {
-        val bindingContext = kotlinFileContext.bindingContext
-        return callExpression.predictReceiverExpression(bindingContext)?.determineType(bindingContext)?.arguments
-                ?.any { ARRAY_QUALIFIERS.contains(it.type.getKotlinTypeFqName(false)) }
-            ?: false
+    private fun receiverIsArrayOfArray(callExpression: KtCallExpression): Boolean = withKaSession {
+        val argument = callExpression.predictReceiverExpression()?.expressionType?.arrayElementType
+        return ARRAY_QUALIFIERS.contains(argument?.symbol?.classId?.asFqNameString())
     }
 
 }