Skip to content

Commit ab38756

Browse files
committed
(WIP)
1 parent 72d3ee7 commit ab38756

File tree

3 files changed

+3
-20
lines changed

3 files changed

+3
-20
lines changed

build.gradle.kts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -155,6 +155,7 @@ subprojects {
155155
(it.startsWith("orchestrator") || it.startsWith("sonar") || it == "buildNumber" || it == "slangVersion")
156156
}.mapKeys { it.key as String }
157157

158+
// TODO remove:
158159
if (systemProperties.containsKey("buildNumber") && !systemProperties.containsKey("slangVersion")) {
159160
systemProperties["slangVersion"] = version
160161
}

its/plugin/src/test/java/org/sonarsource/slang/TestsHelper.java

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -52,19 +52,10 @@ public class TestsHelper {
5252
}
5353

5454
static void addLanguagePlugins(OrchestratorBuilder builder) {
55-
String slangVersion = System.getProperty("slangVersion");
56-
5755
LANGUAGES.forEach(language -> {
5856
Location pluginLocation;
5957
String plugin = "sonar-" + language +"-plugin";
60-
if (slangVersion == null || slangVersion.isEmpty()) {
61-
// use the plugin that was built on local machine
62-
pluginLocation = FileLocation.byWildcardMavenFilename(new File("../../" + plugin + "/build/libs"), plugin + ".jar");
63-
} else {
64-
// QA environment downloads the plugin built by the CI job
65-
pluginLocation = MavenLocation.of("org.sonarsource.kotlin", plugin, slangVersion);
66-
}
67-
58+
pluginLocation = FileLocation.byWildcardMavenFilename(new File("../../" + plugin + "/build/libs"), plugin + ".jar");
6859
builder.addPlugin(pluginLocation);
6960
});
7061
}

its/ruling/src/test/java/org/sonarsource/slang/SlangRulingTest.java

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -83,19 +83,10 @@ public static void setUp() {
8383
}
8484

8585
private static void addLanguagePlugins(OrchestratorBuilder builder) {
86-
String slangVersion = System.getProperty("slangVersion");
87-
8886
LANGUAGES.forEach(language -> {
8987
Location pluginLocation;
9088
String plugin = "sonar-" + language +"-plugin";
91-
if (slangVersion == null || slangVersion.isEmpty()) {
92-
// use the plugin that was built on local machine
93-
pluginLocation = FileLocation.byWildcardMavenFilename(new File("../../" + plugin + "/build/libs"), plugin + ".jar");
94-
} else {
95-
// QA environment downloads the plugin built by the CI job
96-
pluginLocation = MavenLocation.of("org.sonarsource.kotlin", plugin, slangVersion);
97-
}
98-
89+
pluginLocation = FileLocation.byWildcardMavenFilename(new File("../../" + plugin + "/build/libs"), plugin + ".jar");
9990
builder.addPlugin(pluginLocation);
10091
});
10192
}

0 commit comments

Comments
 (0)