sonar-kotlin-surefire should not depend on sonar-kotlin-api

Author: Godin

sonar-kotlin-surefire/build.gradle.kts

@@ -9,13 +9,10 @@ dependencies {
     implementation(libs.sonar.xml.parsing)
     implementation(libs.sonar.regex.parsing)
     implementation(libs.sonar.performance.measure)
-    implementation(libs.kotlin.compiler.embeddable)
     implementation(libs.staxmate)
     implementation(libs.gson)
     implementation(libs.sonar.analyzer.commons.recognizers)
 
-    implementation(project(":sonar-kotlin-api"))
-
     testRuntimeOnly(testLibs.junit.engine)
     testImplementation(libs.slf4j.api)
     testImplementation(testLibs.junit.api)
@@ -26,6 +23,4 @@ dependencies {
     testImplementation(testLibs.sonar.analyzer.test.commons)
     testImplementation(testLibs.sonar.plugin.api.impl)
     testImplementation(testLibs.sonar.plugin.api.test.fixtures)
-
-    testImplementation(project(":sonar-kotlin-test-api"))
 }

sonar-kotlin-surefire/src/main/java/org/sonarsource/kotlin/surefire/KotlinSurefireParser.java

@@ -34,7 +34,6 @@
 import org.sonar.api.batch.sensor.SensorContext;
 import org.sonar.api.measures.CoreMetrics;
 import org.sonar.api.measures.Metric;
-import org.sonarsource.kotlin.api.frontend.ParseException;
 import org.sonarsource.kotlin.surefire.data.UnitTestClassReport;
 import org.sonarsource.kotlin.surefire.data.UnitTestIndex;
 
@@ -96,7 +95,7 @@ private static void parseFiles(List<File> reports, UnitTestIndex index) {
       try {
         parser.parse(report);
       } catch (XMLStreamException e) {
-        throw new ParseException("Fail to parse the Surefire report: " + report, null, e);
+        throw new IllegalStateException("Fail to parse the Surefire report: " + report, e);
       }
     }
   }

sonar-kotlin-surefire/src/test/java/org/sonarsource/kotlin/surefire/KotlinSurefireParserTest.java

@@ -25,6 +25,8 @@
 import java.util.Optional;
 import java.util.stream.Collectors;
 import java.util.stream.Stream;
+
+import com.ctc.wstx.exc.WstxEOFException;
 import kotlin.jvm.JvmField;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
@@ -39,6 +41,7 @@
 import org.sonar.api.testfixtures.log.LogTesterJUnit5;
 
 import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
 import static org.mockito.ArgumentMatchers.anyString;
 import static org.mockito.Mockito.doAnswer;
 import static org.mockito.Mockito.mock;
@@ -187,6 +190,21 @@ void shouldNotCountNegativeTests() {
     assertThat(context.measure(":java.Foo", CoreMetrics.TEST_EXECUTION_TIME).value()).isEqualTo(659);
   }
 
+  @Test
+  void shouldThrowWhenUnparsable() {
+    SensorContextTester context = mockContext();
+
+    var reportPath = "src/test/resources/org/sonarsource/kotlin/surefire/api/SurefireParserTest/unparsable/TEST-FooTest.xml"
+      .replace('/', File.separatorChar);
+    var dirs = getDirs("unparsable");
+    assertThatThrownBy(() -> parser.collect(context, dirs, true))
+      .isInstanceOf(IllegalStateException.class)
+      .hasMessage("Fail to parse the Surefire report: " + reportPath)
+      .hasRootCauseInstanceOf(WstxEOFException.class)
+      .hasRootCauseMessage("Unexpected EOF in prolog" + System.lineSeparator() +
+        " at [row,col {unknown-source}]: [1,0]");
+  }
+
   private List<File> getDirs(String... directoryNames) {
     return Stream.of(directoryNames)
       .map(directoryName -> new File("src/test/resources/org/sonarsource/kotlin/surefire/api/SurefireParserTest/" + directoryName))