SONARKT-550 Upgrade Kotlin compiler to 2.1.20

Co-authored-by: Antonio Aversa <[email protected]>

Author: Godin

gradle.properties

@@ -2,5 +2,5 @@ group=org.sonarsource.kotlin
 version=3.1.0-SNAPSHOT
 description=Code Analyzer for Kotlin
 projectTitle=Kotlin
-kotlinVersion=2.1.10
+kotlinVersion=2.1.20
 org.gradle.jvmargs=-Xmx4096M

gradle/verification-metadata.xml

@@ -20,9 +20,6 @@
 "kotlin-corda-project:sources/kotlin/corda/core/src/main/kotlin/net/corda/core/internal/InternalUtils.kt": [
 335
 ],
-"kotlin-corda-project:sources/kotlin/corda/core/src/main/kotlin/net/corda/core/messaging/CordaRPCOps.kt": [
-48
-],
 "kotlin-corda-project:sources/kotlin/corda/core/src/main/kotlin/net/corda/core/utilities/ProgressTracker.kt": [
 52
 ],

its/ruling/src/test/resources/expected/kotlin/corda/kotlin-S1874.json

@@ -607,6 +607,9 @@
 34,
 35
 ],
+"kotlin-kotlin-project:sources/kotlin/kotlin/idea/idea-analysis/src/org/jetbrains/kotlin/idea/references/KotlinReferenceContributor.kt": [
+21
+],
 "kotlin-kotlin-project:sources/kotlin/kotlin/idea/idea-analysis/src/org/jetbrains/kotlin/idea/search/declarationsSearch/declarationSearchUtil.kt": [
 28
 ],

its/ruling/src/test/resources/expected/kotlin/kotlin/kotlin-S1128.json

@@ -347,9 +347,6 @@
 "kotlin-kotlin-project:sources/kotlin/kotlin/libraries/examples/kotlin-jsr223-local-example/src/test/kotlin/org/jetbrains/kotlin/script/jsr223/KotlinJsr223ScriptEngineIT.kt": [
 137
 ],
-"kotlin-kotlin-project:sources/kotlin/kotlin/libraries/kotlin.test/common/src/main/kotlin/kotlin/test/Assertions.kt": [
-68
-],
 "kotlin-kotlin-project:sources/kotlin/kotlin/libraries/stdlib/common/src/generated/_Arrays.kt": [
 1250,
 1780

its/ruling/src/test/resources/expected/kotlin/kotlin/kotlin-S6619.json

@@ -69,3 +69,42 @@ typealias DeprecatedString = String
 
 @Deprecated("")
 private operator fun DeprecatedString.minus(s: String) = this + s // Noncompliant
+
+class DeprecatedParameterUsedInFollowingParameter(
+    @Deprecated("This is deprecated") val deprecatedParameter: String, // Compliant: not used, but declared
+    val anotherParameterUsingDeprecatedOne: Int = deprecatedParameter.length, // Compliant: what is deprecated is the generated property, not the parameter itself
+) {
+    val x = deprecatedParameter.length // Noncompliant
+
+    init {
+        println(deprecatedParameter.length) // Noncompliant
+    }
+}
+
+// region top-level non compliant scenario
+
+@Deprecated("This function is deprecated, use newFunction instead", ReplaceWith("deprecatedCodeUsed_newFunction()"))
+fun deprecatedCodeUsed_topLevel() {
+    println("This is the old function.")
+}
+
+fun deprecatedCodeUsed_newFunction() {
+    println("This is the new function.")
+}
+
+var deprecatedCodeUsed_var = deprecatedCodeUsed_topLevel() // Noncompliant
+
+// endregion
+
+fun nestedFunctions() {
+    @Deprecated("This function is deprecated, use newFunction instead", ReplaceWith("newFunction()"))
+    fun oldFunction() {
+        println("This is the old function.")
+    }
+
+    fun newFunction() {
+        println("This is the new function.")
+    }
+
+    oldFunction() // FN
+}

kotlin-checks-test-sources/src/main/kotlin/checks/DeprecatedCodeUsedCheckSample.kt

@@ -92,6 +92,11 @@ import operators.remAssign // FN
 import operators.ResourceLoader
 import operators.provideDelegate // Compliant
 
+import otherpackage.ClassUsedViaConstructorReference1
+import otherpackage.ClassUsedViaConstructorReference2
+import otherpackage.ClassUsedViaConstructorReference3
+import otherpackage.functionTakingAny
+
 
 class MyUI {
     fun <T> bindResource(id: ResourceID<T>): ResourceLoader<T> {
@@ -183,6 +188,12 @@ class UnnecessaryImportsCheckSample {
     fun bar() {
 
     }
+
+    class ConstructorReference(val value: Any = ::ClassUsedViaConstructorReference1) {
+        fun constructorReference(value: Any = ::ClassUsedViaConstructorReference2) {
+            functionTakingAny(value = ::ClassUsedViaConstructorReference3)
+        }
+    }
 }
 
 class ChildClass1A: java.util.Date()
@@ -200,3 +211,4 @@ inline fun <T> remember(calculation: () -> T): T = TODO()
 private fun state() = object : State<String> {
     override val value = "XY"
 }
+

kotlin-checks-test-sources/src/main/kotlin/checks/UnnecessaryImportsCheckSample.kt

@@ -82,6 +82,11 @@ import operators.divAssign // FN
 import operators.remAssign // FN
 import operators.provideDelegate // FN due to missing binding context
 
+import otherpackage.ClassUsedViaConstructorReference1
+import otherpackage.ClassUsedViaConstructorReference2
+import otherpackage.ClassUsedViaConstructorReference3
+import otherpackage.functionTakingAny
+
 class SomeClassWithDelegateNoSemantics(var delegate: OperatorsContainer) {
     val someProperty: String by delegate
 
@@ -154,8 +159,15 @@ class UnnecessaryImportsCheckSampleNoSemantics {
     fun bar() {
 
     }
+
+    class ConstructorReference(val value: Any = ::ClassUsedViaConstructorReference1) {
+        fun constructorReference(value: Any = ::ClassUsedViaConstructorReference2) {
+            functionTakingAny(value = ::ClassUsedViaConstructorReference3)
+        }
+    }
 }
 
 class ChildClass1B: java.util.Date()
 class ChildClass2B: Timer()
 class ClassInSameFileB
+

kotlin-checks-test-sources/src/main/kotlin/checks/UnnecessaryImportsCheckSampleNoSemantics.kt

@@ -45,6 +45,11 @@ import java.beans.*
 import kotlin.test.*
 import kotlin.* // Noncompliant {{Remove this redundant import.}}
 
+import otherpackage.ClassUsedViaConstructorReference1
+import otherpackage.ClassUsedViaConstructorReference2
+import otherpackage.ClassUsedViaConstructorReference3
+import otherpackage.functionTakingAny
+
 class UnnecessaryImportsCheckSamplePartialSemantics {
     fun foo() {
         StringBuilder()
@@ -93,4 +98,10 @@ class UnnecessaryImportsCheckSamplePartialSemantics {
     fun bar() {
 
     }
+
+    class ConstructorReference(val value: Any = ::ClassUsedViaConstructorReference1) {
+        fun constructorReference(value: Any = ::ClassUsedViaConstructorReference2) {
+            functionTakingAny(value = ::ClassUsedViaConstructorReference3)
+        }
+    }
 }

kotlin-checks-test-sources/src/main/kotlin/checks/UnnecessaryImportsCheckSamplePartialSemantics.kt

@@ -1,13 +1,10 @@
 package checks
 
-import kotlinx.coroutines.CoroutineScope
-import java.io.IOException
-import java.net.HttpURLConnection
 import java.util.Arrays
 import java.util.WeakHashMap
 import java.util.concurrent.locks.ReentrantReadWriteLock
 import kotlin.concurrent.read
-import kotlin.coroutines.CoroutineContext
+import kotlin.test.asserter
 
 class UselessNullCheckCheckSample {
 
@@ -138,3 +135,15 @@ private class FooBar(
 private fun <T> testParametrised(list: List<T>): Int? {
     return list.first()?.hashCode()
 }
+
+class NullableGeneric {
+    fun <T : Any> assertNotNull(actual: T?, message: String? = null): T {
+        contract { returns() implies (actual != null) } // Compliant: actual is nullable
+        asserter.assertNotNull(message, actual)
+        return actual!!
+    }
+
+    fun returns(): NullableGeneric { throw NotImplementedError() }
+    infix fun contract(block: () -> Unit) { }
+    infix fun <T> T.implies(value: Boolean) { }
+}