PLUGINAPI-134 Remove deprecated Issue Workflow transitions and statuses (#233)

Author: antoine-vinot-sonarsource

CHANGELOG.md

@@ -1,5 +1,12 @@
 # Changelog
 
+## 12.0
+* Remove `org.sonar.api.issue.DefaultTransitions.SET_AS_IN_REVIEW`.
+* Remove `org.sonar.api.issue.DefaultTransitions.OPEN_AS_VULNERABILITY`.
+* Remove `org.sonar.api.issue.Issue.STATUS_IN_REVIEW`.
+* Remove `org.sonar.api.issue.Issue.attribute(String key)`.
+* Remove `org.sonar.api.issue.Issue.attributes()`.
+
 ## 11.4
 * Deprecate `org.sonar.api.issue.DefaultTransitions`
 * Deprecate `org.sonar.api.web.UserRole`

gradle.properties

@@ -1,4 +1,4 @@
 group=org.sonarsource.api.plugin
-version=11.5-SNAPSHOT
+version=12.0-SNAPSHOT
 description=Plugin API for SonarQube, SonarCloud and SonarLint
 org.gradle.jvmargs=-Xmx2048m

plugin-api/src/main/java/org/sonar/api/issue/DefaultTransitions.java

@@ -21,9 +21,6 @@
 
 import java.util.List;
 
-import static java.util.Arrays.asList;
-import static java.util.Collections.unmodifiableList;
-
 /**
  * @since 3.6
  * @deprecated since 11.4 not used by any extension point anymore
@@ -59,19 +56,6 @@ public interface DefaultTransitions {
    */
   String ACCEPT = "accept";
 
-  /**
-   * @deprecated since 8.1, transition has no effect
-   */
-  @Deprecated
-  String SET_AS_IN_REVIEW = "setinreview";
-
-  /**
-   * @since 7.8
-   * @deprecated since 8.1, security hotspots can no longer be converted to vulnerabilities
-   */
-  @Deprecated
-  String OPEN_AS_VULNERABILITY = "openasvulnerability";
-
   /**
    * @since 7.8
    */
@@ -96,5 +80,5 @@ public interface DefaultTransitions {
    * @since 4.4
    */
   List<String> ALL = List.of(CONFIRM, UNCONFIRM, REOPEN, RESOLVE, FALSE_POSITIVE, WONT_FIX, CLOSE,
-    SET_AS_IN_REVIEW, RESOLVE_AS_REVIEWED, RESET_AS_TO_REVIEW, ACCEPT);
+    RESOLVE_AS_REVIEWED, RESET_AS_TO_REVIEW, ACCEPT);
 }

plugin-api/src/main/java/org/sonar/api/issue/Issue.java

@@ -121,12 +121,6 @@ public interface Issue extends Serializable {
 
   String STATUS_TO_REVIEW = "TO_REVIEW";
 
-  /**
-   * @deprecated since 8.1, status has been mapped as `TO_REVIEW`
-   */
-  @Deprecated(since = "8.1")
-  String STATUS_IN_REVIEW = "IN_REVIEW";
-
   String STATUS_REVIEWED = "REVIEWED";
 
   /**
@@ -215,23 +209,6 @@ public interface Issue extends Serializable {
   @CheckForNull
   Date closeDate();
 
-  /**
-   * @deprecated since 9.4, attribute was already not returning any element since 5.2
-   */
-  @Deprecated
-  @CheckForNull
-  String attribute(String key);
-
-  /**
-   * Empty on batch side since version 5.2. Attributes are moved to server's Compute Engine. No use-case for keeping them
-   * on batch side for now
-   */
-  /**
-   * @deprecated since 9.4, attribute was already not returning any element since 5.2
-   */
-  @Deprecated
-  Map<String, String> attributes();
-
   /**
    * Login of the SCM account that introduced this issue. Requires the
    * <a href="http://www.sonarsource.com/products/plugins/developer-tools/developer-cockpit/">Developer Cockpit Plugin</a> to be installed.