Skip to content

Commit 0030207

Browse files
SONARPY-1423 code fixes (#1547)
1 parent 22c0e14 commit 0030207

File tree

24 files changed

+68
-67
lines changed

24 files changed

+68
-67
lines changed

its/plugin/it-python-plugin-test/src/test/java/com/sonar/python/it/plugin/BanditReportTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,15 +28,15 @@
2828
import org.sonarqube.ws.Common;
2929
import org.sonarqube.ws.Issues;
3030

31-
import static com.sonar.python.it.plugin.Tests.issues;
31+
import static com.sonar.python.it.plugin.TestsUtils.issues;
3232
import static org.assertj.core.api.Assertions.assertThat;
3333

3434
class BanditReportTest {
3535

3636
private static final String PROJECT = "bandit_project";
3737

3838
@RegisterExtension
39-
public static final OrchestratorExtension ORCHESTRATOR = Tests.ORCHESTRATOR;
39+
public static final OrchestratorExtension ORCHESTRATOR = TestsUtils.ORCHESTRATOR;
4040

4141
@Test
4242
void import_report() {

its/plugin/it-python-plugin-test/src/test/java/com/sonar/python/it/plugin/CPDTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
import org.junit.jupiter.api.Test;
2828
import org.junit.jupiter.api.extension.RegisterExtension;
2929

30-
import static com.sonar.python.it.plugin.Tests.getMeasureAsDouble;
30+
import static com.sonar.python.it.plugin.TestsUtils.getMeasureAsDouble;
3131
import static org.assertj.core.api.Assertions.assertThat;
3232

3333
class CPDTest {
@@ -44,7 +44,7 @@ class CPDTest {
4444
private static final String DUPLICATED_LINES_DENSITY = "duplicated_lines_density";
4545

4646
@RegisterExtension
47-
public static final OrchestratorExtension ORCHESTRATOR = Tests.ORCHESTRATOR;
47+
public static final OrchestratorExtension ORCHESTRATOR = TestsUtils.ORCHESTRATOR;
4848

4949
@BeforeAll
5050
static void startServer() {

its/plugin/it-python-plugin-test/src/test/java/com/sonar/python/it/plugin/CoverageTest.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ class CoverageTest {
3636

3737
private static final String COVERAGE_PROJECT = "projects/coverage_project";
3838
@RegisterExtension
39-
public static final OrchestratorExtension ORCHESTRATOR = Tests.ORCHESTRATOR;
39+
public static final OrchestratorExtension ORCHESTRATOR = TestsUtils.ORCHESTRATOR;
4040

4141
private static final String PROJECT_KEY = "coverage_project";
4242
private static final String LINES_TO_COVER = "lines_to_cover";
@@ -72,7 +72,7 @@ private static void basicCoverageReports(String utReportPath) {
7272
.put(BRANCH_COVERAGE, 100)
7373
.build();
7474

75-
Tests.assertProjectMeasures(PROJECT_KEY, values);
75+
TestsUtils.assertProjectMeasures(PROJECT_KEY, values);
7676
assertThat(result.getLogs()).contains("Property 'sonar.python.coverage.reportPath' has been removed. Please use 'sonar.python.coverage.reportPaths' instead.");
7777
}
7878

@@ -88,7 +88,7 @@ void default_values() {
8888
.put(LINE_COVERAGE, 28)
8989
.put(BRANCH_COVERAGE, 0)
9090
.build();
91-
Tests.assertProjectMeasures(PROJECT_KEY, values);
91+
TestsUtils.assertProjectMeasures(PROJECT_KEY, values);
9292
}
9393

9494
@Test
@@ -104,7 +104,7 @@ void empty_property() {
104104
expected.put(COVERAGE, 0);
105105
expected.put(LINE_COVERAGE, 0);
106106
expected.put(BRANCH_COVERAGE, null);
107-
Tests.assertProjectMeasures(PROJECT_KEY, expected);
107+
TestsUtils.assertProjectMeasures(PROJECT_KEY, expected);
108108
}
109109

110110
@Test
@@ -122,7 +122,7 @@ void empty_coverage_report() {
122122
}
123123
}
124124
assertThat(nbLog).isEqualTo(1);
125-
assertThat(Tests.getMeasureAsDouble(PROJECT_KEY, COVERAGE)).isZero();
125+
assertThat(TestsUtils.getMeasureAsDouble(PROJECT_KEY, COVERAGE)).isZero();
126126
}
127127

128128
}

its/plugin/it-python-plugin-test/src/test/java/com/sonar/python/it/plugin/CustomRulesTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,14 +29,14 @@
2929
import org.sonarqube.ws.Issues;
3030
import org.sonarqube.ws.client.issues.SearchRequest;
3131

32-
import static com.sonar.python.it.plugin.Tests.newWsClient;
32+
import static com.sonar.python.it.plugin.TestsUtils.newWsClient;
3333
import static java.util.Collections.singletonList;
3434
import static org.assertj.core.api.Assertions.assertThat;
3535

3636
class CustomRulesTest {
3737

3838
@RegisterExtension
39-
public static final OrchestratorExtension orchestrator = Tests.ORCHESTRATOR;
39+
public static final OrchestratorExtension orchestrator = TestsUtils.ORCHESTRATOR;
4040

4141
private static final String PROJECT_KEY = "custom-rules";
4242
private static final String PROJECT_NAME = "Custom Rules";

its/plugin/it-python-plugin-test/src/test/java/com/sonar/python/it/plugin/Flake8ReportTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,15 +28,15 @@
2828
import org.sonarqube.ws.Common;
2929
import org.sonarqube.ws.Issues;
3030

31-
import static com.sonar.python.it.plugin.Tests.issues;
31+
import static com.sonar.python.it.plugin.TestsUtils.issues;
3232
import static org.assertj.core.api.Assertions.assertThat;
3333

3434
class Flake8ReportTest {
3535

3636
private static final String PROJECT = "flake8_project";
3737

3838
@RegisterExtension
39-
public static final OrchestratorExtension ORCHESTRATOR = Tests.ORCHESTRATOR;
39+
public static final OrchestratorExtension ORCHESTRATOR = TestsUtils.ORCHESTRATOR;
4040

4141
@Test
4242
void import_report() {

its/plugin/it-python-plugin-test/src/test/java/com/sonar/python/it/plugin/IPythonTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ class IPythonTest {
6363
@BeforeAll
6464
static void prepare() throws Exception {
6565
StandaloneGlobalConfiguration sonarLintConfig = StandaloneGlobalConfiguration.builder()
66-
.addPlugin(Tests.PLUGIN_LOCATION.getFile().toPath())
66+
.addPlugin(TestsUtils.PLUGIN_LOCATION.getFile().toPath())
6767
.setSonarLintUserHome(TEMP)
6868
.addEnabledLanguage(Language.IPYTHON)
6969
.setLogOutput((formattedMessage, level) -> {

its/plugin/it-python-plugin-test/src/test/java/com/sonar/python/it/plugin/MetricsTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,9 @@
2929
import org.junit.jupiter.api.extension.RegisterExtension;
3030
import org.sonarqube.ws.Measures.Measure;
3131

32-
import static com.sonar.python.it.plugin.Tests.getMeasure;
33-
import static com.sonar.python.it.plugin.Tests.getMeasureAsDouble;
34-
import static com.sonar.python.it.plugin.Tests.getMeasureAsInt;
32+
import static com.sonar.python.it.plugin.TestsUtils.getMeasure;
33+
import static com.sonar.python.it.plugin.TestsUtils.getMeasureAsDouble;
34+
import static com.sonar.python.it.plugin.TestsUtils.getMeasureAsInt;
3535
import static org.assertj.core.api.Assertions.assertThat;
3636

3737
class MetricsTest {
@@ -65,7 +65,7 @@ class MetricsTest {
6565
private static final Offset<Double> OFFSET = Offset.offset(0.01d);
6666

6767
@RegisterExtension
68-
public static final OrchestratorExtension orchestrator = Tests.ORCHESTRATOR;
68+
public static final OrchestratorExtension orchestrator = TestsUtils.ORCHESTRATOR;
6969

7070
private static BuildResult buildResult;
7171

its/plugin/it-python-plugin-test/src/test/java/com/sonar/python/it/plugin/MypyReportTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,15 +28,15 @@
2828
import org.sonarqube.ws.Common;
2929
import org.sonarqube.ws.Issues;
3030

31-
import static com.sonar.python.it.plugin.Tests.issues;
31+
import static com.sonar.python.it.plugin.TestsUtils.issues;
3232
import static org.assertj.core.api.Assertions.assertThat;
3333

3434
class MypyReportTest {
3535

3636
private static final String PROJECT = "mypy_project";
3737

3838
@RegisterExtension
39-
public static final OrchestratorExtension ORCHESTRATOR = Tests.ORCHESTRATOR;
39+
public static final OrchestratorExtension ORCHESTRATOR = TestsUtils.ORCHESTRATOR;
4040

4141
@Test
4242
void import_report() {

its/plugin/it-python-plugin-test/src/test/java/com/sonar/python/it/plugin/NoSonarTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
import org.junit.jupiter.api.extension.RegisterExtension;
2929
import org.sonarqube.ws.Issues;
3030

31-
import static com.sonar.python.it.plugin.Tests.issues;
31+
import static com.sonar.python.it.plugin.TestsUtils.issues;
3232
import static org.assertj.core.api.Assertions.assertThat;
3333

3434
class NoSonarTest {
@@ -37,7 +37,7 @@ class NoSonarTest {
3737
private static final String PROFILE_NAME = "nosonar";
3838

3939
@RegisterExtension
40-
public static final OrchestratorExtension ORCHESTRATOR = Tests.ORCHESTRATOR;
40+
public static final OrchestratorExtension ORCHESTRATOR = TestsUtils.ORCHESTRATOR;
4141

4242
@BeforeAll
4343
static void startServer() {

its/plugin/it-python-plugin-test/src/test/java/com/sonar/python/it/plugin/PylintReportTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
import org.junit.jupiter.api.Test;
2727
import org.junit.jupiter.api.extension.RegisterExtension;
2828

29-
import static com.sonar.python.it.plugin.Tests.issues;
29+
import static com.sonar.python.it.plugin.TestsUtils.issues;
3030
import static org.assertj.core.api.Assertions.assertThat;
3131

3232
class PylintReportTest {
@@ -35,7 +35,7 @@ class PylintReportTest {
3535
private static final String LEGACY_PROPERTY = "sonar.python.pylint.reportPath";
3636

3737
@RegisterExtension
38-
public static final OrchestratorExtension ORCHESTRATOR = Tests.ORCHESTRATOR;
38+
public static final OrchestratorExtension ORCHESTRATOR = TestsUtils.ORCHESTRATOR;
3939

4040
@Test
4141
void import_report() {

0 commit comments

Comments
 (0)