Skip to content

Commit 1ec6b6b

Browse files
andreaguarinoguillaume-dequenne
authored andcommitted
Revert "SONARPY-975 Generate typeshed protobuf messages in cirrus-ci only when needed (#1074)"
This reverts commit 2e9b52d.
1 parent 989a8e4 commit 1ec6b6b

File tree

3 files changed

+6
-29
lines changed

3 files changed

+6
-29
lines changed

.cirrus.yml

Lines changed: 2 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -33,31 +33,7 @@ win_vm_definition: &WINDOWS_VM_DEFINITION
3333
type: n1-standard-8
3434
use_ssd: true
3535

36-
generate_typeshed_task:
37-
gke_container:
38-
dockerfile: .cirrus/python-env.Dockerfile
39-
builder_image_project: language-team
40-
builder_image_name: docker-builder-lt-v1
41-
cluster_name: cirrus-ci-lt-cluster
42-
zone: us-central1-a
43-
namespace: default
44-
cpu: 2
45-
memory: 2G
46-
skip: "!changesInclude('python-frontend/typeshed_serializer/**', 'python-frontend/src/protobuf/symbols.proto')"
47-
env:
48-
GITHUB_TOKEN: ENCRYPTED[!f458126aa9ed2ac526f220c5acb51dd9cc255726b34761a56fc78d4294c11089502a882888cef0ca7dd4085e72e611a5!]
49-
maven_cache:
50-
folder: ${CIRRUS_WORKING_DIR}/.m2/repository
51-
build_script:
52-
- git submodule update --init
53-
- source cirrus-env BUILD
54-
- cd python-frontend
55-
- mvn clean install -DgenerateTypeshed
56-
cleanup_before_cache_script: cleanup_maven_repository
57-
5836
build_task:
59-
depends_on:
60-
- generate_typeshed
6137
gke_container:
6238
dockerfile: .cirrus/python-env.Dockerfile
6339
builder_image_project: language-team
@@ -94,7 +70,7 @@ build_win_task:
9470
folder: ~/.m2/repository
9571
build_script:
9672
- git submodule update --init
97-
- mvn.cmd -s /c/buildTools-docker/settings-public.xml test
73+
- mvn.cmd -s /c/buildTools-docker/settings-public.xml test -DskipTypeshed=true
9874
cleanup_before_cache_script: cleanup_maven_repository
9975

10076
ws_scan_task:
@@ -113,7 +89,7 @@ ws_scan_task:
11389
whitesource_script:
11490
- source cirrus-env QA
11591
- source set_maven_build_version $BUILD_NUMBER
116-
- mvn clean install -DskipTests -Denforcer.skip=true -Dskip.its=true
92+
- mvn clean install -DskipTests -DskipTypeshed -Denforcer.skip=true -Dskip.its=true
11793
- source ws_scan.sh
11894
allow_failures: "true"
11995
always:

README.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,9 @@ In order for it to work properly it needs to have Python runtime and [Typeshed](
1919

2020
### Profiles
2121

22-
- `mvn clean install` : avoid running [typeshed_serializer](https://github.com/SonarSource/sonar-python/tree/master/python-frontend/typeshed_serializer) tests and build only Java maven modules
23-
- `mvn clean install -DgenerateTypeshed`: execute full build, run tests for [typeshed_serializer](https://github.com/SonarSource/sonar-python/tree/master/python-frontend/typeshed_serializer)
22+
- `mvn clean install` : execute full build, run tests for [typeshed_serializer](https://github.com/SonarSource/sonar-python/tree/master/python-frontend/typeshed_serializer)
23+
- `mvn clean install -DskipTypeshed`: avoid running [typeshed_serializer](https://github.com/SonarSource/sonar-python/tree/master/python-frontend/typeshed_serializer) tests and build only Java maven modules
24+
2425
## License
2526

2627
Copyright 2011-2022 SonarSource.

python-frontend/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@
130130
<activation>
131131
<property>
132132
<name>
133-
generateTypeshed
133+
!skipTypeshed
134134
</name>
135135
</property>
136136
</activation>

0 commit comments

Comments
 (0)