SONARPY-1782 Migrate NonCallableCalledCheck to the new type model

Author: guillaume-dequenne

its/ruling/src/test/resources/expected/python-S5756.json

@@ -0,0 +1,35 @@
+{
+"project:buildbot-0.8.6p1/buildbot/test/unit/test_revlinks.py": [
+81
+],
+"project:django-2.2.3/django/contrib/gis/geos/prototypes/io.py": [
+151,
+153,
+238,
+249,
+258,
+263,
+270,
+276,
+281,
+285
+],
+"project:django-2.2.3/django/db/transaction.py": [
+297
+],
+"project:django-2.2.3/django/test/utils.py": [
+789
+],
+"project:pecos/examples/qp2q/preprocessing/session_data_processing.py": [
+34
+],
+"project:pecos/examples/qp2q/preprocessing/sparse_data_processing.py": [
+40
+],
+"project:tensorflow/python/ops/control_flow_util_v2.py": [
+255
+],
+"project:tensorflow/python/training/tracking/util.py": [
+77
+]
+}

its/ruling/src/test/resources/expected_extended/calibre/python-S5756.json

@@ -1,5 +1,25 @@
 {
-'calibre:src/calibre/ebooks/rtf2xml/field_strings.py':[
-334,
+"calibre:src/calibre/ebooks/mobi/writer2/main.py": [
+452
 ],
+"calibre:src/calibre/ebooks/mobi/writer8/index.py": [
+228
+],
+"calibre:src/calibre/ebooks/mobi/writer8/main.py": [
+381,
+382,
+492
+],
+"calibre:src/calibre/ebooks/mobi/writer8/mobi.py": [
+323
+],
+"calibre:src/calibre/srv/tests/loop.py": [
+41,
+43,
+43,
+47
+],
+"calibre:src/calibre/utils/matcher.py": [
+354
+]
 }

its/ruling/src/test/resources/expected_extended/salt/python-S5756.json

@@ -0,0 +1,5 @@
+{
+"salt:salt/config/schemas/ssh.py": [
+65
+]
+}

python-checks/src/main/java/org/sonar/python/checks/NonCallableCalledCheck.java

@@ -21,17 +21,52 @@
 
 import javax.annotation.Nullable;
 import org.sonar.check.Rule;
+import org.sonar.plugins.python.api.LocationInFile;
+import org.sonar.plugins.python.api.PythonSubscriptionCheck;
+import org.sonar.plugins.python.api.tree.CallExpression;
+import org.sonar.plugins.python.api.tree.Expression;
+import org.sonar.plugins.python.api.tree.Tree;
 import org.sonar.plugins.python.api.types.InferredType;
+import org.sonar.python.types.InferredTypes;
+import org.sonar.python.types.v2.PythonType;
+import org.sonar.python.types.v2.TriBool;
+
+import static org.sonar.python.tree.TreeUtils.nameFromExpression;
+import static org.sonar.python.types.InferredTypes.typeClassLocation;
 
 @Rule(key = "S5756")
-public class NonCallableCalledCheck extends NonCallableCalled {
+public class NonCallableCalledCheck extends PythonSubscriptionCheck {
 
   @Override
-  public boolean isNonCallableType(InferredType type) {
-    return !type.canHaveMember("__call__");
+  public void initialize(Context context) {
+    context.registerSyntaxNodeConsumer(Tree.Kind.CALL_EXPR, ctx -> {
+      CallExpression callExpression = (CallExpression) ctx.syntaxNode();
+      Expression callee = callExpression.callee();
+      InferredType calleeType = callee.type();
+      PythonType typeV2 = callee.typeV2();
+      if (isNonCallableType(typeV2)) {
+        String name = nameFromExpression(callee);
+        PreciseIssue preciseIssue = ctx.addIssue(callee, message(calleeType, name));
+        LocationInFile location = typeClassLocation(calleeType);
+        if (location != null) {
+          preciseIssue.secondary(location, "Definition.");
+        }
+      }
+    });
+  }
+
+  protected static String addTypeName(InferredType type) {
+    String typeName = InferredTypes.typeName(type);
+    if (typeName != null) {
+      return " has type " + typeName + " and it";
+    }
+    return "";
+  }
+
+  public boolean isNonCallableType(PythonType type) {
+    return type.hasMember("__call__") == TriBool.FALSE;
   }
 
-  @Override
   public String message(InferredType calleeType, @Nullable String name) {
     if (name != null) {
       return String.format("Fix this call; \"%s\"%s is not callable.", name, addTypeName(calleeType));

python-checks/src/test/resources/checks/nonCallableCalled.py

@@ -22,32 +22,32 @@ def call_noncallable(p):
     list_var()  # Noncompliant
 
     tuple_var = ()
-    tuple_var()  # Noncompliant
+    tuple_var()  # FN
 
     dict_var = {}
-    dict_var()  # Noncompliant
+    dict_var()  # FN
 
     set_var = set()
-    set_var()  # Noncompliant
+    set_var()  # FN
 
     frozenset_var = frozenset()
-    frozenset_var() # Noncompliant
+    frozenset_var() # FN
 
     if p:
       x = 42
     else:
       x = 'str'
-    x() # Noncompliant {{Fix this call; "x" is not callable.}}
+    x() # FN: multiple assignment not handled
 
 def flow_sensitivity():
   my_var = "hello"
   my_var = 42
-  my_var() # Noncompliant
+  my_var() # FN: multiple assignment not handled
 
   my_other_var = func
   my_other_var() # OK
   my_other_var = 42
-  my_other_var() # Noncompliant
+  my_other_var() # FN: multiple assignment not handled
 
 def flow_sensitivity_nested_try_except():
   def func_with_try_except():
@@ -59,7 +59,7 @@ def func_with_try_except():
   def other_func():
     my_var = "hello"
     my_var = 42
-    my_var() # Noncompliant
+    my_var() # FN: multiple assignments
 
 def member_access():
   my_callable = MyCallable()
@@ -69,16 +69,16 @@ def member_access():
 def types_from_typeshed(foo):
   from math import acos
   from functools import wraps
-  acos(42)() # Noncompliant {{Fix this call; this expression has type float and it is not callable.}}
-# ^^^^^^^^
+  acos(42)() # FN: declared return type of Typeshed
   wraps(func)(foo) # OK, wraps returns a Callable
 
 def with_metaclass():
   class Factory: ...
   class Base(metaclass=Factory): ...
   class A(Base): ...
   a = A()
-  a() # OK
+  # TODO: resolve type hierarchy and metaclasses
+  a() # Noncompliant
 
 
 def decorators():