SONARPY-2122 Ensure function parameters have a definition location (#1958)

Author: ghislainpiot

python-frontend/src/main/java/org/sonar/python/semantic/v2/FunctionTypeBuilder.java

@@ -56,7 +56,7 @@ public class FunctionTypeBuilder implements TypeBuilder<FunctionType> {
   private static final String CLASS_METHOD_DECORATOR = "classmethod";
   private static final String STATIC_METHOD_DECORATOR = "staticmethod";
 
-  public FunctionTypeBuilder fromFunctionDef(FunctionDef functionDef) {
+  public FunctionTypeBuilder fromFunctionDef(FunctionDef functionDef, @Nullable String fileId) {
     this.name = functionDef.name().name();
     this.attributes = new ArrayList<>();
     this.parameters = new ArrayList<>();
@@ -65,7 +65,7 @@ public FunctionTypeBuilder fromFunctionDef(FunctionDef functionDef) {
     isInstanceMethod = isInstanceMethod(functionDef);
     ParameterList parameterList = functionDef.parameters();
     if (parameterList != null) {
-      createParameterNames(parameterList.all(), null);
+      createParameterNames(parameterList.all(), fileId);
     }
     return this;
   }

python-frontend/src/main/java/org/sonar/python/semantic/v2/types/TrivialTypeInferenceVisitor.java

@@ -271,7 +271,7 @@ public void visitFunctionDef(FunctionDef functionDef) {
 
   private FunctionType buildFunctionType(FunctionDef functionDef) {
     FunctionTypeBuilder functionTypeBuilder = new FunctionTypeBuilder()
-      .fromFunctionDef(functionDef)
+      .fromFunctionDef(functionDef, fileId)
       .withDefinitionLocation(locationInFile(functionDef.name(), fileId));
     ClassType owner = null;
     if (currentType() instanceof ClassType classType) {

python-frontend/src/test/java/org/sonar/python/types/v2/FunctionTypeTest.java

@@ -101,7 +101,7 @@ void arity() {
     assertThat(functionType.parameters().get(0).isVariadic()).isFalse();
     assertThat(functionType.parameters().get(0).isKeywordVariadic()).isFalse();
     assertThat(functionType.parameters().get(0).isPositionalVariadic()).isFalse();
-    assertThat(functionType.parameters().get(0).location()).isNull();
+    assertThat(functionType.parameters().get(0).location()).isEqualTo(new LocationInFile(fileId, 1, 7, 1, 17));
 
     functionType = functionType("def fn(**kwargs): pass");
     assertThat(functionType.parameters()).hasSize(1);
@@ -188,6 +188,15 @@ void owner() {
     assertThat(functionType.owner()).isNull();
   }
 
+  @Test
+  void location() {
+    FunctionType functionType = functionType("def fn(param: int, (a: str, b)): pass");
+    String fileId = SymbolUtils.pathOf(pythonFile).toString();
+    assertThat(functionType.definitionLocation()).contains(new LocationInFile(fileId, 1, 4, 1, 6));
+    assertThat(functionType.parameters().get(0).location()).isEqualTo(new LocationInFile(fileId, 1, 7, 1, 17));
+    assertThat(functionType.parameters().get(1).location()).isEqualTo(new LocationInFile(fileId, 1, 19, 1, 30));
+  }
+
   public static FunctionType functionType(String... code) {
     FileInput fileInput = parseWithoutSymbols(code);
     var symbolTable = new SymbolTableBuilderV2(fileInput)