Update rule metadata (#1202)

Author: nils-werner-sonarsource

python-checks/src/main/resources/org/sonar/l10n/py/rules/python/S1523.html

@@ -5,8 +5,8 @@
 </ul>
 <p>Some APIs enable the execution of dynamic code by providing it as strings at runtime. These APIs might be useful in some very specific
 meta-programming use-cases. However most of the time their use is frowned upon because they also increase the risk of maliciously <a
-href="https://www.owasp.org/index.php/Code_Injection">Injected Code</a>. Such attacks can either run on the server or in the client (example: XSS
-attack) and have a huge impact on an application’s security.</p>
+href="https://owasp.org/www-community/attacks/Code_Injection">Injected Code</a>. Such attacks can either run on the server or in the client (example:
+XSS attack) and have a huge impact on an application’s security.</p>
 <p>This rule marks for review each occurrence of such dynamic code execution. This rule does not detect code injections. It only highlights the use of
 APIs which should be used sparingly and very carefully.</p>
 <h2>Ask Yourself Whether</h2>
@@ -45,7 +45,7 @@ <h2>Sensitive Code Example</h2>
 <h2>See</h2>
 <ul>
   <li> <a href="https://owasp.org/Top10/A03_2021-Injection/">OWASP Top 10 2021 Category A3</a> - Injection </li>
-  <li> <a href="https://www.owasp.org/index.php/Top_10-2017_A1-Injection">OWASP Top 10 2017 Category A1</a> - Injection </li>
+  <li> <a href="https://owasp.org/www-project-top-ten/2017/A1_2017-Injection">OWASP Top 10 2017 Category A1</a> - Injection </li>
   <li> <a href="https://cwe.mitre.org/data/definitions/95">MITRE, CWE-95</a> - Improper Neutralization of Directives in Dynamically Evaluated Code
   ('Eval Injection') </li>
 </ul>

python-checks/src/main/resources/org/sonar/l10n/py/rules/python/S1523.json

@@ -30,6 +30,10 @@
     ],
     "PCI DSS 4.0": [
       "6.2.4"
+    ],
+    "ASVS 4.0": [
+      "5.2.4",
+      "5.5.4"
     ]
   },
   "quickfix": "unknown"

python-checks/src/main/resources/org/sonar/l10n/py/rules/python/S1607.html

@@ -1,8 +1,8 @@
 <p>When a test fails due, for example, to infrastructure issues, you might want to ignore it temporarily. But without some kind of notation about why
-    the test is being ignored, it may never be reactivated. Such tests are difficult to address without comprehensive knowledge of the project, and end up
-    polluting their projects.</p>
+the test is being ignored, it may never be reactivated. Such tests are difficult to address without comprehensive knowledge of the project, and end up
+polluting their projects.</p>
 <p>This rule raises an issue for each skipped test with "<code>unittest.skip</code>" or "<code>pytest.mark.skip</code>" without providing a reason
-    argument.</p>
+argument.</p>
 <h2>Noncompliant Code Example</h2>
 <pre>
 import unittest
@@ -19,6 +19,6 @@ <h2>Compliant Solution</h2>
 </pre>
 <h2>See</h2>
 <p><a href="https://docs.python.org/3/library/unittest.html#skipping-tests-and-expected-failures">Unittest documentation - skipping tests and expected
-    failures</a></p>
+failures</a></p>
 <p><a href="https://docs.pytest.org/en/latest/how-to/skipping.html#skipping-test-functions">Pytest documentation - skipping test functions</a></p>
 

python-checks/src/main/resources/org/sonar/l10n/py/rules/python/S1721.html

@@ -15,4 +15,6 @@ <h2>Compliant Solution</h2>
     print "x is now %d" % (x)
     x += 1
 </pre>
+<h2>Deprecated</h2>
+<p>This rule is deprecated; use {rule:python:S5905} instead.</p>
 

python-checks/src/main/resources/org/sonar/l10n/py/rules/python/S1721.json

@@ -1,7 +1,7 @@
 {
   "title": "Parentheses should not be used after certain keywords",
   "type": "CODE_SMELL",
-  "status": "ready",
+  "status": "deprecated",
   "remediation": {
     "func": "Constant\/Issue",
     "constantCost": "1 min"

python-checks/src/main/resources/org/sonar/l10n/py/rules/python/S1854.html

@@ -5,7 +5,8 @@ <h2>Noncompliant Code Example</h2>
 <pre>
 def func(a, b, compute):
     i = a + b  # Noncompliant; calculation result not used before value is overwritten
-    i = compute()  # Noncompliant; the value is not used before leaving the function
+    i = compute()
+    return i
 </pre>
 <h2>Compliant Solution</h2>
 <pre>

python-checks/src/main/resources/org/sonar/l10n/py/rules/python/S2053.html

@@ -38,8 +38,8 @@ <h2>Compliant Solution</h2>
 <h2>See</h2>
 <ul>
   <li> <a href="https://owasp.org/Top10/A02_2021-Cryptographic_Failures/">OWASP Top 10 2021 Category A2</a> - Cryptographic Failures </li>
-  <li> <a href="https://www.owasp.org/index.php/Top_10-2017_A3-Sensitive_Data_Exposure">OWASP Top 10 2017 Category A3</a> - Sensitive Data Exposure
-  </li>
+  <li> <a href="https://www.owasp.org/www-project-top-ten/2017/A3_2017-Sensitive_Data_Exposure">OWASP Top 10 2017 Category A3</a> - Sensitive Data
+  Exposure </li>
   <li> <a href="https://cwe.mitre.org/data/definitions/759">MITRE, CWE-759</a> - Use of a One-Way Hash without a Salt </li>
   <li> <a href="https://cwe.mitre.org/data/definitions/760">MITRE, CWE-760</a> - Use of a One-Way Hash with a Predictable Salt </li>
   <li> <a href="https://www.sans.org/top25-software-errors/#cat3">SANS Top 25</a> - Porous Defenses </li>

python-checks/src/main/resources/org/sonar/l10n/py/rules/python/S2068.html

@@ -41,7 +41,8 @@ <h2>See</h2>
 <ul>
   <li> <a href="https://owasp.org/Top10/A07_2021-Identification_and_Authentication_Failures/">OWASP Top 10 2021 Category A7</a> - Identification and
   Authentication Failures </li>
-  <li> <a href="https://www.owasp.org/index.php/Top_10-2017_A2-Broken_Authentication">OWASP Top 10 2017 Category A2</a> - Broken Authentication </li>
+  <li> <a href="https://owasp.org/www-project-top-ten/2017/A2_2017-Broken_Authentication">OWASP Top 10 2017 Category A2</a> - Broken Authentication
+  </li>
   <li> <a href="https://cwe.mitre.org/data/definitions/798">MITRE, CWE-798</a> - Use of Hard-coded Credentials </li>
   <li> <a href="https://cwe.mitre.org/data/definitions/259">MITRE, CWE-259</a> - Use of Hard-coded Password </li>
   <li> <a href="https://www.sans.org/top25-software-errors/#cat3">SANS Top 25</a> - Porous Defenses </li>

python-checks/src/main/resources/org/sonar/l10n/py/rules/python/S2068.json

@@ -31,6 +31,11 @@
     ],
     "PCI DSS 4.0": [
       "6.2.4"
+    ],
+    "ASVS 4.0": [
+      "2.10.4",
+      "3.5.2",
+      "6.4.1"
     ]
   }
 }

python-checks/src/main/resources/org/sonar/l10n/py/rules/python/S2077.html

@@ -10,8 +10,8 @@ <h2>Ask Yourself Whether</h2>
 <p>There is a risk if you answered yes to any of those questions.</p>
 <h2>Recommended Secure Coding Practices</h2>
 <ul>
-  <li> Use <a href="https://www.owasp.org/index.php/Query_Parameterization_Cheat_Sheet">parameterized queries, prepared statements, or stored
-  procedures</a> and bind variables to SQL query parameters. </li>
+  <li> Use <a href="https://cheatsheetseries.owasp.org/cheatsheets/Query_Parameterization_Cheat_Sheet.html">parameterized queries, prepared
+  statements, or stored procedures</a> and bind variables to SQL query parameters. </li>
   <li> Consider using ORM frameworks if there is a need to have an abstract layer to access data. </li>
 </ul>
 <h2>Sensitive Code Example</h2>
@@ -58,12 +58,10 @@ <h2>Compliant Solution</h2>
 <h2>See</h2>
 <ul>
   <li> <a href="https://owasp.org/Top10/A03_2021-Injection/">OWASP Top 10 2021 Category A3</a> - Injection </li>
-  <li> <a href="https://www.owasp.org/index.php/Top_10-2017_A1-Injection">OWASP Top 10 2017 Category A1</a> - Injection </li>
+  <li> <a href="https://owasp.org/www-project-top-ten/2017/A1_2017-Injection">OWASP Top 10 2017 Category A1</a> - Injection </li>
+  <li> <a href="https://cwe.mitre.org/data/definitions/20">MITRE, CWE-20</a> - Improper Input Validation </li>
   <li> <a href="https://cwe.mitre.org/data/definitions/89">MITRE, CWE-89</a> - Improper Neutralization of Special Elements used in an SQL Command
   </li>
-  <li> <a href="https://cwe.mitre.org/data/definitions/564">MITRE, CWE-564</a> - SQL Injection: Hibernate </li>
-  <li> <a href="https://cwe.mitre.org/data/definitions/20">MITRE, CWE-20</a> - Improper Input Validation </li>
-  <li> <a href="https://cwe.mitre.org/data/definitions/943">MITRE, CWE-943</a> - Improper Neutralization of Special Elements in Data Query Logic </li>
   <li> <a href="https://www.sans.org/top25-software-errors/#cat1">SANS Top 25</a> - Insecure Interaction Between Components </li>
   <li> Derived from FindSecBugs rules <a href="https://h3xstream.github.io/find-sec-bugs/bugs.htm#SQL_INJECTION_JPA">Potential SQL/JPQL Injection
   (JPA)</a>, <a href="https://h3xstream.github.io/find-sec-bugs/bugs.htm#SQL_INJECTION_JDO">Potential SQL/JDOQL Injection (JDO)</a>, <a