Curly braces should not be a quantifier in general (#981)

* Curly braces should not be a quantifier in general

* Adapt ITS expected results

Co-authored-by: Karim El Ouerghemmi <[email protected]>

Author: nils-werner-sonarsource

its/ruling/src/test/resources/expected/python-S5843.json

@@ -15,6 +15,9 @@
 'project:django-2.2.3/django/utils/translation/template.py':[
 29,
 ],
+'project:django-2.2.3/django/utils/translation/trans_real.py':[
+35,
+],
 'project:numpy-1.16.4/numpy/f2py/crackfortran.py':[
 874,
 878,

its/ruling/src/test/resources/expected/python-S5856.json

@@ -2,12 +2,6 @@
 'project:biopython/Bio/motifs/pfm.py':[
 338,
 ],
-'project:buildbot-slave-0.8.6p1/buildslave/runprocess.py':[
-300,
-],
-'project:django-2.2.3/django/utils/translation/trans_real.py':[
-36,
-],
 'project:mypy-0.782/test-data/stdlib-samples/3.2/glob.py':[
 76,
 77,
@@ -18,19 +12,10 @@
 'project:tensorflow/python/distribute/cluster_resolver/slurm_cluster_resolver.py':[
 75,
 ],
-'project:tensorflow/python/keras/callbacks.py':[
-1373,
-],
-'project:tensorflow/tools/docs/py_guide_parser.py':[
-65,
-],
 'project:tornado-2.3/demos/appengine/markdown.py':[
 826,
 ],
 'project:tornado-2.3/demos/blog/markdown.py':[
 826,
 ],
-'project:twisted-12.1.0/twisted/words/protocols/jabber/sasl.py':[
-84,
-],
 }

pom.xml

@@ -91,7 +91,7 @@
     <mockito.version>3.9.0</mockito.version>
     <sonar.version>8.9.0.43852</sonar.version>
     <sonar.orchestrator.version>3.35.1.2719</sonar.orchestrator.version>
-    <sonar-analyzer-commons.version>1.21.0.818</sonar-analyzer-commons.version>
+    <sonar-analyzer-commons.version>1.21.0.821</sonar-analyzer-commons.version>
     <sonarlint-core.version>6.0.0.32513</sonarlint-core.version>
     <sslr.version>1.23</sslr.version>
     <protobuf.version>3.17.3</protobuf.version>

python-checks/src/test/resources/checks/regex/invalidRegexCheck.py

@@ -5,10 +5,6 @@ def non_compliant(input):
     re.match(r'(', input)  # Noncompliant {{Fix the syntax error inside this regex.}}
     #           ^
     #           ^@-1< {{Expected ')', but found the end of the regex}}
-    re.match(r'x{1,2,3}|(', input)  # Noncompliant {{Fix the syntax errors inside this regex.}}
-    #               ^
-    #               ^@-1< {{Expected '}', but found ','}}
-    #                    ^@-2< {{Expected ')', but found the end of the regex}}
     re.match(r'$[a-z^', input)  # Noncompliant {{Fix the syntax error inside this regex.}}
     #                ^
     #                ^@-1< {{Expected ']', but found the end of the regex}}
@@ -22,19 +18,13 @@ def compliant(input):
 
 
 def unsupported_feature(input):
-    re.match(r'\p{Lower}', input)  # Noncompliant
+    # atomic group
     re.match(r'(?>x)', input)  # Noncompliant
+    # possessive quantifier
     re.match(r'x*+', input)  # Noncompliant
 
 
 def false_positives():
     re.compile(r"\s*([ACGT])\s*[[]*[|]*\s*([0-9.\s]+)\s*[]]*\s*")  # Noncompliant
-    # Noncompliant@+3
-    re.compile(r'''
-        ([A-Za-z]{1,8}(?:-[A-Za-z0-9]{1,8})*|\*)      # "en", "en-au", "x-y-z", "es-419", "*"
-        (?:\s*;\s*q=(0(?:\.\d{,3})?|1(?:\.0{,3})?))?  # Optional "q=1.00", "q=0.8"
-        (?:\s*,\s*|$)                                 # Multiple accepts per header.
-        ''', re.VERBOSE)
     re.compile(r'^\s+\[([\s*[0-9]*)\] ([a-zA-Z0-9_]*)')  # Noncompliant
     re.compile(r'([^,[\]]*)(\[([^\]]+)\])?$')  # Noncompliant
-    re.compile(r'{.*}')  # Noncompliant

python-checks/src/test/resources/checks/regex/stringReplaceCheck.py

@@ -2,13 +2,14 @@
 
 def non_compliant():
     input = "Bob is a Bird... Bob is a Plane... Bob is Superman!"
-    changed = re.sub(r"Bob is", "It's", input) # Noncompliant {{Replace this "re.sub()" call by a "str.replace()" function call.}}
+    changed = re.sub(r"Bob is", "It's", input)  # Noncompliant {{Replace this "re.sub()" call by a "str.replace()" function call.}}
     #         ^^^^^^   ^^^^^^< {{Expression without regular expression features.}}
-    changed = re.sub(r"\.\.\.", ";", input) # Noncompliant
-    changed = re.sub(r"\Q...\E", ";", input) # Noncompliant
-    changed = re.sub(r"\\", "It's", input) # Noncompliant
-    changed = re.sub(r"\.", "It's", input) # Noncompliant
-    changed = re.sub(r"!", "It's", input) # Noncompliant
+    changed = re.sub(r"\.\.\.", ";", input)  # Noncompliant
+    changed = re.sub(r"\Q...\E", ";", input)  # Noncompliant
+    changed = re.sub(r"\\", "It's", input)  # Noncompliant
+    changed = re.sub(r"\.", "It's", input)  # Noncompliant
+    changed = re.sub(r"!", "It's", input)  # Noncompliant
+    changed = re.sub(r"{", "It's", input)  # Noncompliant
 
 def compliant():
     input = "Bob is a Bird... Bob is a Plane... Bob is Superman!"
@@ -25,7 +26,6 @@ def compliant():
     changed = re.sub(r"()", "It's", input)
     changed = re.sub(r"[", "It's", input)
     changed = re.sub(r"[a-z]]", "It's", input)
-    changed = re.sub(r"{", "It's", input)
     changed = re.sub(r"x{3}", "It's", input)
     changed = re.sub(r"^", "It's", input)
     changed = re.sub(r"?", "It's", input)