SONARPY-2183 Fix FP on S5708 when the caught object has type 'type' (#2039)

Author: guillaume-dequenne

python-checks/src/main/java/org/sonar/python/checks/CaughtExceptionsCheck.java

@@ -108,7 +108,8 @@ private static boolean canBeOrExtendBaseException(Expression expression, Subscri
     PythonType pythonType = expression.typeV2();
     TriBool isBaseException = ctx.typeChecker().typeCheckBuilder().isInstanceOf("BaseException").check(pythonType);
     TriBool isTuple = ctx.typeChecker().typeCheckBuilder().isBuiltinWithName("tuple").check(pythonType);
-    return isBaseException != TriBool.FALSE || isTuple != TriBool.FALSE;
+    TriBool isType = ctx.typeChecker().typeCheckBuilder().isBuiltinWithName("type").check(pythonType);
+    return isBaseException != TriBool.FALSE || isTuple != TriBool.FALSE || isType == TriBool.TRUE;
   }
 
   private static boolean inheritsFromBaseException(@Nullable Symbol symbol) {

python-checks/src/test/resources/checks/caughtExceptions.py

@@ -86,3 +86,10 @@ def reassigned_exception():
         ...
     except my_exception:
         ...
+
+
+def except_type():
+    try:
+        raise smth
+    except type(smth) as e:
+        ...