SONARPY-2313 Fix FN on S6543 when a generic class is defined in another file

Author: guillaume-dequenne

python-checks/src/test/java/org/sonar/python/checks/GenericTypeWithoutArgumentCheckTest.java

@@ -19,6 +19,7 @@
  */
 package org.sonar.python.checks;
 
+import java.util.List;
 import org.junit.jupiter.api.Test;
 import org.sonar.python.checks.utils.PythonCheckVerifier;
 
@@ -28,4 +29,15 @@ class GenericTypeWithoutArgumentCheckTest {
   void test() {
     PythonCheckVerifier.verify("src/test/resources/checks/genericTypeWithoutArgument.py", new GenericTypeWithoutArgumentCheck());
   }
+
+  @Test
+  void test_cross_file() {
+    PythonCheckVerifier.verify(
+      List.of(
+        "src/test/resources/checks/genericTypeWithoutArgumentImported.py",
+        "src/test/resources/checks/genericTypeWithoutArgumentImporting.py"
+      ),
+      new GenericTypeWithoutArgumentCheck()
+    );
+  }
 }

python-checks/src/test/resources/checks/genericTypeWithoutArgument.py

@@ -118,3 +118,21 @@ def typing_tuple_param(param:typing.Tuple[str, int, int]):
     pass
 
 
+class MyGeneric[T](): ...
+
+def returning_type_param_generic() -> MyGeneric: # FN (type parameter syntax not supported in V1)
+    ...
+
+class MyGenericParent(typing.Generic): ...
+
+class MyChild(MyGenericParent[T]): ...
+def returning_my_child() -> MyChild: # FN
+    ...
+
+class MyChild2(MyGenericParent): ...
+def returning_my_child_2() -> MyChild2: # OK
+    ...
+
+class MyChild3(MyGenericParent[str]): ...
+def returning_my_child_3() -> MyChild2: # OK
+    ...

python-checks/src/test/resources/checks/genericTypeWithoutArgumentImported.py

@@ -0,0 +1,9 @@
+from typing import Generic
+class SomeGeneric(Generic[T]):
+  ...
+
+class SomeGenericWithTypeParam[T](): ...
+
+class MyImportedGenericTypeVarChild(SomeGeneric[T]): ...
+class MyImportedNonGenericChild(SomeGeneric): ...
+class MyImportedConcreteChild(SomeGeneric[str]): ...

python-checks/src/test/resources/checks/genericTypeWithoutArgumentImporting.py

@@ -0,0 +1,32 @@
+# mod.py
+from genericTypeWithoutArgumentImported import SomeGeneric, SomeGenericWithTypeParam, MyImportedGenericTypeVarChild, MyImportedNonGenericChild, MyImportedConcreteChild
+
+def local_generic():
+    from typing import Generic
+    class LocalGeneric(Generic[T]):
+      ...
+    def bar() -> LocalGeneric: # Noncompliant
+      ...
+
+def foo() -> SomeGeneric: # Noncompliant
+  ...
+
+def bar() -> SomeGenericWithTypeParam: # Noncompliant
+    ...
+
+def returning_imported_child() -> MyImportedGenericTypeVarChild: ... # Noncompliant
+def returning_imported_non_generic_child() -> MyImportedNonGenericChild: ... # OK
+# FP SONARPY-2356: MyImportedConcreteChild is not actually generic (specialized class)
+def returning_imported_concrete_child() -> MyImportedConcreteChild: ... # Noncompliant
+
+class MyChild(SomeGeneric[T]): ...
+def returning_my_child() -> MyChild: # FN
+    ...
+
+class MyNonGenericChild(SomeGeneric): ...
+def returning_my_non_generic_child() -> MyNonGenericChild: # OK
+    ...
+
+class MyConcreteChild(SomeGeneric[str]): ...
+def returning_my_concrete_chil3() -> MyConcreteChild: # OK
+    ...