Fix memory leak in StringFormatCorrectnessCheck (#779)

Author: andrea-guarino-sonarsource

python-checks/src/main/java/org/sonar/python/checks/StringFormatCorrectnessCheck.java

@@ -20,10 +20,8 @@
 package org.sonar.python.checks;
 
 import java.util.Arrays;
-import java.util.HashMap;
 import java.util.HashSet;
 import java.util.List;
-import java.util.Map;
 import java.util.Optional;
 import java.util.Set;
 import java.util.stream.Collectors;
@@ -55,8 +53,6 @@ public class StringFormatCorrectnessCheck extends AbstractStringFormatCheck {
     "debug", "info", "warning", "error", "critical"
   ));
 
-  private Map<Name, Boolean> singleAssignedLoggers = new HashMap<>();
-
   @Override
   public void initialize(Context context) {
     context.registerSyntaxNodeConsumer(Tree.Kind.MODULO, this::checkPrintfStyle);
@@ -72,7 +68,7 @@ private void checkCallExpression(SubscriptionContext ctx) {
     }
   }
 
-  private boolean isCallToLog(CallExpression callExpression) {
+  private static boolean isCallToLog(CallExpression callExpression) {
     Symbol symbol = callExpression.calleeSymbol();
 
     if (symbol != null && LOGGER_FULL_NAMES.contains(symbol.fullyQualifiedName())) {
@@ -82,7 +78,7 @@ private boolean isCallToLog(CallExpression callExpression) {
     return isQualifiedCallToLogger(callExpression);
   }
 
-  private boolean isQualifiedCallToLogger(CallExpression callExpression) {
+  private static boolean isQualifiedCallToLogger(CallExpression callExpression) {
     if (!callExpression.callee().is(Tree.Kind.QUALIFIED_EXPR)) {
       return false;
     }
@@ -97,22 +93,18 @@ private boolean isQualifiedCallToLogger(CallExpression callExpression) {
       return false;
     }
 
-    Name name = (Name) qualifier;
-
-    return singleAssignedLoggers.computeIfAbsent(name, key -> {
-      Expression singleAssignedValue = Expressions.singleAssignedValue(key);
-      if (singleAssignedValue == null || !singleAssignedValue.is(Tree.Kind.CALL_EXPR)) {
-        return false;
-      }
+    Expression singleAssignedValue = Expressions.singleAssignedValue((Name) qualifier);
+    if (singleAssignedValue == null || !singleAssignedValue.is(Tree.Kind.CALL_EXPR)) {
+      return false;
+    }
 
-      CallExpression call = (CallExpression) singleAssignedValue;
-      Symbol symbol = call.calleeSymbol();
-      if (symbol == null) {
-        return false;
-      }
+    CallExpression call = (CallExpression) singleAssignedValue;
+    Symbol symbol = call.calleeSymbol();
+    if (symbol == null) {
+      return false;
+    }
 
-      return "logging.getLogger".equals(symbol.fullyQualifiedName());
-    });
+    return "logging.getLogger".equals(symbol.fullyQualifiedName());
   }
 
   private static void checkLoggerLog(SubscriptionContext ctx, CallExpression callExpression) {