SONARPY-986 S5644 should not raise issues on "collections" symbols (#1085)

Author: guillaume-dequenne

python-checks/src/main/java/org/sonar/python/checks/ItemOperationsTypeCheck.java

@@ -57,7 +57,7 @@ public boolean isValidSubscription(Expression subscriptionObject, String require
     }
     if (subscriptionObject instanceof HasSymbol) {
       Symbol symbol = ((HasSymbol) subscriptionObject).symbol();
-      if (symbol == null || isTypingSymbol(symbol)) {
+      if (symbol == null || isTypingOrCollectionsSymbol(symbol)) {
         return true;
       }
       if (symbol.is(FUNCTION, CLASS)) {
@@ -81,10 +81,10 @@ public String message(@Nullable String name, String missingMethod) {
     return String.format("Fix this code; this expression does not have a \"%s\" method.", missingMethod);
   }
 
-  private static boolean isTypingSymbol(Symbol symbol) {
+  private static boolean isTypingOrCollectionsSymbol(Symbol symbol) {
     String fullyQualifiedName = symbol.fullyQualifiedName();
     // avoid FP for typing symbols like 'Awaitable[None]'
-    return fullyQualifiedName != null && fullyQualifiedName.startsWith("typing");
+    return fullyQualifiedName != null && (fullyQualifiedName.startsWith("typing") || fullyQualifiedName.startsWith("collections"));
   }
 
   private static boolean canHaveMethod(Symbol symbol, String requiredMethod, @Nullable String classRequiredMethod) {

python-checks/src/test/resources/checks/itemOperationsTypeCheck/itemOperations_getitem.py

@@ -165,6 +165,8 @@ def my_func() -> Awaitable[bool]: ... # OK
   def my_other_func(arg: Awaitable[bool]): ... # OK
   x: Awaitable[bool] # OK
   Awaitable[None]
+  from collections import Set
+  CustomSet = Set[str]
 
 def decorated_classes():
   import enum