Skip to content

Commit 816d009

Browse files
Remove unneeded ProjectLevelSymbolTable#from (#1823)
1 parent 35e72cc commit 816d009

File tree

2 files changed

+2
-12
lines changed

2 files changed

+2
-12
lines changed

python-frontend/src/main/java/org/sonar/plugins/python/api/PythonVisitorContext.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ public PythonVisitorContext(FileInput rootTree, PythonFile pythonFile, @Nullable
6262

6363
var symbolTable = new SymbolTableBuilderV2(rootTree)
6464
.build();
65-
var projectLevelTypeTable = new ProjectLevelTypeTable(ProjectLevelSymbolTable.from(projectLevelSymbolTable), new TypeShed(projectLevelSymbolTable));
65+
var projectLevelTypeTable = new ProjectLevelTypeTable(projectLevelSymbolTable, new TypeShed(projectLevelSymbolTable));
6666
new TypeInferenceV2(projectLevelTypeTable, pythonFile, symbolTable).inferTypes(rootTree);
6767
}
6868

@@ -74,7 +74,7 @@ public PythonVisitorContext(FileInput rootTree, PythonFile pythonFile, @Nullable
7474
new SymbolTableBuilder(packageName, pythonFile, projectLevelSymbolTable).visitFileInput(rootTree);
7575
var symbolTable = new SymbolTableBuilderV2(rootTree)
7676
.build();
77-
var projectLevelTypeTable = new ProjectLevelTypeTable(ProjectLevelSymbolTable.from(projectLevelSymbolTable), typeShed);
77+
var projectLevelTypeTable = new ProjectLevelTypeTable(projectLevelSymbolTable, typeShed);
7878
new TypeInferenceV2(projectLevelTypeTable, pythonFile, symbolTable).inferTypes(rootTree);
7979
}
8080

python-frontend/src/main/java/org/sonar/python/semantic/ProjectLevelSymbolTable.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -62,16 +62,6 @@ public static ProjectLevelSymbolTable from(Map<String, Set<Symbol>> globalSymbol
6262
return new ProjectLevelSymbolTable(globalSymbolsByModuleName);
6363
}
6464

65-
public static ProjectLevelSymbolTable from(ProjectLevelSymbolTable from) {
66-
var to = empty();
67-
to.globalDescriptorsByModuleName.putAll(from.globalDescriptorsByModuleName);
68-
Optional.ofNullable(from.globalDescriptorsByFQN)
69-
.ifPresent(v -> to.globalDescriptorsByFQN = new HashMap<>(v));
70-
to.djangoViewsFQN.addAll(from.djangoViewsFQN);
71-
to.importsByModule.putAll(from.importsByModule);
72-
return to;
73-
}
74-
7565
public ProjectLevelSymbolTable() {
7666
this.globalDescriptorsByModuleName = new HashMap<>();
7767
}

0 commit comments

Comments
 (0)