Fix bug when copying ambiguous aliased symbol (#703)

Author: andrea-guarino-sonarsource

python-frontend/src/main/java/org/sonar/python/semantic/Scope.java

@@ -149,7 +149,7 @@ private static Symbol copySymbol(String symbolName, Symbol symbol, Map<String, S
       return classSymbol;
     } else if (symbol.is(Symbol.Kind.AMBIGUOUS)) {
       Set<Symbol> alternativeSymbols = ((AmbiguousSymbol) symbol).alternatives().stream()
-        .map(s -> copySymbol(s.name(), s, globalSymbolsByFQN))
+        .map(s -> copySymbol(symbolName, s, globalSymbolsByFQN))
         .collect(Collectors.toSet());
       return AmbiguousSymbolImpl.create(alternativeSymbols);
     } else if (symbol.is(Symbol.Kind.OTHER)) {

python-frontend/src/test/java/org/sonar/python/semantic/AmbiguousSymbolTest.java

@@ -149,6 +149,19 @@ public void ambiguous_symbol_creation_different_fqn() {
     assertThat(ambiguousSymbol.alternatives()).containsExactlyInAnyOrder(foo, otherFoo);
   }
 
+  @Test
+  public void aliased_import() {
+    Symbol symbol = symbols(
+      "try:",
+      "  from gettext import gettext as _",
+      "except ImportError:",
+      "  def _(s): return s"
+    ).get("_");
+    assertThat(symbol.name()).isEqualTo("_");
+    assertThat(symbol.is(Symbol.Kind.AMBIGUOUS)).isTrue();
+    assertThat(((AmbiguousSymbol) symbol).alternatives()).extracting(Symbol::kind).containsExactlyInAnyOrder(Symbol.Kind.OTHER, Symbol.Kind.FUNCTION);
+  }
+
   @Test
   public void copy_without_usages() {
     SymbolImpl foo = new SymbolImpl("foo", "mod1.foo");