SONARPY-1462-hotfix Add quick fix for equality checks against np.nan. (#1578)

Author: Jeremi Do Dinh

python-checks/src/main/java/org/sonar/python/checks/NumpyIsNanCheck.java

@@ -36,9 +36,9 @@
 @Rule(key = "S6725")
 public class NumpyIsNanCheck extends PythonSubscriptionCheck {
 
-  private static final String MESSAGE = "Don't perform an equality check against \"numpy.nan\".";
-  private static final String QUICK_FIX_MESSAGE_EQUALITY = "Replace this equality check with numpy.isnan().";
-  private static final String QUICK_FIX_MESSAGE_INEQUALITY = "Replace this inequality check with !numpy.isnan().";
+  private static final String MESSAGE = "Don't perform an equality/inequality check against \"numpy.nan\".";
+  private static final String QUICK_FIX_MESSAGE_EQUALITY = "Replace this equality check with \"numpy.isnan()\".";
+  private static final String QUICK_FIX_MESSAGE_INEQUALITY = "Replace this inequality check with \"not numpy.isnan()\".";
 
   @Override
   public void initialize(Context context) {
@@ -83,7 +83,7 @@ private static String addPrefix(BinaryExpression be) {
     if ("==".equals(be.operator().value())) {
       return "";
     } else {
-      return "!";
+      return "not ";
     }
   }
 

python-checks/src/test/java/org/sonar/python/checks/NumpyIsNanCheckTest.java

@@ -26,8 +26,8 @@
 class NumpyIsNanCheckTest {
 
   NumpyIsNanCheck check = new NumpyIsNanCheck();
-  private static final String QUICK_FIX_MESSAGE_EQUALITY = "Replace this equality check with numpy.isnan().";
-  private static final String QUICK_FIX_MESSAGE_INEQUALITY = "Replace this inequality check with !numpy.isnan().";
+  private static final String QUICK_FIX_MESSAGE_EQUALITY = "Replace this equality check with \"numpy.isnan()\".";
+  private static final String QUICK_FIX_MESSAGE_INEQUALITY = "Replace this inequality check with \"not numpy.isnan()\".";
 
   @Test
   void test() {
@@ -66,7 +66,7 @@ void quickFixTestNotEqual() {
 
     final String compliant = "import numpy as np\n" +
       "def foo(x):\n" +
-      "    if !np.isnan(x): print(1)";
+      "    if not np.isnan(x): print(1)";
 
     performVerification(nonCompliant1, compliant, QUICK_FIX_MESSAGE_INEQUALITY);
     performVerification(nonCompliant2, compliant, QUICK_FIX_MESSAGE_INEQUALITY);

python-checks/src/test/resources/checks/numpyIsNan.py

@@ -1,6 +1,6 @@
 def foo1(x):
     import numpy as np
-    if x == np.nan: print(1)  # Noncompliant {{Don't perform an equality check against "numpy.nan".}}
+    if x == np.nan: print(1)  # Noncompliant {{Don't perform an equality/inequality check against "numpy.nan".}}
     #  ^^^^^^^^^^^
     if np.nan == x: print(1)  # Noncompliant
     if x != np.nan: print(1)  # Noncompliant