SONARPY-1794 Avoid inferring types for global variables (#1771)

* SONARPY-1794 Avoid inferring types for global variables

* Update ruling expectations

Author: guillaume-dequenne

its/ruling/src/test/resources/expected/python-S5756.json

@@ -203,5 +203,11 @@ def assigning_global(my_func):
     some_global_func = my_func
 
 def calling_global_func():
-    # FP
-    some_global_func() # Noncompliant
+    some_global_func() # OK
+
+
+some_nonlocal_var = 42
+
+def using_nonlocal_var():
+    nonlocal some_nonlocal_var
+    some_nonlocal_var()  # Noncompliant

python-checks/src/test/resources/checks/nonCallableCalled.py

@@ -347,8 +347,8 @@ public void visitAssignmentExpression(AssignmentExpression assignmentExpression)
 
     @Override
     public void visitGlobalStatement(GlobalStatement globalStatement) {
-      // FIXME: handle global statements
-
+      // Global statements are not binding usages, but we consider them as such for symbol creation
+      globalStatement.variables().forEach(name -> moduleScope.addBindingUsage(name, UsageV2.Kind.GLOBAL_DECLARATION, null));
       super.visitGlobalStatement(globalStatement);
     }
 

python-frontend/src/main/java/org/sonar/python/semantic/v2/SymbolTableBuilderV2.java

@@ -20,6 +20,7 @@
 package org.sonar.python.semantic.v2;
 
 import java.util.ArrayDeque;
+import java.util.ArrayList;
 import java.util.Collection;
 import java.util.Deque;
 import java.util.List;
@@ -278,20 +279,26 @@ public void visitQualifiedExpression(QualifiedExpression qualifiedExpression) {
 
   @Override
   public void visitName(Name name) {
-    var type = Optional.of(name)
-      .map(Name::symbolV2)
-      .map(SymbolV2::usages)
-      .stream()
-      .flatMap(Collection::stream)
-      .filter(UsageV2::isBindingUsage)
-      .map(UsageV2::tree)
-      .filter(Expression.class::isInstance)
-      .map(Expression.class::cast)
-      .map(Expression::typeV2)
-      .toList();
-
-    if (type.size() == 1) {
-      setTypeToName(name, type.get(0));
+    SymbolV2 symbolV2 = name.symbolV2();
+    if (symbolV2 == null) {
+      return;
+    }
+    List<PythonType> types = new ArrayList<>();
+    for (UsageV2 usage : symbolV2.usages()) {
+      if (usage.kind().equals(UsageV2.Kind.GLOBAL_DECLARATION)) {
+        // Don't infer type for global variables
+        return;
+      }
+      Optional.of(usage)
+        .filter(UsageV2::isBindingUsage)
+        .map(UsageV2::tree)
+        .filter(Expression.class::isInstance)
+        .map(Expression.class::cast)
+        .map(Expression::typeV2)
+        .ifPresent(types::add);
+    }
+    if (types.size() == 1) {
+      setTypeToName(name, types.get(0));
     }
   }