SONARPY-906 S5864: Fix FP when calling coroutines (#1067)

Author: andrea-guarino-sonarsource

python-checks/src/main/java/org/sonar/python/checks/ConfusingTypeCheckingCheck.java

@@ -63,7 +63,7 @@ private static class NonCallableCalledCheck extends NonCallableCalled {
 
     @Override
     public boolean isNonCallableType(InferredType type) {
-      return containsDeclaredType(type) && !type.declaresMember("__call__");
+      return containsDeclaredType(type) && !type.declaresMember("__call__") && !type.mustBeOrExtend("typing.Coroutine");
     }
 
     @Override

python-checks/src/test/resources/checks/confusingTypeChecking/nonCallableCalled.py

@@ -1,4 +1,5 @@
-from typing import Set, FrozenSet, Union
+from typing import Set, FrozenSet, Union, Coroutine
+import asyncio
 
 def empty_union(x: Union['A', 'B']):
   x()
@@ -29,3 +30,10 @@ def __call__(self, *args, **kwargs): ...
 def with_isinstance(x: Base):
   if isinstance(x, CallableBase):
     x()
+
+
+async def bar(func: Coroutine):
+  func() # it's technically possible to call a Coroutine, although it won't behave as a normal function
+  await asyncio.gather(
+    func()
+  )