Skip to content

Commit a3c4234

Browse files
SONARPY-1290 Exclude S1481 from default profile in IPython notebook context (#1407)
1 parent b12a98a commit a3c4234

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

sonar-python-plugin/src/main/java/org/sonar/plugins/python/IPynbProfile.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ public class IPynbProfile implements BuiltInQualityProfilesDefinition {
3030

3131
static final String PROFILE_NAME = "Sonar way";
3232
static final String PROFILE_LOCATION = RESOURCE_FOLDER + "/Sonar_way_profile.json";
33-
static final Set<String> DISABLED_RULES = Set.of("S905", "S2201", "S5754");
33+
static final Set<String> DISABLED_RULES = Set.of("S905", "S2201", "S5754", "S1481");
3434

3535
@Override
3636
public void define(Context context) {

sonar-python-plugin/src/test/java/org/sonar/plugins/python/IPynbProfileTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,5 +41,6 @@ public void profile() {
4141
assertThat(profile.rules()).extracting(BuiltInQualityProfilesDefinition.BuiltInActiveRule::ruleKey).doesNotContain("S905");
4242
assertThat(profile.rules()).extracting(BuiltInQualityProfilesDefinition.BuiltInActiveRule::ruleKey).doesNotContain("S2201");
4343
assertThat(profile.rules()).extracting(BuiltInQualityProfilesDefinition.BuiltInActiveRule::ruleKey).doesNotContain("S5754");
44+
assertThat(profile.rules()).extracting(BuiltInQualityProfilesDefinition.BuiltInActiveRule::ruleKey).doesNotContain("S1481");
4445
}
4546
}

0 commit comments

Comments
 (0)