SONARPY-1662 Fix FPs related to 'type' type (#1722)

Author: guillaume-dequenne

python-checks/src/main/java/org/sonar/python/checks/ArgumentTypeCheck.java

@@ -197,6 +197,6 @@ public static String matchBuiltinCategory(Predicate<String> predicate) {
   }
 
   private static boolean isException(InferredType inferredType) {
-    return inferredType.canBeOrExtend("unittest.mock.Mock");
+    return inferredType.canBeOrExtend("unittest.mock.Mock") || inferredType.canBeOrExtend("type");
   }
 }

python-checks/src/main/java/org/sonar/python/checks/CaughtExceptionsCheck.java

@@ -121,7 +121,7 @@ private static boolean canBeOrExtendBaseException(InferredType type) {
       // avoid FP on variables holding a tuple: SONARPY-713
       return true;
     }
-    if (type.canOnlyBe("type")) {
+    if (type.canBeOrExtend("type")) {
       // SONARPY-1666: Here we should only exclude type objects that represent Exception types
       return true;
     }

python-checks/src/main/java/org/sonar/python/checks/ExceptionCauseTypeCheck.java

@@ -63,7 +63,7 @@ private static void check(@Nullable Expression cause, SubscriptionContext ctx) {
       return;
     }
     InferredType causeType = cause.type();
-    if (causeType.canOnlyBe("type")) {
+    if (causeType.canBeOrExtend("type")) {
       // SONARPY-1666: Here we should only exclude type objects that represent Exception types
       return;
     }

python-checks/src/main/java/org/sonar/python/checks/IncorrectExceptionTypeCheck.java

@@ -55,7 +55,7 @@ public void initialize(Context context) {
       if (hasGlobalOrNonLocalUsage(symbol)) {
         return;
       }
-      if (!raisedExpression.type().canBeOrExtend(BASE_EXCEPTION) && !raisedExpression.type().canOnlyBe("type")) {
+      if (!raisedExpression.type().canBeOrExtend(BASE_EXCEPTION) && !raisedExpression.type().canBeOrExtend("type")) {
         // SONARPY-1666: Here we should only exclude type objects that represent Exception types
         ctx.addIssue(raiseStatement, MESSAGE);
         return;

python-checks/src/test/resources/checks/argumentType.py

@@ -256,3 +256,14 @@ def takes_int(some_parameter: int) -> int:
   takes_boolean(1.0) # Noncompliant
   takes_int(True)
   takes_boolean(42) # FN
+
+
+def no_fp_on_enum_types():
+    from enum import Enum
+
+    class EnumA(Enum):
+        A = 1
+        B = 2
+        C = 3
+
+    len(EnumA)

python-checks/src/test/resources/checks/caughtExceptions.py

@@ -77,3 +77,12 @@ def except_star():
     ...
   except* list():  # Noncompliant
     ...
+
+
+def reassigned_exception():
+    my_exception = None
+    my_exception = ZeroDivisionError
+    try:
+        ...
+    except my_exception:
+        ...

python-checks/src/test/resources/checks/exceptionCauseType.py

@@ -67,3 +67,12 @@ class SomeClass:
         foo()
     except ValueError:
         raise ValueError("Caught some value error") from SomeClass  # FN SONARPY-1666
+
+
+def reassigned_exception():
+    my_exception = None
+    my_exception = ZeroDivisionError
+    try:
+        ...
+    except my_exception:
+        raise my_exception("Caught some value error") from my_exception

python-checks/src/test/resources/checks/incompatibleOperands/arithmetic.py

@@ -118,3 +118,13 @@ class SomeCtypeClass(ctypes.Structure):
     class RandomClass:
         ...
     z = RandomClass * 42 # FN
+
+
+def type_symbols_try_except():
+    import ctypes
+    some_variable = None
+    some_variable = ctypes.c_int32
+    try:
+        x = some_variable * 42  # OK
+    except:
+        x = some_variable * 42  # OK

python-checks/src/test/resources/checks/incorrectExceptionType/incorrectExceptionType.py

@@ -153,3 +153,12 @@ def do_something():
     do_something()
     if exception:
         raise exception
+
+
+def reassigned_exception():
+    my_exception = None
+    my_exception = ValueError
+    try:
+        ...
+    except my_exception:
+        raise my_exception

python-checks/src/test/resources/checks/iterationOnNonIterable.py

@@ -276,3 +276,15 @@ def custom_mock():
     a, *rest = extended_mock
     iter(extended_mock)
     for elem in extended_mock: ... # OK
+
+
+def no_fp_on_enum_types():
+    from enum import Enum
+
+    class EnumA(Enum):
+        A = 1
+        B = 2
+        C = 3
+
+    for elem in EnumA:
+        ...