UnionType#resolveMember: handle typeclasses with unresolved hierarchies (#677)

Author: andrea-guarino-sonarsource

python-checks/src/test/resources/checks/argumentType.py

@@ -101,6 +101,10 @@ def builtin_functions():
 
   str.ljust(str(1), 3)
 
+  x = {}
+  x = []
+  x.pop(())
+
 def type_aliases():
   def with_set(a : Set[int]): ...
   def with_dict(a : Dict[int, int]): ...

python-frontend/src/main/java/org/sonar/python/semantic/ClassSymbolImpl.java

@@ -86,7 +86,11 @@ public void addSuperClass(Symbol symbol) {
 
   @Override
   public boolean hasUnresolvedTypeHierarchy() {
-    for (Symbol superClassSymbol : allSuperClasses(true)) {
+    return hasUnresolvedTypeHierarchy(true);
+  }
+
+  public boolean hasUnresolvedTypeHierarchy(boolean includeAmbiguousSymbols) {
+    for (Symbol superClassSymbol : allSuperClasses(includeAmbiguousSymbols)) {
       if (superClassSymbol.kind() != Kind.CLASS) {
         return true;
       }

python-frontend/src/main/java/org/sonar/python/types/RuntimeType.java

@@ -26,6 +26,7 @@
 import org.sonar.plugins.python.api.symbols.ClassSymbol;
 import org.sonar.plugins.python.api.symbols.Symbol;
 import org.sonar.plugins.python.api.types.InferredType;
+import org.sonar.python.semantic.ClassSymbolImpl;
 
 class RuntimeType implements InferredType {
 
@@ -116,6 +117,10 @@ private Set<String> typeClassMembersFQN() {
     return typeClassMembersFQN;
   }
 
+  boolean hasUnresolvedHierarchy() {
+    return ((ClassSymbolImpl) typeClass).hasUnresolvedTypeHierarchy(false);
+  }
+
   @Override
   public int hashCode() {
     return Objects.hash(typeClass.fullyQualifiedName(), typeClassSuperClassesFQN(), typeClassMembersFQN());

python-frontend/src/main/java/org/sonar/python/types/UnionType.java

@@ -71,6 +71,9 @@ public boolean canHaveMember(String memberName) {
 
   @Override
   public Optional<Symbol> resolveMember(String memberName) {
+    if (types.stream().anyMatch(type -> type instanceof RuntimeType && ((RuntimeType) type).hasUnresolvedHierarchy())) {
+      return Optional.empty();
+    }
     Set<Optional<Symbol>> resolved = types.stream()
       .map(t -> t.resolveMember(memberName))
       .filter(Optional::isPresent)

python-frontend/src/test/java/org/sonar/python/types/UnionTypeTest.java

@@ -21,8 +21,10 @@
 
 import java.util.Arrays;
 import java.util.Collections;
+import java.util.HashSet;
 import org.junit.Test;
 import org.sonar.plugins.python.api.types.InferredType;
+import org.sonar.python.semantic.AmbiguousSymbolImpl;
 import org.sonar.python.semantic.ClassSymbolImpl;
 import org.sonar.python.semantic.SymbolImpl;
 
@@ -80,6 +82,10 @@ public void resolveMember() {
     assertThat(or(runtimeType(x), runtimeType(y)).resolveMember("foo")).contains(foo);
     assertThat(or(runtimeType(x), runtimeType(z)).resolveMember("bar")).isEmpty();
     assertThat(or(runtimeType(x), runtimeType(z)).resolveMember("xxx")).isEmpty();
+
+    ClassSymbolImpl classWithUnresolvedHierarchy = new ClassSymbolImpl("u", "u");
+    classWithUnresolvedHierarchy.addSuperClass(AmbiguousSymbolImpl.create(new HashSet<>(Arrays.asList(x, new ClassSymbolImpl("x", "x")))));
+    assertThat(or(runtimeType(x), runtimeType(classWithUnresolvedHierarchy)).resolveMember("foo")).isEmpty();
   }
 
   @Test