SONARPY-1889 Fix non-deterministic stubFilesSymbols API for sonar-security (#1814)

Author: maksim-grebeniuk-sonarsource

python-frontend/src/main/java/org/sonar/python/semantic/v2/SymbolsModuleTypeProvider.java

@@ -71,7 +71,7 @@ private Optional<ModuleType> createModuleTypeFromProjectLevelSymbolTable(String
   }
 
   private Optional<ModuleType> createModuleTypeFromTypeShed(String moduleName, String moduleFqn, ModuleType parent) {
-    return Optional.ofNullable(TypeShed.symbolsForModule(moduleFqn))
+    return Optional.ofNullable(TypeShed.symbolsForModuleWithoutStoreInCache(moduleFqn))
       .filter(Predicate.not(Map::isEmpty))
       .map(typeShedModuleSymbols -> createModuleFromSymbols(moduleName, parent, typeShedModuleSymbols.values()));
   }

python-frontend/src/main/java/org/sonar/python/types/TypeShed.java

@@ -28,6 +28,7 @@
 import java.util.HashSet;
 import java.util.List;
 import java.util.Map;
+import java.util.Optional;
 import java.util.Set;
 import java.util.stream.Collectors;
 import javax.annotation.CheckForNull;
@@ -132,6 +133,13 @@ public static Map<String, Symbol> symbolsForModule(String moduleName) {
     return TypeShed.typeShedSymbols.get(moduleName);
   }
 
+  public static Map<String, Symbol> symbolsForModuleWithoutStoreInCache(String moduleName) {
+    return Optional.of(moduleName)
+      .filter(TypeShed.typeShedSymbols::containsKey)
+      .map(TypeShed.typeShedSymbols::get)
+      .orElseGet(() -> searchTypeShedForModule(moduleName));
+  }
+
   @CheckForNull
   public static Symbol symbolWithFQN(String stdLibModuleName, String fullyQualifiedName) {
     Map<String, Symbol> symbols = symbolsForModule(stdLibModuleName);