SONARPY-1846 Fix analysis warnings not being concateneted correctly with newline delimiters (#1807)

Author: 7PH

sonar-python-plugin/src/main/java/org/sonar/plugins/python/coverage/CoberturaParser.java

@@ -22,7 +22,7 @@
 import java.io.File;
 import java.util.ArrayList;
 import java.util.Collections;
-import java.util.HashSet;
+import java.util.LinkedHashSet;
 import java.util.List;
 import java.util.Map;
 import java.util.Set;
@@ -44,7 +44,7 @@ public class CoberturaParser {
 
   private static final Logger LOG = LoggerFactory.getLogger(CoberturaParser.class);
 
-  private final Set<String> errors = new HashSet<>();
+  private final Set<String> errors = new LinkedHashSet<>();
   private int unresolvedFilenameCount;
 
   public void parseReport(File xmlFile, SensorContext context, final Map<InputFile, NewCoverage> coverageData) throws XMLStreamException {

sonar-python-plugin/src/main/java/org/sonar/plugins/python/coverage/PythonCoverageSensor.java

@@ -114,7 +114,7 @@ private Map<InputFile, NewCoverage> parseReport(File report, SensorContext conte
       CoberturaParser parser = new CoberturaParser();
       parser.parseReport(report, context, coverageMeasures);
       if (!parser.errors().isEmpty()) {
-        String parseErrors = String.join("%n", parser.errors());
+        String parseErrors = String.format(String.join("%n", parser.errors()));
         analysisWarnings.addUnique(String.format("The following error(s) occurred while trying to import coverage report:%n%s", parseErrors));
       }
     } catch (EmptyReportException e) {

sonar-python-plugin/src/test/java/org/sonar/plugins/python/coverage/PythonCoverageSensorTest.java

@@ -305,10 +305,13 @@ void should_do_nothing_on_empty_report() {
   void should_warn_if_source_is_not_directory() {
     settings.setProperty(PythonCoverageSensor.REPORT_PATHS_KEY, "coverage_source_invalid_directory.xml");
     coverageSensor.execute(context);
-    File file = new File("src/test/resources/org/sonar/plugins/python/coverage-reports/sources/file1.py");
-    String message = "Invalid directory path in 'source' element: " + file.getPath();
-    assertThat(logTester.logs(Level.WARN)).contains(message);
-    verify(analysisWarnings, times(1)).addUnique("The following error(s) occurred while trying to import coverage report:" + System.lineSeparator() + message);
+    File file1 = new File("src/test/resources/org/sonar/plugins/python/coverage-reports/sources/file1.py");
+    File file2 = new File("src/test/resources/org/sonar/plugins/python/coverage-reports/sources/file2.py");
+    String message1 = "Invalid directory path in 'source' element: " + file1.getPath();
+    String message2 = "Invalid directory path in 'source' element: " + file2.getPath();
+    assertThat(logTester.logs(Level.WARN)).contains(message1);
+    assertThat(logTester.logs(Level.WARN)).contains(message2);
+    verify(analysisWarnings, times(1)).addUnique("The following error(s) occurred while trying to import coverage report:" + System.lineSeparator() + message1 + System.lineSeparator() + message2);
   }
 
   @Test

sonar-python-plugin/src/test/resources/org/sonar/plugins/python/coverage-reports/coverage_source_invalid_directory.xml

@@ -4,6 +4,7 @@
 	<!-- Based on https://raw.githubusercontent.com/cobertura/web/master/htdocs/xml/coverage-04.dtd -->
 	<sources>
 		<source>src/test/resources/org/sonar/plugins/python/coverage-reports/sources/file1.py</source>
+		<source>src/test/resources/org/sonar/plugins/python/coverage-reports/sources/file2.py</source>
 	</sources>
 	<packages></packages>
 </coverage>