Skip to content

Commit c320258

Browse files
committed
SONARPY-2383 remove or clarify Jira ticket references
1 parent 9ba8617 commit c320258

File tree

11 files changed

+4
-15
lines changed

11 files changed

+4
-15
lines changed

its/plugin/it-python-plugin-test/src/test/java/com/sonar/python/it/plugin/MetricsTest.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -161,9 +161,6 @@ void file_level() {
161161
assertThat(getFileMeasureAsInt(VIOLATIONS)).isZero();
162162
}
163163

164-
/**
165-
* SONARPLUGINS-2184
166-
*/
167164
@Test
168165
void should_be_compatible_with_DevCockpit() {
169166
// TODO probably bug in Sonar: order might depend on JVM

python-checks/src/main/java/org/sonar/python/checks/CommentedCodeCheck.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ private static boolean isEmpty(String text) {
135135
return IS_EMPTY_PATTERN.matcher(text).matches();
136136
}
137137

138-
// "source code encoding" comments (e.g. # coding=utf8) should be excluded (SONARPY-465)
138+
// "source code encoding" comments (e.g. # coding=utf8) should be excluded
139139
// Note that encoding must be on line 1 or 2
140140
private static boolean isEncoding(Trivia trivia, String text) {
141141
return trivia.token().line() < 3 && ENCODING_PATTERN.matcher(text).matches();

python-checks/src/main/java/org/sonar/python/checks/ElseAfterLoopsWithoutBreakCheck.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
import org.sonar.plugins.python.api.tree.WhileStatement;
2626

2727
// https://jira.sonarsource.com/browse/RSPEC-2836
28-
// https://jira.sonarsource.com/browse/SONARPY-650
2928
@Rule(key = "S2836")
3029
public class ElseAfterLoopsWithoutBreakCheck extends PythonSubscriptionCheck {
3130
private static final String MESSAGE = "Add a \"break\" statement or remove this \"else\" clause.";

python-checks/src/main/java/org/sonar/python/checks/ExceptionNotThrownCheck.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@
3535
import org.sonar.python.semantic.BuiltinSymbols;
3636

3737
// https://jira.sonarsource.com/browse/RSPEC-3984
38-
// https://jira.sonarsource.com/browse/SONARPY-666
3938
@Rule(key = "S3984")
4039
public class ExceptionNotThrownCheck extends PythonSubscriptionCheck {
4140
private static final String MESSAGE = "Raise this exception or remove this useless statement.";

python-checks/src/main/java/org/sonar/python/checks/IdentityComparisonWithCachedTypesCheck.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@
3939
import static java.util.Arrays.asList;
4040

4141
// https://jira.sonarsource.com/browse/RSPEC-5795
42-
// https://jira.sonarsource.com/browse/SONARPY-673
4342
@Rule(key = "S5795")
4443
public class IdentityComparisonWithCachedTypesCheck extends PythonSubscriptionCheck {
4544
private static final String MESSAGE_IS = "Replace this \"is\" operator with \"==\"; identity operator is not reliable here.";

python-checks/src/main/java/org/sonar/python/checks/IdentityComparisonWithNewObjectCheck.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@
4141
import static org.sonar.plugins.python.api.types.BuiltinTypes.NONE_TYPE;
4242

4343
// https://jira.sonarsource.com/browse/RSPEC-5796
44-
// https://jira.sonarsource.com/browse/SONARPY-674
4544
@Rule(key = "S5796")
4645
public class IdentityComparisonWithNewObjectCheck extends PythonSubscriptionCheck {
4746
private static final String MESSAGE_IS = "Replace this \"is\" operator with \"==\".";

python-checks/src/main/java/org/sonar/python/checks/VerifiedSslTlsCertificateCheck.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,9 +56,7 @@
5656

5757
import static java.util.Optional.ofNullable;
5858

59-
// https://jira.sonarsource.com/browse/SONARPY-357
6059
// https://jira.sonarsource.com/browse/RSPEC-4830
61-
// https://jira.sonarsource.com/browse/MMF-1872
6260
@Rule(key = "S4830")
6361
public class VerifiedSslTlsCertificateCheck extends PythonSubscriptionCheck {
6462

python-checks/src/main/java/org/sonar/python/checks/hotspots/CsrfDisabledCheck.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,8 @@
5050
import org.sonar.python.checks.utils.Expressions;
5151
import org.sonar.python.tree.TreeUtils;
5252

53-
// https://jira.sonarsource.com/browse/SONARPY-668
53+
// for an overview of how this rule works, see the following ticket describing the implementation(keep in mind that the rule might have changed since the ticket was last
54+
// updated (06.05.2020)): https://jira.sonarsource.com/browse/SONARPY-668
5455
// https://jira.sonarsource.com/browse/RSPEC-5792
5556
@Rule(key = "S4502")
5657
public class CsrfDisabledCheck extends PythonSubscriptionCheck {

python-checks/src/main/java/org/sonar/python/checks/regex/AbstractRegexCheck.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ public PreciseIssue addIssue(RegexSyntaxElement regexTree, String message, @Null
212212
if (reportedRegexTrees.add(regexTree)) {
213213
PreciseIssue issue = regexContext.addIssue(regexTree, message);
214214
secondaries.stream().map(PythonRegexIssueLocation::preciseLocation).forEach(issue::secondary);
215-
// TODO: Add cost to the issue SONARPY-893
215+
// TODO: Add cost to the issue
216216
return issue;
217217
}
218218
return null;

python-frontend/src/main/java/org/sonar/python/semantic/SymbolTableBuilder.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -302,7 +302,6 @@ public void visitDictCompExpression(DictCompExpression tree) {
302302
/**
303303
* The scope of the decorator should be the parent scope of the function or class to which the decorator is assigned.
304304
* So we have to leave the function or class scope, visit the decorator and enter the previous scope.
305-
* See <a href="https://sonarsource.atlassian.net/browse/SONARPY-990">SONARPY-990</a>
306305
*/
307306
@Override
308307
public void visitDecorator(Decorator tree) {

0 commit comments

Comments
 (0)