SONARPY-960 Typeshed serializer: resolve type of alias variables to overloaded symbols

Author: guillaume-dequenne

python-frontend/src/test/java/org/sonar/python/types/TypeShedTest.java

@@ -527,6 +527,15 @@ public void typeshed_private_modules_should_not_affect_fqn()  {
     assertThat(socket.superClasses()).extracting(Symbol::fullyQualifiedName).containsExactly("object");
   }
 
+  @Test
+  public void overloaded_function_alias_has_function_annotated_type()  {
+    Map<String, Symbol> gettextModule = symbolsForModule("gettext");
+    Symbol translation = gettextModule.get("translation");
+    Symbol catalog = gettextModule.get("Catalog");
+    assertThat(translation.kind()).isEqualTo(Kind.AMBIGUOUS);
+    assertThat(catalog.annotatedTypeName()).isEqualTo("function");
+  }
+
   @Test
   public void stubFilesSymbols_third_party_symbols_should_not_be_null() {
     // six modules contain ambiguous symbols that only contain class symbols

python-frontend/typeshed_serializer/serializer/symbols.py

@@ -135,6 +135,12 @@ def __init__(self, _type: mpt.Type):
             self.kind = TypeKind.TYPED_DICT
             # TODO: check in items for key/type mapping
             self.pretty_printed_name = "TypedDict"
+        elif isinstance(_type, mpt.Overloaded):
+            self.kind = TypeKind.CALLABLE
+            fallback = TypeDescriptor(_type.fallback)
+            self.fully_qualified_name = fallback.fully_qualified_name
+            self.args.append(fallback)
+            self.pretty_printed_name = f"CallableType[{fallback.pretty_printed_name}]"
         else:
             # this can happen when there is a var symbol assigned to an overload symbol
             self.is_unknown = True

python-frontend/typeshed_serializer/tests/test_symbols_merger.py

@@ -21,7 +21,7 @@
 from unittest.mock import Mock
 
 from serializer import symbols, symbols_merger
-from serializer.symbols import MergedModuleSymbol
+from serializer.symbols import MergedModuleSymbol, TypeKind
 
 
 def test_build_multiple_python_version(typeshed_stdlib):
@@ -235,8 +235,9 @@ def test_actual_module_merge(fake_module_36_38):
     alias = all_vars['fakemodule.alias']
     assert len(alias) == 1
     alias_symbol = alias[0].var_symbol
-    assert alias_symbol.type.fully_qualified_name is None
-    assert alias_symbol.type.is_unknown is True
+    assert alias_symbol.type.fully_qualified_name == "builtins.function"
+    assert alias_symbol.type.kind == TypeKind.CALLABLE
+    assert alias_symbol.type.pretty_printed_name == "CallableType[builtins.function]"
 
     imported_sys = all_vars['sys']
     assert len(imported_sys) == 1