SONARPY-949 S5756 (NonCallableCalled): avoid reporting on typeshed sy… (#1030)

Author: andrea-guarino-sonarsource

its/ruling/src/test/resources/expected/python-S5756.json

@@ -66,10 +66,12 @@ def member_access():
   my_callable.non_callable = 42
   my_callable.non_callable() # FN
 
-def types_from_typeshed():
+def types_from_typeshed(foo):
   from math import acos
+  from functools import wraps
   acos(42)() # Noncompliant {{Fix this call; this expression has type float and it is not callable.}}
 # ^^^^^^^^
+  wraps(func)(foo) # OK, wraps returns a Callable
 
 def with_metaclass():
   class Factory: ...

python-checks/src/test/resources/checks/nonCallableCalled.py

@@ -156,8 +156,10 @@ public static InferredType fromTypeshedProtobuf(SymbolsProtos.Type type) {
         String typeName = type.getFullyQualifiedName();
         return typeName.isEmpty() ? anyType() : runtimeType(TypeShed.symbolWithFQN(typeName));
       case TYPE_ALIAS:
-      case CALLABLE:
         return fromTypeshedProtobuf(type.getArgs(0));
+      case CALLABLE:
+        // this should be handled as a function type - see SONARPY-953
+        return anyType();
       case UNION:
         return union(type.getArgsList().stream().map(InferredTypes::fromTypeshedProtobuf));
       case TUPLE:

python-frontend/src/main/java/org/sonar/python/types/InferredTypes.java

@@ -359,6 +359,7 @@ public void test_type_from_protobuf() throws TextFormat.ParseException {
       "fully_qualified_name: \"mod.t\""
       ))
       .isEqualTo(InferredTypes.or(STR, INT));
+    assertThat(protobufType("kind: CALLABLE")).isEqualTo(anyType());
   }
 
   private static InferredType protobufType(String protobuf) throws TextFormat.ParseException {