SONARPY 1745b Update .collect(Collectors.toList()) to .toList()

Author: ghislainpiot

python-checks/src/main/java/org/sonar/python/checks/ChangeMethodContractCheck.java

@@ -26,7 +26,6 @@
 import java.util.Optional;
 import java.util.Set;
 import java.util.function.Predicate;
-import java.util.stream.Collectors;
 import javax.annotation.Nullable;
 import org.sonar.check.Rule;
 import org.sonar.plugins.python.api.LocationInFile;

python-checks/src/main/java/org/sonar/python/checks/ChildAndParentExceptionCaughtCheck.java

@@ -76,7 +76,7 @@ private static void checkCaughtExceptions(SubscriptionContext ctx, Map<ClassSymb
       var caughtParentExceptions = caughtExceptionsBySymbol.entrySet()
         .stream()
         .filter(entry -> entry.getKey() != currentSymbol && currentSymbol.isOrExtends(entry.getKey()))
-        .collect(Collectors.toList());
+        .toList();
 
       if (!caughtParentExceptions.isEmpty()) {
         var issue = ctx.addIssue(currentException, "Remove this redundant Exception class; it derives from another which is already caught.");

python-checks/src/main/java/org/sonar/python/checks/ClassMethodFirstArgumentNameCheck.java

@@ -21,20 +21,19 @@
 
 import java.util.Arrays;
 import java.util.List;
-import java.util.stream.Collectors;
 import java.util.stream.Stream;
 import org.sonar.check.Rule;
 import org.sonar.check.RuleProperty;
 import org.sonar.plugins.python.api.PythonSubscriptionCheck;
 import org.sonar.plugins.python.api.SubscriptionContext;
+import org.sonar.plugins.python.api.quickfix.PythonQuickFix;
+import org.sonar.plugins.python.api.quickfix.PythonTextEdit;
 import org.sonar.plugins.python.api.tree.Decorator;
 import org.sonar.plugins.python.api.tree.FunctionDef;
 import org.sonar.plugins.python.api.tree.Name;
 import org.sonar.plugins.python.api.tree.Parameter;
 import org.sonar.plugins.python.api.tree.ParameterList;
 import org.sonar.plugins.python.api.tree.Tree;
-import org.sonar.plugins.python.api.quickfix.PythonQuickFix;
-import org.sonar.plugins.python.api.quickfix.PythonTextEdit;
 import org.sonar.python.quickfix.TextEditUtils;
 import org.sonar.python.tree.TreeUtils;
 
@@ -55,7 +54,7 @@ private List<String> classParameterNames() {
     if (classParameterNamesList == null) {
       classParameterNamesList = Stream.of(classParameterNames.split(","))
         .map(String::trim)
-        .collect(Collectors.toList());
+        .toList();
     }
     return classParameterNamesList;
   }

python-checks/src/main/java/org/sonar/python/checks/DjangoNonDictSerializationCheck.java

@@ -21,7 +21,6 @@
 
 import java.util.List;
 import java.util.Objects;
-import java.util.stream.Collectors;
 import javax.annotation.CheckForNull;
 import org.sonar.check.Rule;
 import org.sonar.plugins.python.api.PythonSubscriptionCheck;
@@ -83,7 +82,7 @@ private static boolean couldDictBeAssignedToDataArg(Name dataArg, int recursiveC
         .map(Usage::tree)
         .map(usage -> TreeUtils.firstAncestorOfKind(usage, Tree.Kind.ASSIGNMENT_STMT, Tree.Kind.ANNOTATED_ASSIGNMENT, Tree.Kind.ASSIGNMENT_EXPRESSION))
         .filter(Objects::nonNull)
-        .collect(Collectors.toList());
+        .toList();
       if (assignmentStmts.size() == 1) {
         Tree assignment = assignmentStmts.get(0);
         Expression assignedValue = getAssignedValue(assignment);

python-checks/src/main/java/org/sonar/python/checks/DjangoRenderContextCheck.java

@@ -21,7 +21,6 @@
 
 import java.util.List;
 import java.util.Objects;
-import java.util.stream.Collectors;
 import javax.annotation.CheckForNull;
 import org.sonar.check.Rule;
 import org.sonar.plugins.python.api.PythonSubscriptionCheck;
@@ -85,7 +84,7 @@ private static void checkIfLocalsIsAssignedToContextParameter(SubscriptionContex
           .map(Usage::tree)
           .map(usage -> TreeUtils.firstAncestorOfKind(usage, Tree.Kind.ASSIGNMENT_EXPRESSION, Tree.Kind.ASSIGNMENT_STMT, Tree.Kind.ANNOTATED_ASSIGNMENT))
           .filter(Objects::nonNull)
-          .collect(Collectors.toList());
+          .toList();
         if (assignmentStmts.size() == 1) {
           Tree assignment = assignmentStmts.get(0);
           Expression assignedValue = getAssignedValue(assignment);

python-checks/src/main/java/org/sonar/python/checks/DuplicatedMethodFieldNamesCheck.java

@@ -24,16 +24,15 @@
 import java.util.LinkedList;
 import java.util.List;
 import java.util.Optional;
-import java.util.stream.Collectors;
 import org.sonar.check.Rule;
 import org.sonar.plugins.python.api.PythonSubscriptionCheck;
 import org.sonar.plugins.python.api.SubscriptionContext;
 import org.sonar.plugins.python.api.symbols.ClassSymbol;
+import org.sonar.plugins.python.api.symbols.Symbol;
+import org.sonar.plugins.python.api.tree.BaseTreeVisitor;
 import org.sonar.plugins.python.api.tree.ClassDef;
 import org.sonar.plugins.python.api.tree.FunctionDef;
 import org.sonar.plugins.python.api.tree.Tree;
-import org.sonar.plugins.python.api.symbols.Symbol;
-import org.sonar.plugins.python.api.tree.BaseTreeVisitor;
 import org.sonar.python.tree.TreeUtils;
 
 @Rule(key = "S1845")
@@ -56,7 +55,7 @@ public void initialize(Context context) {
         .map(s -> s.usages().stream().findFirst())
         .filter(Optional::isPresent)
         .map(usage -> usage.get().tree())
-        .collect(Collectors.toList());
+        .toList();
       lookForDuplications(ctx, fieldNames, methodVisitor.methodNames);
     });
   }

python-checks/src/main/java/org/sonar/python/checks/FlaskHardCodedSecret.java

@@ -23,7 +23,6 @@
 import java.util.List;
 import java.util.Optional;
 import java.util.Set;
-import java.util.stream.Collectors;
 import javax.annotation.Nullable;
 import org.sonar.plugins.python.api.PythonSubscriptionCheck;
 import org.sonar.plugins.python.api.SubscriptionContext;
@@ -157,7 +156,7 @@ private void verifyAssignmentStatement(SubscriptionContext ctx) {
       .map(ExpressionList::expressions)
       .flatMap(List::stream)
       .filter(this::isSensitiveProperty)
-      .collect(Collectors.toList());
+      .toList();
     if (!expressionList.isEmpty()) {
       PreciseIssue issue = ctx.addIssue(assignmentStatementTree.assignedValue(), getMessage());
       expressionList.forEach(expr -> issue.secondary(expr, SECONDARY_MESSAGE));

python-checks/src/main/java/org/sonar/python/checks/IgnoredSystemExitCheck.java

@@ -21,12 +21,12 @@
 
 import java.util.List;
 import java.util.Optional;
-import java.util.stream.Collectors;
 import javax.annotation.CheckForNull;
 import javax.annotation.Nullable;
 import org.sonar.check.Rule;
 import org.sonar.plugins.python.api.PythonSubscriptionCheck;
 import org.sonar.plugins.python.api.SubscriptionContext;
+import org.sonar.plugins.python.api.quickfix.PythonQuickFix;
 import org.sonar.plugins.python.api.symbols.Symbol;
 import org.sonar.plugins.python.api.tree.BaseTreeVisitor;
 import org.sonar.plugins.python.api.tree.CallExpression;
@@ -37,7 +37,6 @@
 import org.sonar.plugins.python.api.tree.Token;
 import org.sonar.plugins.python.api.tree.Tree;
 import org.sonar.plugins.python.api.tree.TryStatement;
-import org.sonar.plugins.python.api.quickfix.PythonQuickFix;
 import org.sonar.python.quickfix.TextEditUtils;
 import org.sonar.python.tree.TreeUtils;
 
@@ -212,7 +211,7 @@ public void initialize(Context context) {
         Expression exceptionInstance = exceptClause.exceptionInstance();
         Symbol exceptionInstanceSymbol = findExceptionInstanceSymbol(exceptionInstance);
 
-        List<Expression> caughtExceptions = TreeUtils.flattenTuples(exceptionExpr).collect(Collectors.toList());
+        List<Expression> caughtExceptions = TreeUtils.flattenTuples(exceptionExpr).toList();
         for (Expression caughtException : caughtExceptions) {
           isSystemExitHandled |= handleCaughtException(ctx, caughtException, exceptionInstanceSymbol, exceptClause.body(), isSystemExitHandled);
         }

python-checks/src/main/java/org/sonar/python/checks/InfiniteRecursionCheck.java

@@ -26,7 +26,6 @@
 import java.util.HashSet;
 import java.util.List;
 import java.util.Set;
-import java.util.stream.Collectors;
 import javax.annotation.CheckForNull;
 import javax.annotation.Nullable;
 import org.sonar.check.Rule;
@@ -98,7 +97,7 @@ private static boolean collectRecursiveCallsAndCheckIfEndBlockIsReachable(Functi
       if (!blockRecursiveCalls.isEmpty()) {
         allRecursiveCalls.addAll(blockRecursiveCalls.stream()
           .filter(tree -> !isInsideTryBlock(tree))
-          .collect(Collectors.toList()));
+          .toList());
       } else {
         block.successors().stream().filter(pushedBlocks::add).forEach(blockToVisit::addLast);
       }

python-checks/src/main/java/org/sonar/python/checks/InstanceAndClassMethodsAtLeastOnePositionalCheck.java

@@ -22,18 +22,17 @@
 import java.util.Arrays;
 import java.util.List;
 import java.util.Objects;
-import java.util.stream.Collectors;
 import org.sonar.check.Rule;
 import org.sonar.plugins.python.api.PythonSubscriptionCheck;
 import org.sonar.plugins.python.api.SubscriptionContext;
+import org.sonar.plugins.python.api.quickfix.PythonQuickFix;
 import org.sonar.plugins.python.api.symbols.ClassSymbol;
 import org.sonar.plugins.python.api.symbols.FunctionSymbol;
 import org.sonar.plugins.python.api.symbols.Usage;
 import org.sonar.plugins.python.api.tree.ClassDef;
 import org.sonar.plugins.python.api.tree.FunctionDef;
 import org.sonar.plugins.python.api.tree.Parameter;
 import org.sonar.plugins.python.api.tree.Tree;
-import org.sonar.plugins.python.api.quickfix.PythonQuickFix;
 import org.sonar.python.tree.TreeUtils;
 
 import static org.sonar.python.quickfix.TextEditUtils.insertAfter;
@@ -81,7 +80,7 @@ private static void handleFunctionDef(SubscriptionContext ctx, ClassDef classDef
     List<String> decoratorNames = functionDef.decorators()
       .stream()
       .map(decorator -> TreeUtils.decoratorNameFromExpression(decorator.expression()))
-      .filter(Objects::nonNull).collect(Collectors.toList());
+      .filter(Objects::nonNull).toList();
 
     if (decoratorNames.contains("staticmethod")) {
       return;