Remove fs-extra dependency and centralized deps.ts

Replace fs-extra with native Node.js fs module throughout the codebase:
- fsExtra.remove() -> fs.promises.rm() with recursive/force options
- fsExtra.ensureDir() -> fs.promises.mkdir() with recursive option
- fsExtra.exists() -> custom function using fs.promises.access()

Move dependency injection interfaces from centralized deps.ts to local
interfaces in each module (FileDeps, ScannerCliFsDeps, etc.), improving
code locality and maintainability.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: vdiez

package-lock.json

@@ -18,7 +18,6 @@
     "adm-zip": "0.5.16",
     "axios": "1.13.2",
     "commander": "13.1.0",
-    "fs-extra": "11.3.3",
     "hpagent": "1.2.0",
     "node-forge": "1.3.3",
     "properties-file": "3.6.3",
@@ -29,7 +28,6 @@
   },
   "devDependencies": {
     "@types/adm-zip": "0.5.7",
-    "@types/fs-extra": "11.0.4",
     "@types/node": "24.10.4",
     "@types/node-forge": "1.3.14",
     "@types/proxy-from-env": "1.0.4",

package.json

@@ -17,10 +17,27 @@
  * along with this program; if not, write to the Free Software Foundation,
  * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
  */
-import * as path from 'path';
+import * as path from 'node:path';
 import * as toml from 'toml';
-import { ensureDir, readJson, writeJson } from 'fs-extra';
-import { readFile } from 'node:fs/promises';
+import { readFile, writeFile, mkdir } from 'node:fs/promises';
+
+async function readJson(filePath: string): Promise<any> {
+  const content = await readFile(filePath, 'utf-8');
+  return JSON.parse(content);
+}
+
+async function writeJson(
+  filePath: string,
+  data: any,
+  options: { spaces?: number } = {},
+): Promise<void> {
+  const content = JSON.stringify(data, null, options.spaces);
+  await writeFile(filePath, content + '\n');
+}
+
+async function ensureDir(dirPath: string): Promise<void> {
+  await mkdir(dirPath, { recursive: true });
+}
 
 async function main() {
   // Paths

scripts/generate-package-json.ts

@@ -19,27 +19,45 @@
  */
 import AdmZip from 'adm-zip';
 import crypto from 'node:crypto';
-import fsExtra from 'fs-extra';
+import fs from 'node:fs';
 import path from 'node:path';
 import tarStream from 'tar-stream';
 import zlib from 'node:zlib';
 import { SONAR_CACHE_DIR, UNARCHIVE_SUFFIX } from './constants';
-import { defaultFsDeps, FsDeps } from './deps';
 import { LogLevel, log } from './logging';
 import { CacheFileData, ScannerProperties, ScannerProperty } from './types';
 
+export interface FileDeps {
+  existsSync: typeof fs.existsSync;
+  readFile: typeof fs.readFile;
+  remove: (path: string) => Promise<void>;
+  mkdirSync: typeof fs.mkdirSync;
+  createReadStream: typeof fs.createReadStream;
+  createWriteStream: typeof fs.createWriteStream;
+}
+
+const defaultFileDeps: FileDeps = {
+  existsSync: fs.existsSync,
+  readFile: fs.readFile,
+  remove: (filePath: string) => fs.promises.rm(filePath, { recursive: true, force: true }),
+  mkdirSync: fs.mkdirSync,
+  createReadStream: fs.createReadStream,
+  createWriteStream: fs.createWriteStream,
+};
+
 export async function getCacheFileLocation(
   properties: ScannerProperties,
   { checksum, filename, alias }: CacheFileData,
-  fsDeps: FsDeps = defaultFsDeps,
+  deps: Partial<FileDeps> = {},
 ) {
+  const fsDeps = { ...defaultFileDeps, ...deps };
   const filePath = path.join(getParentCacheDirectory(properties), checksum, filename);
   if (fsDeps.existsSync(filePath)) {
     log(LogLevel.DEBUG, alias, 'version found in cache:', filename);
 
     // validate cache
     try {
-      await validateChecksum(filePath, checksum, fsDeps);
+      await validateChecksum(filePath, checksum, deps);
     } catch (error) {
       await fsDeps.remove(filePath);
       throw error;
@@ -55,8 +73,9 @@ export async function getCacheFileLocation(
 export async function extractArchive(
   fromPath: string,
   toPath: string,
-  fsDeps: FsDeps = defaultFsDeps,
+  deps: Partial<FileDeps> = {},
 ) {
+  const fsDeps = { ...defaultFileDeps, ...deps };
   log(LogLevel.DEBUG, `Extracting ${fromPath} to ${toPath}`);
   if (fromPath.endsWith('.tar.gz')) {
     const tarFilePath = fromPath;
@@ -68,7 +87,7 @@ export async function extractArchive(
         const filePath = path.join(toPath, header.name);
 
         // Ensure the parent directory exists
-        await fsExtra.ensureDir(path.dirname(filePath));
+        fsDeps.mkdirSync(path.dirname(filePath), { recursive: true });
 
         stream.pipe(fsDeps.createWriteStream(filePath, { mode: header.mode }));
         stream.on('end', next); // End of file, move onto next file
@@ -97,7 +116,8 @@ export async function extractArchive(
   }
 }
 
-async function generateChecksum(filepath: string, fsDeps: FsDeps = defaultFsDeps) {
+async function generateChecksum(filepath: string, deps: Partial<FileDeps> = {}) {
+  const fsDeps = { ...defaultFileDeps, ...deps };
   return new Promise((resolve, reject) => {
     fsDeps.readFile(filepath, (err, data) => {
       if (err) {
@@ -112,11 +132,11 @@ async function generateChecksum(filepath: string, fsDeps: FsDeps = defaultFsDeps
 export async function validateChecksum(
   filePath: string,
   expectedChecksum: string,
-  fsDeps: FsDeps = defaultFsDeps,
+  deps: Partial<FileDeps> = {},
 ) {
   if (expectedChecksum) {
     log(LogLevel.DEBUG, `Verifying checksum ${expectedChecksum}`);
-    const checksum = await generateChecksum(filePath, fsDeps);
+    const checksum = await generateChecksum(filePath, deps);
 
     log(LogLevel.DEBUG, `Checksum Value: ${checksum}`);
     if (checksum !== expectedChecksum) {
@@ -132,8 +152,9 @@ export async function validateChecksum(
 export async function getCacheDirectories(
   properties: ScannerProperties,
   { checksum, filename }: CacheFileData,
-  fsDeps: FsDeps = defaultFsDeps,
+  deps: Partial<FileDeps> = {},
 ) {
+  const fsDeps = { ...defaultFileDeps, ...deps };
   const archivePath = path.join(getParentCacheDirectory(properties), checksum, filename);
   const unarchivePath = path.join(
     getParentCacheDirectory(properties),

src/deps.ts

@@ -17,6 +17,7 @@
  * along with this program; if not, write to the Free Software Foundation,
  * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
  */
+import fs from 'node:fs';
 import path from 'node:path';
 import semver, { SemVer } from 'semver';
 import {
@@ -27,7 +28,6 @@ import {
   SONARQUBE_JRE_PROVISIONING_MIN_VERSION,
   UNARCHIVE_SUFFIX,
 } from './constants';
-import { defaultFsDeps, FsDeps } from './deps';
 import {
   extractArchive,
   getCacheDirectories,
@@ -44,8 +44,16 @@ import {
   ScannerProperty,
 } from './types';
 
+export interface JavaFsDeps {
+  remove: (path: string) => Promise<void>;
+}
+
+const defaultFsDeps: JavaFsDeps = {
+  remove: (filePath: string) => fs.promises.rm(filePath, { recursive: true, force: true }),
+};
+
 export interface JavaDeps {
-  fsDeps?: FsDeps;
+  fsDeps?: JavaFsDeps;
   fetchFn?: typeof fetch;
   downloadFn?: typeof download;
   getCacheFileLocationFn?: typeof getCacheFileLocation;