Skip to content

Commit af8d08d

Browse files
daniel-teuchert-sonarsourcesonartech
authored andcommitted
SECRETS-178: Raise an issue for S6706 when there is not whitespace
1 parent 8a0f6ad commit af8d08d

File tree

2 files changed

+39
-4
lines changed

2 files changed

+39
-4
lines changed

sonar-text-plugin/src/main/resources/org/sonar/plugins/secrets/configuration/gcp.yaml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,3 +80,10 @@ provider:
8080
"client_x509_cert_url": "https://www.googleapis.com/robot/v1/metadata/x509/xyz%40developer.gserviceaccount.com"
8181
}
8282
containsSecret: false
83+
- text: |
84+
# Test case from pubkey-crypto.yaml to show that there is no overlap
85+
-----BEGIN PRIVATE KEY-----\nMG8CAQAwEwYHKoZIzj0CAQYIKoZIzj0DAQEEVTBTAgEBBBiYwF7DmgkMs5nuBTGo
86+
qStzE1qIw4I8oR6hNAMyAARglVCk/eB1iMoPWZO+GyLAdpb7PykKintU3m9cS8cN
87+
/I3gU7NXutYjL9npMWLoHPI=
88+
-----END PRIVATE KEY-----
89+
containsSecret: false

sonar-text-plugin/src/main/resources/org/sonar/plugins/secrets/configuration/pubkey-crypto.yaml

Lines changed: 32 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -277,27 +277,55 @@ provider:
277277
metadata:
278278
name: Private keys should not be disclosed
279279
detection:
280+
pre:
281+
reject:
282+
content:
283+
# This prevents overlap with gcp.yaml
284+
- "accounts.google.com"
285+
ext:
286+
- .adoc
287+
- .example
288+
- .html
289+
- .md
290+
- .mdx
291+
- .template
280292
matching:
281-
pattern: "(-----BEGIN PRIVATE KEY-----) "
293+
pattern: "(-----BEGIN PRIVATE KEY-----)"
282294
context:
283295
matchEach:
284296
- patternAfter: "[a-zA-Z0-9+/]{60,}"
285297
- patternAfter: "-----END PRIVATE KEY-----"
286298
examples:
287299
- text: |
288-
-----BEGIN PRIVATE KEY----- \nMG8CAQAwEwYHKoZIzj0CAQYIKoZIzj0DAQEEVTBTAgEBBBiYwF7DmgkMs5nuBTGo
300+
-----BEGIN PRIVATE KEY-----\nMG8CAQAwEwYHKoZIzj0CAQYIKoZIzj0DAQEEVTBTAgEBBBiYwF7DmgkMs5nuBTGo
289301
qStzE1qIw4I8oR6hNAMyAARglVCk/eB1iMoPWZO+GyLAdpb7PykKintU3m9cS8cN
290302
/I3gU7NXutYjL9npMWLoHPI=
291303
-----END PRIVATE KEY-----
292304
containsSecret: true
293-
match: "-----BEGIN PRIVATE KEY----- "
305+
match: "-----BEGIN PRIVATE KEY-----"
294306
- text: |
295-
-----BEGIN PRIVATE KEY----- \nMG8CAQAwEwYHKoZIzj0CAQYIKoZIzj0DAQEEVTBTAgEBBBiYwF7DmgkMs5nuBTGo
307+
-----BEGIN PRIVATE KEY-----\nMG8CAQAwEwYHKoZIzj0CAQYIKoZIzj0DAQEEVTBTAgEBBBiYwF7DmgkMs5nuBTGo
296308
qStzE1qIw4I8oR6hNAMyAARglVCk/eB1iMoPWZO+GyLAdpb7PykKintU3m9cS8cN
297309
/I3gU7NXutYjL9npMWLoHPI=
298310
-----END PRIVATE KEY-----
299311
fileName: Doc.template
300312
containsSecret: false
313+
- text: |
314+
# Test case from gcp.yaml to show that there is no overlap
315+
{
316+
"type": "service_account",
317+
"project_id": "example-project",
318+
"private_key_id": "2772b8e6f42dc67369b98f0b91694f7805b28844",
319+
"private_key": "-----BEGIN PRIVATE KEY-----\nKBww9jggAgBEHBCBAASIMDsoCBAuAQINAgFAGSXQTkiAE0cEIkoQghJAqGavB/r3\n2W6raHa1Qrfj6pii5U2Ok53SxCyK3TxYc3Bfxq8orZeYC9LQ/I3tz7w4/BnT71AD\nfP1i8SWHsRMIicSuVFcRoYMA+A1eNSmdrujdBNWgedfuSyHbPnNY7s8BBUIoBN7I\n8gJG5DUUKAZfZDB2c/n7Yu0=\n-----END PRIVATE KEY-----\n",
320+
"client_email": "[email protected]",
321+
"client_id": "492539091821492546176",
322+
"auth_uri": "https://accounts.google.com/o/oauth2/auth",
323+
"token_uri": "https://oauth2.googleapis.com/token",
324+
"auth_provider_x509_cert_url": "https://www.googleapis.com/oauth2/v1/certs",
325+
"client_x509_cert_url": "https://www.googleapis.com/robot/v1/metadata/x509/example%40example.iam.gserviceaccount.example.com",
326+
"universe_domain": "googleapis.com"
327+
}
328+
containsSecret: false
301329
302330
- id: pkcs8-private-key-encrypted
303331
rspecKey: S6706

0 commit comments

Comments
 (0)