Use backend capabilities enum set during initialization

Author: sophio-japharidze-sonarsource

src/main/java/org/sonarsource/sonarlint/ls/backend/BackendServiceFacade.java

@@ -27,6 +27,7 @@
 import java.nio.file.Paths;
 import java.time.Duration;
 import java.util.EnumMap;
+import java.util.EnumSet;
 import java.util.List;
 import java.util.Map;
 import java.util.Optional;
@@ -44,8 +45,8 @@
 import org.sonarsource.sonarlint.core.rpc.protocol.backend.config.binding.BindingConfigurationDto;
 import org.sonarsource.sonarlint.core.rpc.protocol.backend.config.scope.ConfigurationScopeDto;
 import org.sonarsource.sonarlint.core.rpc.protocol.backend.config.scope.DidAddConfigurationScopesParams;
+import org.sonarsource.sonarlint.core.rpc.protocol.backend.initialize.BackendCapability;
 import org.sonarsource.sonarlint.core.rpc.protocol.backend.initialize.ClientConstantInfoDto;
-import org.sonarsource.sonarlint.core.rpc.protocol.backend.initialize.FeatureFlagsDto;
 import org.sonarsource.sonarlint.core.rpc.protocol.backend.initialize.HttpConfigurationDto;
 import org.sonarsource.sonarlint.core.rpc.protocol.backend.initialize.InitializeParams;
 import org.sonarsource.sonarlint.core.rpc.protocol.backend.initialize.JsTsRequirementsDto;
@@ -159,8 +160,7 @@ private void initOnce(Map<String, ServerConnectionSettings> connections) {
   }
 
   private InitializeParams toInitParams(BackendInitParams initParams) {
-    var telemetryEnabled = telemetry != null && telemetry.enabled();
-    var monitoringEnabled = shouldEnableMonitoring();
+    var backendCapabilities = getBackendCapabilities(initParams);
     var clientNodeJsPath = StringUtils.isEmpty(initParams.getClientNodePath()) ? null : Path.of(initParams.getClientNodePath());
     var eslintBridgeServerBundlePath = StringUtils.isEmpty(initParams.getEslintBridgeServerPath()) ? null : Path.of(initParams.getEslintBridgeServerPath());
     var languageSpecificRequirements = getLanguageSpecificRequirements(clientNodeJsPath, eslintBridgeServerBundlePath);
@@ -173,8 +173,7 @@ private InitializeParams toInitParams(BackendInitParams initParams) {
         telemetryInitParams.additionalAttributes()),
       getHttpConfiguration(),
       getSonarCloudAlternativeEnvironment(),
-      new FeatureFlagsDto(true, true, true,
-        true, initParams.isEnableSecurityHotspots(), true, true, true, telemetryEnabled, true, monitoringEnabled),
+      backendCapabilities,
       initParams.getStorageRoot(),
       Path.of(initParams.getSonarlintUserHome()),
       initParams.getEmbeddedPluginPaths(),
@@ -193,6 +192,23 @@ private InitializeParams toInitParams(BackendInitParams initParams) {
     );
   }
 
+  @NotNull
+  EnumSet<BackendCapability> getBackendCapabilities(BackendInitParams initParams) {
+    var backendCapabilities = EnumSet.of(BackendCapability.SMART_NOTIFICATIONS, BackendCapability.PROJECT_SYNCHRONIZATION,
+      BackendCapability.EMBEDDED_SERVER, BackendCapability.SERVER_SENT_EVENTS, BackendCapability.DATAFLOW_BUG_DETECTION,
+      BackendCapability.FULL_SYNCHRONIZATION);
+    if (telemetry != null && telemetry.enabled()) {
+      backendCapabilities.add(BackendCapability.TELEMETRY);
+    }
+    if (shouldEnableMonitoring()) {
+      backendCapabilities.add(BackendCapability.MONITORING);
+    }
+    if (initParams.isEnableSecurityHotspots()) {
+      backendCapabilities.add(BackendCapability.SECURITY_HOTSPOTS);
+    }
+    return backendCapabilities;
+  }
+
   boolean shouldEnableMonitoring() {
     var monitoringDisabledByProperty = "true".equals(System.getProperty(MONITORING_DISABLED_PROPERTY_KEY));
     if (monitoringDisabledByProperty) {

src/test/java/org/sonarsource/sonarlint/ls/backend/BackendServiceFacadeTests.java

@@ -19,15 +19,18 @@
  */
 package org.sonarsource.sonarlint.ls.backend;
 
-import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.Test;
 import org.sonarsource.sonarlint.core.rpc.client.SonarLintRpcClientDelegate;
+import org.sonarsource.sonarlint.core.rpc.protocol.backend.initialize.BackendCapability;
 import org.sonarsource.sonarlint.ls.SonarLintExtendedLanguageClient;
 import org.sonarsource.sonarlint.ls.log.LanguageClientLogger;
+import org.sonarsource.sonarlint.ls.telemetry.SonarLintTelemetry;
 
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.junit.jupiter.api.Assertions.assertThrows;
 import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
 import static org.sonarsource.sonarlint.ls.backend.BackendServiceFacade.MONITORING_DISABLED_PROPERTY_KEY;
 
 class BackendServiceFacadeTests {
@@ -37,8 +40,8 @@ class BackendServiceFacadeTests {
   SonarLintRpcClientDelegate backend = mock(SonarLintRpcClientDelegate.class);
   BackendServiceFacade underTest = new BackendServiceFacade(backend, mock(LanguageClientLogger.class), mock(SonarLintExtendedLanguageClient.class), 0);
 
-  @BeforeEach
-  void setUp() {
+  @AfterEach
+  void tearDown() {
     System.clearProperty(MONITORING_DISABLED_PROPERTY_KEY);
   }
 
@@ -92,4 +95,62 @@ void shouldEnableMonitoringWhenNotDisabled() {
     assertThat(result).isTrue();
   }
 
+  @Test
+  void shouldComputeBackendCapabilities() {
+    // make sure monitoring is disabled
+    System.setProperty(MONITORING_DISABLED_PROPERTY_KEY, "true");
+
+    // make sure telemetry is disabled
+    SonarLintTelemetry telemetryService = mock(SonarLintTelemetry.class);
+    underTest.setTelemetry(telemetryService);
+    when(telemetryService.enabled()).thenReturn(false);
+
+    var backendInitParams = mock(BackendInitParams.class);
+    when(backendInitParams.isEnableSecurityHotspots()).thenReturn(true);
+    var backendCapabilities = underTest.getBackendCapabilities(backendInitParams);
+
+    assertThat(backendCapabilities)
+      .isNotNull()
+      .isNotEmpty()
+      .contains(BackendCapability.SMART_NOTIFICATIONS)
+      .contains(BackendCapability.SECURITY_HOTSPOTS)
+      .contains(BackendCapability.PROJECT_SYNCHRONIZATION)
+      .contains(BackendCapability.EMBEDDED_SERVER)
+      .contains(BackendCapability.DATAFLOW_BUG_DETECTION)
+      .contains(BackendCapability.FULL_SYNCHRONIZATION)
+      .contains(BackendCapability.SERVER_SENT_EVENTS)
+      .doesNotContain(BackendCapability.TELEMETRY)
+      .doesNotContain(BackendCapability.MONITORING);
+
+  }
+
+  @Test
+  void shouldComputeBackendCapabilities_withTelemetryAndMonitoring() {
+    // make sure monitoring is disabled
+    System.setProperty(MONITORING_DISABLED_PROPERTY_KEY, "false");
+
+    // make sure telemetry is disabled
+    SonarLintTelemetry telemetryService = mock(SonarLintTelemetry.class);
+    underTest.setTelemetry(telemetryService);
+    when(telemetryService.enabled()).thenReturn(true);
+
+    var backendInitParams = mock(BackendInitParams.class);
+    when(backendInitParams.isEnableSecurityHotspots()).thenReturn(true);
+    var backendCapabilities = underTest.getBackendCapabilities(backendInitParams);
+
+    assertThat(backendCapabilities)
+      .isNotNull()
+      .isNotEmpty()
+      .contains(BackendCapability.SMART_NOTIFICATIONS)
+      .contains(BackendCapability.SECURITY_HOTSPOTS)
+      .contains(BackendCapability.PROJECT_SYNCHRONIZATION)
+      .contains(BackendCapability.EMBEDDED_SERVER)
+      .contains(BackendCapability.DATAFLOW_BUG_DETECTION)
+      .contains(BackendCapability.FULL_SYNCHRONIZATION)
+      .contains(BackendCapability.SERVER_SENT_EVENTS)
+      .contains(BackendCapability.TELEMETRY)
+      .contains(BackendCapability.MONITORING);
+
+  }
+
 }