MCP-79 Remove use of "appendIfMissing"

nquinquenel · nquinquenel · commit 5663ff6bd120 · 2025-07-23T15:15:05.000+02:00
diff --git a/src/main/java/org/sonarsource/sonarqube/mcp/serverapi/ServerApiHelper.java b/src/main/java/org/sonarsource/sonarqube/mcp/serverapi/ServerApiHelper.java
@@ -24,6 +24,7 @@
 import javax.annotation.CheckForNull;
 import javax.annotation.Nullable;
 import org.apache.commons.lang3.StringUtils;
+import org.apache.commons.lang3.Strings;
 import org.sonarsource.sonarqube.mcp.http.HttpClient;
 import org.sonarsource.sonarqube.mcp.serverapi.exception.ForbiddenException;
 import org.sonarsource.sonarqube.mcp.serverapi.exception.NotFoundException;
@@ -89,7 +90,7 @@ private String buildEndpointUrl(String relativePath) {
   }
 
   public static String concat(String baseUrl, String relativePath) {
-    return StringUtils.appendIfMissing(baseUrl, "/") +
+    return Strings.CS.appendIfMissing(baseUrl, "/") +
       (relativePath.startsWith("/") ? relativePath.substring(1) : relativePath);
   }
 

Original file line number	Diff line number	Diff line change
`@@ -24,6 +24,7 @@`
`24`	`24`	`import javax.annotation.CheckForNull;`
`25`	`25`	`import javax.annotation.Nullable;`
`26`	`26`	`import org.apache.commons.lang3.StringUtils;`
	`27`	`+import org.apache.commons.lang3.Strings;`
`27`	`28`	`import org.sonarsource.sonarqube.mcp.http.HttpClient;`
`28`	`29`	`import org.sonarsource.sonarqube.mcp.serverapi.exception.ForbiddenException;`
`29`	`30`	`import org.sonarsource.sonarqube.mcp.serverapi.exception.NotFoundException;`
`@@ -89,7 +90,7 @@ private String buildEndpointUrl(String relativePath) {`
`89`	`90`	`}`
`90`	`91`
`91`	`92`	`public static String concat(String baseUrl, String relativePath) {`
`92`		`- return StringUtils.appendIfMissing(baseUrl, "/") +`
	`93`	`+ return Strings.CS.appendIfMissing(baseUrl, "/") +`
`93`	`94`	`(relativePath.startsWith("/") ? relativePath.substring(1) : relativePath);`
`94`	`95`	`}`
`95`	`96`