Skip to content

Commit 310c6e3

Browse files
author
Janina Eriksson Bergström
committed
Added emit of unchoose event
1 parent cf0aba1 commit 310c6e3

9 files changed

+17
-16
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -300,8 +300,8 @@ methods: {
300300
301301
* Support for Sortable events:
302302
303-
`start`, `add`, `remove`, `update`, `end`, `choose`, `sort`, `filter`, `clone`<br>
304-
Events are called whenever onStart, onAdd, onRemove, onUpdate, onEnd, onChoose, onSort, onClone are fired by Sortable.js with the same argument.<br>
303+
`start`, `add`, `remove`, `update`, `end`, `choose`, `unchoose`, `sort`, `filter`, `clone`<br>
304+
Events are called whenever onStart, onAdd, onRemove, onUpdate, onEnd, onChoose, onUnchoose, onSort, onClone are fired by Sortable.js with the same argument.<br>
305305
[See here for reference](https://github.com/RubaXa/Sortable#event-object-demo)
306306
307307
Note that SortableJS OnMove callback is mapped with the [move prop](https://github.com/SortableJS/Vue.Draggable/blob/master/README.md#move)

dist/vuedraggable.common.js

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/vuedraggable.common.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/vuedraggable.umd.js

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/vuedraggable.umd.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/vuedraggable.umd.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/vuedraggable.umd.min.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/vuedraggable.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ function getComponentAttributes($attrs, componentData) {
8989
}
9090

9191
const eventsListened = ["Start", "Add", "Remove", "Update", "End"];
92-
const eventsToEmit = ["Choose", "Sort", "Filter", "Clone"];
92+
const eventsToEmit = ["Choose", "Unchoose", "Sort", "Filter", "Clone"];
9393
const readonlyProperties = ["Move", ...eventsListened, ...eventsToEmit].map(
9494
evt => "on" + evt
9595
);

tests/unit/vuedraggable.spec.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -289,6 +289,7 @@ describe("draggable.vue when initialized with list", () => {
289289
test.each(
290290
[
291291
["onChoose", "choose"],
292+
["onUnchoose", "unchoose"],
292293
["onSort", "sort"],
293294
["onFilter", "filter"],
294295
["onClone", "clone"]
@@ -736,7 +737,7 @@ describe("draggable.vue when initialized with list", () => {
736737
}
737738
);
738739

739-
test.each(["Start", "Add", "Remove", "Update", "End", "Choose", "Sort", "Filter", "Clone", "Move"])
740+
test.each(["Start", "Add", "Remove", "Update", "End", "Choose", "Unchoose", "Sort", "Filter", "Clone", "Move"])
740741
("do not call option when updating option on%s",
741742
(callBack) => {
742743
vm.$attrs = { [`on${callBack}`]: jest.fn() };

0 commit comments

Comments
 (0)