Skip to content

Commit 6e84c2f

Browse files
Improving tests
1 parent 44a5daa commit 6e84c2f

File tree

2 files changed

+22
-4
lines changed

2 files changed

+22
-4
lines changed

src/vuedraggable.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ const props = {
121121
const draggableComponent = {
122122
name: "draggable",
123123

124-
inheritAttrs: true,
124+
inheritAttrs: false,
125125

126126
props,
127127

tests/unit/vuedraggable.spec.js

Lines changed: 21 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,19 @@ let wrapper;
1111
let vm;
1212
let props;
1313
let items;
14-
let html;
14+
let element;
1515

1616
describe("draggable.vue", () => {
1717
beforeEach(() => {
18+
Sortable.mockClear();
1819
items = ["a", "b", "c"];
1920
wrapper = shallowMount(draggable, {
2021
propsData: {
2122
list: items
2223
},
24+
attrs: {
25+
sortableOption: "value"
26+
},
2327
slots: {
2428
default: items.map(item => `<div>${item}</div>`),
2529
header: "<header/>",
@@ -28,13 +32,17 @@ describe("draggable.vue", () => {
2832
});
2933
vm = wrapper.vm;
3034
props = vm.$options.props;
31-
html = wrapper.element;
35+
element = wrapper.element;
3236
});
3337

34-
it("should instantiate without error", () => {
38+
it("instantiate without error", () => {
3539
expect(wrapper).not.toBeUndefined();
3640
});
3741

42+
it("has draggable name", () => {
43+
expect(vm.name).not.toBe("draggable");
44+
});
45+
3846
test.each([
3947
["options", { type: Object }],
4048
["list", {
@@ -117,4 +125,14 @@ describe("draggable.vue", () => {
117125
it("keeps a reference to Sortable instance", () => {
118126
expect(vm._sortable).toBe(SortableFake);
119127
})
128+
129+
it("creates sortable instance with options", () => {
130+
expect(Sortable.mock.calls.length).toBe(1);
131+
const parameters = Sortable.mock.calls[0];
132+
expect(parameters[0]).toBe(element);
133+
expect(parameters[1]).toMatchObject({
134+
draggable: ">*",
135+
sortableOption: "value"
136+
});
137+
})
120138
});

0 commit comments

Comments
 (0)