Skip to content

Commit bf93b66

Browse files
Fix Issue #156 + always default draggable option to '>*' (issue #105)
1 parent 5f57990 commit bf93b66

File tree

3 files changed

+13
-17
lines changed

3 files changed

+13
-17
lines changed

dist/vuedraggable.js

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,4 @@
11
'use strict';
2-
3-
var _typeof = typeof Symbol === "function" && typeof Symbol.iterator === "symbol" ? function (obj) { return typeof obj; } : function (obj) { return obj && typeof Symbol === "function" && obj.constructor === Symbol && obj !== Symbol.prototype ? "symbol" : typeof obj; };
4-
52
var _extends = Object.assign || function (target) { for (var i = 1; i < arguments.length; i++) { var source = arguments[i]; for (var key in source) { if (Object.prototype.hasOwnProperty.call(source, key)) { target[key] = source[key]; } } } return target; };
63

74
function _toConsumableArray(arr) { if (Array.isArray(arr)) { for (var i = 0, arr2 = Array(arr.length); i < arr.length; i++) { arr2[i] = arr[i]; } return arr2; } else { return Array.from(arr); } }
@@ -133,9 +130,10 @@ function _toConsumableArray(arr) { if (Array.isArray(arr)) { for (var i = 0, arr
133130
optionsAdded['on' + elt] = emit.bind(_this3, elt);
134131
});
135132

136-
var options = _extends({}, this.options, optionsAdded, { onMove: function onMove(evt) {
137-
return _this3.onDragMove(evt);
133+
var options = _extends({}, this.options, optionsAdded, { onMove: function onMove(evt, originalEvent) {
134+
return _this3.onDragMove(evt, originalEvent);
138135
} });
136+
!('draggable' in options) && (options.draggable = '>*');
139137
this._sortable = new Sortable(this.rootContainer, options);
140138
this.computeIndexes();
141139
},
@@ -315,11 +313,9 @@ function _toConsumableArray(arr) { if (Array.isArray(arr)) { for (var i = 0, arr
315313
var currentDOMIndex = domChildren.indexOf(evt.related);
316314
var currentIndex = relatedContext.component.getVmIndex(currentDOMIndex);
317315
var draggedInList = domChildren.indexOf(draggingElement) != -1;
318-
console.log(draggedInList, evt.willInsertAfter, currentDOMIndex, currentIndex);
319-
// return (draggedInList || !evt.willInsertAfter) ? currentIndex : currentIndex + 1
320-
return evt.willInsertAfter ? currentIndex + 1 : currentIndex;
316+
return draggedInList || !evt.willInsertAfter ? currentIndex : currentIndex + 1;
321317
},
322-
onDragMove: function onDragMove(evt) {
318+
onDragMove: function onDragMove(evt, originalEvent) {
323319
var onMove = this.move;
324320
if (!onMove || !this.realList) {
325321
return true;
@@ -330,7 +326,7 @@ function _toConsumableArray(arr) { if (Array.isArray(arr)) { for (var i = 0, arr
330326
var futureIndex = this.computeFutureIndex(relatedContext, evt);
331327
_extends(draggedContext, { futureIndex: futureIndex });
332328
_extends(evt, { relatedContext: relatedContext, draggedContext: draggedContext });
333-
return onMove(evt);
329+
return onMove(evt, originalEvent);
334330
},
335331
onDragEnd: function onDragEnd(evt) {
336332
this.computeIndexes();
@@ -341,7 +337,7 @@ function _toConsumableArray(arr) { if (Array.isArray(arr)) { for (var i = 0, arr
341337
return draggableComponent;
342338
}
343339

344-
if ((typeof exports === 'undefined' ? 'undefined' : _typeof(exports)) == "object") {
340+
if (typeof exports == "object") {
345341
var Sortable = require("sortablejs");
346342
module.exports = buildDraggable(Sortable);
347343
} else if (typeof define == "function" && define.amd) {

dist/vuedraggable.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/vuedraggable.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,8 @@
109109
optionsAdded['on' + elt] = emit.bind(this, elt)
110110
});
111111

112-
const options = Object.assign({}, this.options, optionsAdded, { onMove: evt => { return this.onDragMove(evt); } })
112+
const options = Object.assign({}, this.options, optionsAdded, { onMove: (evt, originalEvent) => { return this.onDragMove(evt, originalEvent); } })
113+
!('draggable' in options) && (options.draggable = '>*');
113114
this._sortable = new Sortable(this.rootContainer, options)
114115
this.computeIndexes()
115116
},
@@ -290,11 +291,10 @@
290291
const currentDOMIndex = domChildren.indexOf(evt.related)
291292
const currentIndex = relatedContext.component.getVmIndex(currentDOMIndex)
292293
const draggedInList = domChildren.indexOf(draggingElement) != -1
293-
console.log(draggedInList, evt.willInsertAfter, currentDOMIndex, currentIndex)
294-
return (draggedInList || !evt.willInsertAfter) ? currentIndex : currentIndex + 1
294+
return (draggedInList || !evt.willInsertAfter) ? currentIndex : currentIndex + 1
295295
},
296296

297-
onDragMove(evt) {
297+
onDragMove(evt, originalEvent) {
298298
const onMove = this.move
299299
if (!onMove || !this.realList) {
300300
return true
@@ -305,7 +305,7 @@
305305
const futureIndex = this.computeFutureIndex(relatedContext, evt)
306306
Object.assign(draggedContext, { futureIndex })
307307
Object.assign(evt, { relatedContext, draggedContext })
308-
return onMove(evt)
308+
return onMove(evt, originalEvent)
309309
},
310310

311311
onDragEnd(evt) {

0 commit comments

Comments
 (0)