Skip to content

Commit e354679

Browse files
author
pc-david\david.desmaisons
committed
Update to Sortable 1.5.0 clone breaking change
1 parent f6950c3 commit e354679

File tree

4 files changed

+12
-7
lines changed

4 files changed

+12
-7
lines changed

dist/vuedraggable.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,9 @@ function _toConsumableArray(arr) { if (Array.isArray(arr)) { for (var i = 0, arr
120120
computed: {
121121
rootContainer: function rootContainer() {
122122
return this.transitionMode ? this.$el.children[0] : this.$el;
123+
},
124+
isCloning: function isCloning() {
125+
return this.options !== null && this.options.group !== null && this.options.group.pull === 'clone';
123126
}
124127
},
125128

@@ -217,8 +220,7 @@ function _toConsumableArray(arr) { if (Array.isArray(arr)) { for (var i = 0, arr
217220
},
218221
onDragRemove: function onDragRemove(evt) {
219222
insertNodeAt(this.rootContainer, evt.item, evt.oldIndex);
220-
var isCloning = !!evt.clone;
221-
if (isCloning) {
223+
if (this.isCloning) {
222224
removeNode(evt.clone);
223225
return;
224226
}

dist/vuedraggable.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "vuedraggable",
3-
"version": "2.8.3-rc0",
3+
"version": "2.8.4",
44
"description": "draggable component for vue",
55
"main": "dist/vuedraggable.js",
66
"files": [
@@ -18,7 +18,7 @@
1818
"test": "test"
1919
},
2020
"dependencies": {
21-
"sortablejs": "^1.5.0-rc1"
21+
"sortablejs": "^1.5.0"
2222
},
2323
"devDependencies": {
2424
"babel-plugin-transform-object-assign": "^6.22.0",

src/vuedraggable.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,10 @@
102102
computed : {
103103
rootContainer () {
104104
return this.transitionMode? this.$el.children[0] : this.$el;
105+
},
106+
107+
isCloning () {
108+
return (this.options!==null) && (this.options.group !== null) && (this.options.group.pull === 'clone')
105109
}
106110
},
107111

@@ -200,8 +204,7 @@
200204

201205
onDragRemove (evt) {
202206
insertNodeAt(this.rootContainer, evt.item, evt.oldIndex)
203-
const isCloning = !!evt.clone
204-
if (isCloning) {
207+
if (this.isCloning) {
205208
removeNode(evt.clone)
206209
return
207210
}

0 commit comments

Comments
 (0)