Skip to content

Commit 7b0182f

Browse files
marcgraubhaarts
authored andcommitted
Updated the library to follow good practices on library organization, added compatibility with browser (#14)
* Updated the library to follow good practices on library organization * Updated imports to comply with https://dart-lang.github.io/linter/lints/avoid_relative_lib_imports.html * Fix format
1 parent 60bb23f commit 7b0182f

12 files changed

+51
-31
lines changed

lib/logger.dart

Lines changed: 13 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,19 @@
11
/// Small, easy to use and extensible logger which prints beautiful logs.
22
library logger;
33

4-
import 'dart:collection';
5-
import 'dart:convert';
6-
import 'dart:io';
4+
export 'src/ansi_color.dart';
75

8-
import 'src/ansi_color.dart';
6+
export 'src/filters/debug_filter.dart';
7+
export 'src/filters/production_filter.dart';
8+
export 'src/outputs/console_output.dart';
9+
export 'src/outputs/memory_output.dart';
10+
export 'src/printers/pretty_printer.dart';
11+
export 'src/printers/simple_printer.dart';
912

10-
part 'src/filters/debug_filter.dart';
11-
part 'src/filters/production_filter.dart';
12-
part 'src/outputs/console_output.dart';
13-
part 'src/outputs/file_output.dart';
14-
part 'src/outputs/memory_output.dart';
15-
part 'src/printers/pretty_printer.dart';
16-
part 'src/printers/simple_printer.dart';
13+
export 'src/log_output.dart'
14+
if (dart.library.io) 'src/outputs/file_output.dart';
1715

18-
part 'src/log_filter.dart';
19-
part 'src/log_output.dart';
20-
part 'src/log_printer.dart';
21-
part 'src/logger.dart';
16+
export 'src/log_filter.dart';
17+
export 'src/log_output.dart';
18+
export 'src/log_printer.dart';
19+
export 'src/logger.dart';

lib/src/filters/debug_filter.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
part of logger;
1+
import 'package:logger/src/logger.dart';
2+
import 'package:logger/src/log_filter.dart';
23

34
/// Default implementation of [LogFilter].
45
///

lib/src/filters/production_filter.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
part of logger;
1+
import 'package:logger/src/logger.dart';
2+
import 'package:logger/src/log_filter.dart';
23

34
/// Prints all logs with `level >= Logger.level` even in production.
45
class ProductionFilter extends LogFilter {

lib/src/log_filter.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
part of logger;
1+
import 'package:logger/src/logger.dart';
22

33
/// An abstract filter of log messages.
44
///

lib/src/log_output.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
part of logger;
1+
import 'package:logger/src/logger.dart';
22

33
/// Log output receives a [OutputEvent] from [LogPrinter] and sends it to the
44
/// desired destination.

lib/src/log_printer.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
part of logger;
1+
import 'package:logger/src/logger.dart';
22

33
/// An abstract handler of log events.
44
///
@@ -8,7 +8,7 @@ part of logger;
88
///
99
/// You can implement a `LogPrinter` from scratch or extend [PrettyPrinter].
1010
abstract class LogPrinter {
11-
List<String> _buffer;
11+
List<String> buffer;
1212

1313
void init() {}
1414

@@ -20,6 +20,6 @@ abstract class LogPrinter {
2020

2121
/// Sends a line to the [LogOutput].
2222
void println(String line) {
23-
_buffer.add(line);
23+
buffer.add(line);
2424
}
2525
}

lib/src/logger.dart

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,9 @@
1-
part of logger;
1+
import 'package:logger/src/filters/debug_filter.dart';
2+
import 'package:logger/src/printers/pretty_printer.dart';
3+
import 'package:logger/src/outputs/console_output.dart';
4+
import 'package:logger/src/log_filter.dart';
5+
import 'package:logger/src/log_printer.dart';
6+
import 'package:logger/src/log_output.dart';
27

38
/// [Level]s to control logging output. Logging can be enabled to include all
49
/// levels above certain [Level].
@@ -61,8 +66,8 @@ class Logger {
6166
_printer = printer ?? PrettyPrinter(),
6267
_output = output ?? ConsoleOutput() {
6368
_filter.init();
69+
_printer.buffer = _outputBuffer;
6470
_filter.level = level ?? Logger.level;
65-
_printer._buffer = _outputBuffer;
6671
_printer.init();
6772
_output.init();
6873
}
@@ -121,7 +126,7 @@ class Logger {
121126
}
122127
_output.output(outputEvent);
123128
_outputBuffer = [];
124-
_printer._buffer = _outputBuffer;
129+
_printer.buffer = _outputBuffer;
125130
}
126131
}
127132
}
@@ -132,7 +137,7 @@ class Logger {
132137
_outputBuffer = null;
133138
_filter.destroy();
134139
_printer.destroy();
135-
_printer._buffer = null;
140+
_printer.buffer = null;
136141
_output.destroy();
137142
}
138143

lib/src/outputs/console_output.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
part of logger;
1+
import 'package:logger/src/logger.dart';
2+
import 'package:logger/src/log_output.dart';
23

34
/// Default implementation of [LogOutput].
45
///

lib/src/outputs/file_output.dart

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,8 @@
1-
part of logger;
1+
import 'dart:convert';
2+
import 'dart:io';
3+
4+
import 'package:logger/src/logger.dart';
5+
import 'package:logger/src/log_output.dart';
26

37
/// Writes the log output to a file.
48
class FileOutput extends LogOutput {

lib/src/outputs/memory_output.dart

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
1-
part of logger;
1+
import 'dart:collection';
2+
3+
import 'package:logger/src/logger.dart';
4+
import 'package:logger/src/log_output.dart';
25

36
/// Buffers [OutputEvent]s.
47
class MemoryOutput extends LogOutput {

0 commit comments

Comments
 (0)