Make fault.Wrap nil tolerant #20

Author: Southclaws

fault.go

@@ -18,7 +18,7 @@ type Wrapper func(err error) error
 // Wrap wraps an error with all of the wrappers provided.
 func Wrap(err error, w ...Wrapper) error {
 	if err == nil {
-		panic("nil error passed to Wrap")
+		return nil
 	}
 
 	for _, fn := range w {

fctx/fctx.go

@@ -90,7 +90,7 @@ func WithMeta(ctx context.Context, kv ...string) context.Context {
 //	}
 func Wrap(err error, ctx context.Context, kv ...string) error {
 	if err == nil {
-		panic("nil error passed to Wrap")
+		return nil
 	}
 
 	meta, ok := ctx.Value(contextKey{}).(map[string]string)

fmsg/fmsg.go

@@ -23,7 +23,7 @@ type withMessage struct {
 // punctuation and grammar and end the message with a period.
 func Wrap(err error, internal, external string) error {
 	if err == nil {
-		panic("nil error passed to Wrap")
+		return nil
 	}
 
 	return &withMessage{

ftag/ftag.go

@@ -20,7 +20,7 @@ func (e *withKind) String() string { return e.Error() }
 // Wrap wraps an error and gives it a distinct tag.
 func Wrap(parent error, k Kind) error {
 	if parent == nil {
-		panic("nil error passed to Wrap")
+		return nil
 	}
 
 	if k == "" {

tests/fmsg_test.go

@@ -2,7 +2,6 @@ package tests
 
 import (
 	"errors"
-	"fmt"
 	"testing"
 
 	"github.com/Southclaws/fault/fmsg"
@@ -45,10 +44,3 @@ func TestWithManySlice(t *testing.T) {
 	assert.Len(t, out, 3)
 	assert.Equal(t, []string{"Your reply draft has been saved however we could not publish it.", "Unable to reply to post.", "The post was not found."}, out)
 }
-
-func TestNil(t *testing.T) {
-	assert.Panics(t, func() {
-		err := fmsg.Wrap(nil, "oh no", ":(")
-		fmt.Println(err)
-	})
-}

tests/ftag_test.go

@@ -26,9 +26,3 @@ func TestWrapWithKindChanging(t *testing.T) {
 
 	assert.Equal(t, ftag.NotFound, out, "Should always pick the most recent kind from an error chain.")
 }
-
-func TestWrapNil(t *testing.T) {
-	assert.Panics(t, func() {
-		ftag.Wrap(nil, ftag.NotFound)
-	})
-}