test moving t.Errorf to t.Error

Signed-off-by: Jan Schoone <[email protected]>

Author: jschoone

internal/controller/clusterstack_controller_test.go

@@ -117,11 +117,11 @@ func TestMakeDiff(t *testing.T) {
 	expectedToDelete := []*csov1alpha1.ClusterStackRelease{csr1}
 
 	if !reflect.DeepEqual(toString(toCreate), toString(expectedToCreate)) {
-		t.Errorf("toCreate is not as expected")
+		t.Error("toCreate is not as expected")
 	}
 
 	if !reflect.DeepEqual(toString(toDelete), toString(expectedToDelete)) {
-		t.Errorf("toDelete is not as expected")
+		t.Error("toDelete is not as expected")
 	}
 
 	// Test Case 2:
@@ -146,11 +146,11 @@ func TestMakeDiff(t *testing.T) {
 	expectedToDelete = []*csov1alpha1.ClusterStackRelease{csr1, csr2}
 
 	if !reflect.DeepEqual(toString(toCreate), toString(expectedToCreate)) {
-		t.Errorf("toCreate is not as expected. Expected %v, got %v", toString(expectedToCreate), toString(toCreate))
+		t.Erro("toCreate is not as expected. Expected %v, got %v", toString(expectedToCreate), toString(toCreate))
 	}
 
 	if !reflect.DeepEqual(toString(toDelete), toString(expectedToDelete)) {
-		t.Errorf("toDelete is not as expected. Expected %v, got %v", toString(expectedToDelete), toString(toDelete))
+		t.Erro("toDelete is not as expected. Expected %v, got %v", toString(expectedToDelete), toString(toDelete))
 	}
 
 	// Test Case 3
@@ -172,11 +172,11 @@ func TestMakeDiff(t *testing.T) {
 	expectedToDelete = []*csov1alpha1.ClusterStackRelease{csr1, csr2}
 
 	if !reflect.DeepEqual(toString(toCreate), toString(expectedToCreate)) {
-		t.Errorf("toCreate is not as expected. Expected %v, got %v", toString(expectedToCreate), toString(toCreate))
+		t.Erro("toCreate is not as expected. Expected %v, got %v", toString(expectedToCreate), toString(toCreate))
 	}
 
 	if !reflect.DeepEqual(toString(toDelete), toString(expectedToDelete)) {
-		t.Errorf("toDelete is not as expected. Expected %v, got %v", toString(expectedToDelete), toString(toDelete))
+		t.Erro("toDelete is not as expected. Expected %v, got %v", toString(expectedToDelete), toString(toDelete))
 	}
 }
 
@@ -235,17 +235,17 @@ func TestGetLatestReadyClusterStackRelease(t *testing.T) {
 		// Call the function being tested
 		latest, k8sVersion, err := getLatestReadyClusterStackRelease(clusterStackReleases)
 		if err != nil {
-			t.Errorf("Expected err to be nil, but got: %v", err)
+			t.Error("Expected err to be nil, but got: %v", err)
 		}
 		expectedLatest := "docker-ferrol-1-21-v3"
 		if latest == nil {
-			t.Errorf("Expected latest to be non-nil, but got nil")
+			t.Error("Expected latest to be non-nil, but got nil")
 		} else if *latest != expectedLatest {
-			t.Errorf("Expected latest to be %s, but got %s", expectedLatest, *latest)
+			t.Error("Expected latest to be %s, but got %s", expectedLatest, *latest)
 		}
 		expectedK8sVersion := "v1.21"
 		if k8sVersion != expectedK8sVersion {
-			t.Errorf("Expected k8sVersion to be %s, but got %s", expectedK8sVersion, k8sVersion)
+			t.Error("Expected k8sVersion to be %s, but got %s", expectedK8sVersion, k8sVersion)
 		}
 	})
 
@@ -257,13 +257,13 @@ func TestGetLatestReadyClusterStackRelease(t *testing.T) {
 
 		latest, k8sVersion, err := getLatestReadyClusterStackRelease(emptyClusterStackReleases)
 		if err != nil {
-			t.Errorf("Expected err to be nil, but got: %v", err)
+			t.Error("Expected err to be nil, but got: %v", err)
 		}
 		if latest != nil {
-			t.Errorf("Expected latest to be nil, but got %v", *latest)
+			t.Error("Expected latest to be nil, but got %v", *latest)
 		}
 		if k8sVersion != "" {
-			t.Errorf("Expected k8sVersion to be an empty string, but got %s", k8sVersion)
+			t.Error("Expected k8sVersion to be an empty string, but got %s", k8sVersion)
 		}
 	})
 }
@@ -323,15 +323,15 @@ func TestGetUsableClusterStackReleaseVersions(t *testing.T) {
 		// Call the function
 		usableVersions, err := getUsableClusterStackReleaseVersions(clusterStackReleases)
 		if err != nil {
-			t.Errorf("Expected no error, but got %v", err)
+			t.Error("Expected no error, but got %v", err)
 		}
 
 		// Expected result
 		expectedVersions := []string{"v1", "v3"}
 
 		// Check if the result matches the expected versions
 		if !equalStringSlices(usableVersions, expectedVersions) {
-			t.Errorf("Expected versions %v, but got %v", expectedVersions, usableVersions)
+			t.Error("Expected versions %v, but got %v", expectedVersions, usableVersions)
 		}
 	})
 
@@ -341,15 +341,15 @@ func TestGetUsableClusterStackReleaseVersions(t *testing.T) {
 		// Call the function
 		usableVersions, err := getUsableClusterStackReleaseVersions(nil)
 		if err != nil {
-			t.Errorf("Expected no error, but got %v", err)
+			t.Error("Expected no error, but got %v", err)
 		}
 
 		// Expected result
 		expectedVersions := []string{}
 
 		// Check if the result matches the expected versions
 		if !equalStringSlices(usableVersions, expectedVersions) {
-			t.Errorf("Expected versions %v, but got %v", expectedVersions, usableVersions)
+			t.Error("Expected versions %v, but got %v", expectedVersions, usableVersions)
 		}
 	})
 }
@@ -374,7 +374,7 @@ func TestGetClusterStackReleasesInSpec(t *testing.T) {
 	// check if all the three versions given in the spec are present in the result
 	for k := range result {
 		if _, ok := expectedResult[k]; !ok {
-			t.Errorf("Expected result %v, not found", k)
+			t.Error("Expected result %v, not found", k)
 		}
 	}
 }