Skip to content

Commit 849eeaa

Browse files
author
kranurag7
committed
fix upgrade builder image script
when I initially worked on this, this was hardcoded and we were using grep + sed combination to get version. Later we switched to track version by using a file at the root of the repo. The file was .builder-image-version.txt, this was a bug where we were still reading from Makefile hardcoded version. This commit fixes the same and switches to new method where we read from .builder-image-version.txt Signed-off-by: kranurag7 <[email protected]>
1 parent 2096045 commit 849eeaa

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

hack/upgrade-builder-image.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ if [ "${CI:-false}" = true ] ; then
3535
echo $BUILD_IMAGE_TOKEN | docker login ghcr.io -u $BUILD_IMAGE_USER --password-stdin
3636
fi
3737

38-
export VERSION=$(git fetch --quiet origin main && git show origin/main:Makefile | grep "BUILDER_IMAGE_VERSION :=" | sed 's/.*BUILDER_IMAGE_VERSION := //' | sed 's/\s.*$//' )
38+
export VERSION=$(git fetch --quiet origin main && git show origin/main:.builder-image-version.txt)
3939
export NEW_VERSION=$(semver_upgrade patch ${VERSION})
4040

4141
if docker manifest inspect ghcr.io/sovereigncloudstack/cso-builder:${VERSION} > /dev/null ; echo $?; then

0 commit comments

Comments
 (0)