Skip to content

Commit 743057f

Browse files
authored
update build workflow (#129)
we had a check for build but that was triggering when we merged a PR on main branch and I don't think that's useful. We still had failures even after that check. This commits adds the same check to pr-lint workflow and removes the build workflow that runs when a PR gets merged into main branch. The reason to run it as part of lint workflow was because we have go installed as part of this workflow. We now also run it before we lint the codebase, this makes sure that we run the build first followed by linting the codebase. Signed-off-by: kranurag7 <[email protected]>
1 parent dbc8f12 commit 743057f

File tree

2 files changed

+3
-22
lines changed

2 files changed

+3
-22
lines changed

.github/workflows/build.yml

Lines changed: 0 additions & 22 deletions
This file was deleted.

.github/workflows/pr-lint.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,9 @@ jobs:
3434
shell: bash
3535
run: git config --global --add safe.directory "$GITHUB_WORKSPACE"
3636

37+
- name: Build the Binary
38+
run: make build
39+
3740
- name: Verify Golang Modules
3841
run: make BUILD_IN_CONTAINER=false generate-modules-ci
3942

0 commit comments

Comments
 (0)