Use errors.New instead of fmt.Errorf for plain strings.

This is what go-1.22 enforces.

Signed-off-by: Kurt Garloff <kurt@garloff.de>

Author: garloff

pkg/clusterstack/config.go

@@ -58,11 +58,11 @@ func GetCsctlConfig(path string) (*CsctlConfig, error) {
 	}
 
 	if cs.Config.Provider.Type == "" {
-		return nil, fmt.Errorf("provider type must not be empty")
+		return nil, errors.New("provider type must not be empty")
 	}
 
 	if len(cs.Config.Provider.Type) > 253 {
-		return nil, fmt.Errorf("provider name must not be greater than 253")
+		return nil, errors.New("provider name must not be greater than 253")
 	}
 
 	match, err := regexp.MatchString(`^[a-z0-9]([-a-z0-9]*[a-z0-9])?$`, cs.Config.Provider.Type)
@@ -74,7 +74,7 @@ func GetCsctlConfig(path string) (*CsctlConfig, error) {
 	}
 
 	if cs.Config.ClusterStackName == "" {
-		return nil, fmt.Errorf("cluster stack name must not be empty")
+		return nil, errors.New("cluster stack name must not be empty")
 	}
 
 	// Validate kubernetes version

pkg/clusterstack/version.go

@@ -30,7 +30,7 @@ func BumpVersion(version string) (string, error) {
 
 	// Check if a numeric part was found
 	if len(matches) < 2 {
-		return "", fmt.Errorf("invalid version format")
+		return "", errors.New("invalid version format")
 	}
 
 	// Extract and convert the numeric part to an integer

pkg/cmd/create.go

@@ -185,13 +185,13 @@ func GetCreateOptions(ctx context.Context, clusterStackPath string) (*CreateOpti
 		}
 	case customMode:
 		if clusterStackVersion == "" {
-			return nil, fmt.Errorf("please specify a semver for custom version with --cluster-stack-version flag")
+			return nil, errors.New("please specify a semver for custom version with --cluster-stack-version flag")
 		}
 		if clusterAddonVersion == "" {
-			return nil, fmt.Errorf("please specify a semver for custom version with --cluster-addon-version flag")
+			return nil, errors.New("please specify a semver for custom version with --cluster-addon-version flag")
 		}
 		if nodeImageVersion == "" {
-			return nil, fmt.Errorf("please specify a semver for custom version with --node-image-version flag")
+			return nil, errors.New("please specify a semver for custom version with --node-image-version flag")
 		}
 
 		createOption.Metadata, err = clusterstack.HandleCustomMode(createOption.Config.Config.KubernetesVersion, clusterStackVersion, clusterAddonVersion, nodeImageVersion)
@@ -222,7 +222,7 @@ func createAction(cmd *cobra.Command, args []string) error {
 	defer cleanTmpDirectory()
 
 	if len(args) != 1 {
-		return fmt.Errorf("please provide a valid command, create only accept one argument to path to the cluster stacks")
+		return errors.New("please provide a valid command, create only accept one argument to path to the cluster stacks")
 	}
 	clusterStackPath := args[0]
 
@@ -253,7 +253,7 @@ func (c *CreateOptions) validateHash() error {
 	if c.CurrentReleaseHash.ClusterAddonDir == c.LatestReleaseHash.ClusterAddonDir &&
 		c.CurrentReleaseHash.ClusterAddonValues == c.LatestReleaseHash.ClusterAddonValues &&
 		c.CurrentReleaseHash.NodeImageDir == c.LatestReleaseHash.NodeImageDir {
-		return fmt.Errorf("no change in the cluster stack")
+		return errors.New("no change in the cluster stack")
 	}
 
 	return nil
@@ -351,7 +351,7 @@ func (c *CreateOptions) generateRelease(ctx context.Context) error {
 
 	if publish {
 		if remote != "oci" {
-			return fmt.Errorf("not pushing assets. --publish is only implemented for remote OCI")
+			return errors.New("not pushing assets. --publish is only implemented for remote OCI")
 		}
 
 		ociClient, err := oci.NewClient()
@@ -410,7 +410,7 @@ func overwriteVersionInFile(chartYaml, newVersion string) error {
 	v := m["version"]
 	oldVersion, ok := v.(string)
 	if !ok {
-		return fmt.Errorf("failed to read version in yaml")
+		return errors.New("failed to read version in yaml")
 	}
 
 	m["version"] = newVersion

pkg/hash/hash.go

@@ -111,7 +111,7 @@ func (r ReleaseHash) ValidateWithLatestReleaseHash(latestReleaseHash ReleaseHash
 	if r.ClusterAddonDir == latestReleaseHash.ClusterAddonDir &&
 		r.ClusterAddonValues == latestReleaseHash.ClusterAddonValues &&
 		r.NodeImageDir == latestReleaseHash.NodeImageDir {
-		return fmt.Errorf("no change in the cluster stack")
+		return errors.New("no change in the cluster stack")
 	}
 
 	return nil