fix linter

Signed-off-by: Jan Schoone <[email protected]>

Author: jschoone

pkg/assetsclient/github/client.go

@@ -78,7 +78,7 @@ func (c *realGhClient) ListRelease(ctx context.Context) ([]string, error) {
 		return nil, fmt.Errorf("failed to list releases: %w", err)
 	}
 
-	if response != nil && response.StatusCode != 200 {
+	if response != nil && response.StatusCode != http.StatusOK {
 		return nil, fmt.Errorf("got unexpected status from call to remote repository: %s", response.Status)
 	}
 
@@ -111,7 +111,7 @@ func (c *realGhClient) DownloadReleaseAssets(ctx context.Context, tag, path stri
 		return fmt.Errorf("failed to fetch release tag %s with status code %d: %w", tag, response.StatusCode, err)
 	}
 
-	if err := os.MkdirAll(path, os.ModePerm); err != nil {
+	if err := os.MkdirAll(path, 0o750); err != nil {
 		return fmt.Errorf("failed to create destination directory: %w", err)
 	}
 	// Extract the release assets

pkg/cmd/create.go

@@ -260,7 +260,7 @@ func (c *CreateOptions) validateHash() error {
 }
 
 func (c *CreateOptions) generateRelease(ctx context.Context) error {
-	if err := os.MkdirAll(c.ClusterStackReleaseDir, os.ModePerm); err != nil {
+	if err := os.MkdirAll(c.ClusterStackReleaseDir, 0o750); err != nil {
 		return fmt.Errorf("failed to create output directory: %w", err)
 	}
 	fmt.Printf("Creating output in %s\n", c.ClusterStackReleaseDir)

pkg/template/template.go

@@ -48,7 +48,7 @@ func visitFile(src, dst, path string, info os.FileInfo, meta *csctlclusterstack.
 
 	destPath := filepath.Join(dst, relativePath)
 	if info.IsDir() {
-		if err := os.MkdirAll(destPath, os.ModePerm); err != nil {
+		if err := os.MkdirAll(destPath, 0o750); err != nil {
 			return fmt.Errorf("failed to create directory: %w", err)
 		}
 		return nil
@@ -70,7 +70,7 @@ func visitFile(src, dst, path string, info os.FileInfo, meta *csctlclusterstack.
 		".NodeImageVersion":    meta.Versions.Components.NodeImage,
 	})
 
-	if err := os.WriteFile(destPath, []byte(output), os.ModePerm); err != nil {
+	if err := os.WriteFile(destPath, []byte(output), 0o600); err != nil {
 		return fmt.Errorf("failed to write file: %w", err)
 	}