Return representive state data for module migrate_osd_pools

Signed-off-by: Tobias Wolf <[email protected]>

Author: NotTheEvilOne

src/rookify/modules/migrate_osd_pools/main.py

@@ -1,6 +1,7 @@
 # -*- coding: utf-8 -*-
 
-from typing import Any, Dict
+from collections import OrderedDict
+from typing import Any, Dict, List
 from ..machine import Machine
 from ..module import ModuleHandler
 
@@ -14,8 +15,12 @@ class MigrateOSDPoolsHandler(ModuleHandler):
     ]
 
     def execute(self) -> None:
-        state_data = self.machine.get_preflight_state("AnalyzeCephHandler").data
+        pools = self._get_filtered_osd_pools_list()
+
+        for pool in pools:
+            self._migrate_pool(pool)
 
+    def _get_filtered_osd_pools_list(self) -> List[Dict[str, Any]]:
         migrated_mds_pools = self.machine.get_execution_state_data(
             name="MigrateMdsPoolsHandler", tag="migrated_pools", default_value=[]
         )
@@ -25,6 +30,8 @@ def execute(self) -> None:
 
         migrated_pools = migrated_mds_pools + migrated_rgw_pools
 
+        state_data = self.machine.get_preflight_state("AnalyzeCephHandler").data
+
         osd_pool_configurations = self.ceph.get_osd_pool_configurations_from_osd_dump(
             state_data["osd"]["dump"]
         )
@@ -38,8 +45,25 @@ def execute(self) -> None:
             ):
                 pools.append(pool)
 
+        return pools
+
+    def get_readable_key_value_state(self) -> Dict[str, str]:
+        migrated_pools = self.machine.get_execution_state_data(
+            "MigrateOSDPoolsHandler", "migrated_pools", default_value=[]
+        )
+
+        pools = self._get_filtered_osd_pools_list()
+
+        kv_state_data = OrderedDict()
+
         for pool in pools:
-            self._migrate_pool(pool)
+            key_name = "ceph OSD pool {0}".format(pool["pool_name"])
+            kv_state_data[key_name] = self._get_readable_json_dump(pool)
+
+            key_name = "ceph OSD pool {0} is created".format(pool["pool_name"])
+            kv_state_data[key_name] = pool["pool_name"] in migrated_pools
+
+        return kv_state_data
 
     def _migrate_pool(self, pool: Dict[str, Any]) -> None:
         migrated_pools = self.machine.get_execution_state_data(