change channel back to error when testcase is not passed

Signed-off-by: Matthias Büchse <[email protected]>

Author: mbuechse

Tests/iaas/scs_0100_flavor_naming/flavor_names_check.py

@@ -49,7 +49,7 @@ def compute_scs_0100_semantics_check(scs_flavors: list) -> bool:
             continue  # this case is handled by syntax check
         cpuram = flavorname.cpuram
         if flv.vcpus < cpuram.cpus:
-            logger.info(f"Flavor {flv.name} CPU overpromise: {flv.vcpus} < {cpuram.cpus}")
+            logger.error(f"Flavor {flv.name} CPU overpromise: {flv.vcpus} < {cpuram.cpus}")
             problems.add(flv.name)
         elif flv.vcpus > cpuram.cpus:
             logger.info(f"Flavor {flv.name} CPU underpromise: {flv.vcpus} > {cpuram.cpus}")
@@ -59,7 +59,7 @@ def compute_scs_0100_semantics_check(scs_flavors: list) -> bool:
         if flvram >= 10 and flvram != int(flvram) or flvram * 2 != int(flvram * 2):
             logger.info(f"Flavor {flv.name} uses discouraged uneven size of memory {flvram:.1f} GiB")
         if flvram < cpuram.ram:
-            logger.info(f"Flavor {flv.name} RAM overpromise {flvram:.1f} < {cpuram.ram:.1f}")
+            logger.error(f"Flavor {flv.name} RAM overpromise {flvram:.1f} < {cpuram.ram:.1f}")
             problems.add(flv.name)
         elif flvram > cpuram.ram:
             logger.info(f"Flavor {flv.name} RAM underpromise {flvram:.1f} > {cpuram.ram:.1f}")
@@ -69,7 +69,7 @@ def compute_scs_0100_semantics_check(scs_flavors: list) -> bool:
         if disksize not in ACC_DISK:
             logger.info(f"Flavor {flv.name} non-standard disk size {disksize}, should have (5, 10, 20, 50, 100, 200, ...)")
         if flv.disk < disksize:
-            logger.info(f"Flavor {flv.name} disk overpromise {flv.disk} < {disksize}")
+            logger.error(f"Flavor {flv.name} disk overpromise {flv.disk} < {disksize}")
             problems.add(flv.name)
         elif flv.disk > disksize:
             logger.info(f"Flavor {flv.name} disk underpromise {flv.disk} > {disksize}")

Tests/iaas/scs_0101_entropy/entropy_check.py

@@ -66,7 +66,7 @@ def compute_scs_0101_image_property(images, attributes=IMAGE_ATTRIBUTES):
     # drop those candidates that are fine
     offenders = [candidate for candidate in candidates if candidate[1]]
     for name, wrong in offenders:
-        logger.info(f"Image '{name}' missing recommended attributes: {', '.join(wrong)}")
+        logger.error(f"Image '{name}' missing recommended attributes: {', '.join(wrong)}")
     return not offenders
 
 
@@ -84,15 +84,15 @@ def compute_scs_0101_flavor_property(flavors, attributes=FLAVOR_ATTRIBUTES, opti
             # and if the recommended attributes are present, we assume that implementers have done their job already
             if miss_opt:
                 message += f"; additionally, missing optional attributes: {', '.join(miss_opt)}"
-            logger.info(message)
+            logger.error(message)
     return not offenses
 
 
 def compute_scs_0101_entropy_avail(collected_vm_output, image_name):
     lines = collected_vm_output['entropy-avail']
     entropy_avail = lines[0].strip()
     if entropy_avail != "256":
-        logger.info(
+        logger.error(
             f"VM '{image_name}' didn't have a fixed amount of entropy available. "
             f"Expected 256, got {entropy_avail}."
         )
@@ -103,7 +103,7 @@ def compute_scs_0101_entropy_avail(collected_vm_output, image_name):
 def compute_scs_0101_rngd(collected_vm_output, image_name):
     lines = collected_vm_output['rngd']
     if "could not be found" in '\n'.join(lines):
-        logger.info(f"VM '{image_name}' doesn't provide the recommended service rngd")
+        logger.error(f"VM '{image_name}' doesn't provide the recommended service rngd")
         return False
     return True
 
@@ -123,12 +123,12 @@ def compute_scs_0101_fips_test(collected_vm_output, image_name):
             )
             if int(fips_failures) <= 5:
                 return True  # lenient test passed
-            logger.info(
+            logger.error(
                 f"VM '{image_name}' didn't pass the FIPS 140-2 testing. "
                 f"Expected a maximum of 5 failures, got {fips_failures}."
             )
         else:
-            logger.info(f"VM '{image_name}': failed to determine fips failures")
+            logger.error(f"VM '{image_name}': failed to determine fips failures")
             logger.debug(f"stderr following:\n{fips_data}")
     except BaseException:
         logger.critical(f"Couldn't check VM '{image_name}' requirements", exc_info=True)
@@ -142,7 +142,7 @@ def compute_scs_0101_virtio_rng(collected_vm_output, image_name):
         # `cat` can fail with return code 1 if special file does not exist
         hw_device = lines[0]
         if not hw_device.strip() or "No such device" in lines[1]:
-            logger.info(f"VM '{image_name}' doesn't provide a hardware device.")
+            logger.error(f"VM '{image_name}' doesn't provide a hardware device.")
             return False
         return True
     except BaseException: