Skip to content

Commit 5276cab

Browse files
committed
refracturing
Signed-off-by: Katharina Trentau <[email protected]>
1 parent da50bd7 commit 5276cab

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

Tests/iaas/security-groups/default-security-group-rules.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,21 +32,24 @@ def count_ingress_egress(rules, short=False):
3232
ingress_rules = 0
3333
egress_rules = 0
3434
if short:
35+
print("short")
3536
egress_ipv4 = 0
3637
egress_ipv6 = 0
3738
else:
39+
print("not short")
3840
ingress_from_same_sg = 0
3941
egress_ipv4_default_sg = 0
4042
egress_ipv4_custom_sg = 0
4143
egress_ipv6_default_sg = 0
4244
egress_ipv6_custom_sg = 0
43-
45+
print("43_success")
4446
if not rules:
4547
print("No default security group rules defined.")
4648
else:
4749
for rule in rules:
4850
direction = rule["direction"]
4951
ethertype = rule["ethertype"]
52+
print("50_success")
5053
if not short:
5154
r_custom_sg = rule["used_in_non_default_sg"]
5255
r_default_sg = rule["used_in_default_sg"]
@@ -122,7 +125,8 @@ def count_ingress_egress(rules, short=False):
122125
"Expected rules for egress for IPv4 and IPv6 "
123126
"both for default and custom security groups."
124127
)
125-
ingress_rules, egress_rules
128+
print("done")
129+
return ingress_rules, egress_rules
126130

127131

128132
def test_rules(cloud_name: str):
@@ -285,7 +289,7 @@ def altern_test_rules(cloud_name: str):
285289
# "both for default and custom security groups."
286290
# )
287291

288-
ingress_rules, egress_rules = count_ingress_egress(rules.security_group_rules)
292+
ingress_rules, egress_rules = count_ingress_egress(rules.security_group_rules, True)
289293
delete_security_group(connection, sg_id)
290294

291295
result_dict = {"Ingress Rules": ingress_rules, "Egress Rules": egress_rules}

0 commit comments

Comments
 (0)