Skip to content

Commit 5392c5e

Browse files
committed
Fixup
Add plugin_config to delete process as well Add missing file `kind_cluster_config.yaml` as configuration example Signed-off-by: Toni Finger <[email protected]>
1 parent 2127323 commit 5392c5e

File tree

3 files changed

+11
-4
lines changed

3 files changed

+11
-4
lines changed

Tests/kaas/plugin/run_plugin.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ def run_plugin_create(plugin_kind, plugin_config, clusterspec_cluster, clustersp
2727
plugin.create(clusterspec_cluster, clusterspec[clusterspec_cluster]['branch'], os.path.abspath(clusterspec[clusterspec_cluster]['kubeconfig']))
2828

2929

30-
def run_plugin_delete(plugin_kind, clusterspec_cluster, clusterspec):
31-
plugin = init_plugin(plugin_kind)
30+
def run_plugin_delete(plugin_kind, plugin_config, clusterspec_cluster, clusterspec):
31+
plugin = init_plugin(plugin_kind, plugin_config)
3232
plugin.delete(clusterspec_cluster)
3333

3434

@@ -54,11 +54,12 @@ def create(plugin_kind, plugin_config, clusterspec_path, clusterspec_cluster):
5454

5555
@cli.command()
5656
@click.argument('plugin_kind', type=click.Choice(list(PLUGIN_LOOKUP), case_sensitive=False))
57+
@click.argument('plugin_config', type=click.Path(exists=True, dir_okay=False))
5758
@click.argument('clusterspec_path', type=click.Path(exists=True, dir_okay=False))
5859
@click.argument('clusterspec_cluster', type=str, default="default")
59-
def delete(plugin_kind, clusterspec_path, clusterspec_cluster):
60+
def delete(plugin_kind, plugin_config, clusterspec_path, clusterspec_cluster):
6061
clusterspec = load_spec(clusterspec_path)['clusters']
61-
run_plugin_delete(plugin_kind, clusterspec_cluster, clusterspec)
62+
run_plugin_delete(plugin_kind, plugin_config, clusterspec_cluster, clusterspec)
6263

6364

6465
if __name__ == '__main__':

Tests/scs-test-runner.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,7 @@ def build_unprovision_command(self, subject):
109109
sys.executable, self.run_plugin_py,
110110
'delete',
111111
kubernetes_setup['kube_plugin'],
112+
self.abspath(kubernetes_setup['kube_plugin_config']),
112113
self.abspath(kubernetes_setup['clusterspec']),
113114
kubernetes_setup['clusterspec_cluster'],
114115
],
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
kind: Cluster
2+
apiVersion: kind.x-k8s.io/v1alpha4
3+
nodes:
4+
- role: control-plane
5+
- role: worker

0 commit comments

Comments
 (0)